Re: [Openocd-development] OpenOCD 0.5.0-rc1 release

2011-06-29 Thread Øyvind Harboe
On Wed, Jun 29, 2011 at 7:43 AM, simon qian simonqian.open...@gmail.com wrote: Is it possible to update Versaloon driver in 0.5.0 release? Mail me if there is any problem with the driver patch. I don't have a problem with applying this patch as it only affects the versaloon interface driver...

Re: [Openocd-development] RFC Release Cycle

2011-06-29 Thread Øyvind Harboe
So when I send a pull request to you from my repository, would you rebase or merge? We now have a nice linear history, which gives me a warm fuzzy feeling for a simple project like OpenOCD What would a typical pull request look like? Subject: Pull request - my master branch has some fixes

Re: [Openocd-development] compiler warnings with dsp5680xx.c

2011-06-29 Thread Øyvind Harboe
This is disturbing. Why switch to global variables? +static uint32_t data_read_dummy; static int jtag_data_write(struct target * target, uint32_t instr,int num_bits, uint32_t * data_read){ int retval; - uint32_t data_read_dummy; Seperate patch? Does this have anything to do with fixing

Re: [Openocd-development] [OpenOCD][MIPS32][PATCH] Fix soft breakpoint unsetting endianess

2011-06-29 Thread Drasko DRASKOVIC
Hi all, I have additional questions about target_read_memory() and target_read_u32() used to set/unset breakpoints. I can see that target_read_memory() simply calls mips_m4k_write_memory() and since I have big endian MIPS target, bytes are not swapped. However, target_read_u32(), besides calling

Re: [Openocd-development] RFC Release Cycle

2011-06-29 Thread Jean-Christophe PLAGNIOL-VILLARD
On 08:34 Wed 29 Jun , Øyvind Harboe wrote: So when I send a pull request to you from my repository, would you rebase or merge? merge never rebase the master repo We now have a nice linear history, which gives me a warm fuzzy feeling for a simple project like OpenOCD What would a

Re: [Openocd-development] OpenOCD 0.5.0-rc1 release

2011-06-29 Thread Jean-Christophe PLAGNIOL-VILLARD
On 07:24 Wed 29 Jun , Øyvind Harboe wrote: On Wed, Jun 29, 2011 at 2:30 AM, Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com wrote: On 20:20 Tue 28 Jun     , Øyvind Harboe wrote: Where is the plan? I'll write the patch when we have finish the discussion about the workflow now

Re: [Openocd-development] OpenOCD 0.5.0-rc1 release

2011-06-29 Thread Jean-Christophe PLAGNIOL-VILLARD
On 08:13 Wed 29 Jun , Øyvind Harboe wrote: On Wed, Jun 29, 2011 at 7:43 AM, simon qian simonqian.open...@gmail.com wrote: Is it possible to update Versaloon driver in 0.5.0 release? Mail me if there is any problem with the driver patch. I don't have a problem with applying this patch

Re: [Openocd-development] RFC Release Cycle

2011-06-29 Thread Jean-Christophe PLAGNIOL-VILLARD
On 07:21 Wed 29 Jun , Øyvind Harboe wrote: I'd have some reservations about only one person having write access, but not particularly the way of working. Call me old fashioned. Does not mean you do not have the write access does just mean you dont use it As example if the release

Re: [Openocd-development] RFC Release Cycle

2011-06-29 Thread Øyvind Harboe
On Wed, Jun 29, 2011 at 4:25 PM, Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com wrote: On 08:34 Wed 29 Jun     , Øyvind Harboe wrote: So when I send a pull request to you from my repository, would you rebase or merge? merge never rebase the master repo I was thinking about branches

Re: [Openocd-development] OpenOCD 0.5.0-rc1 release

2011-06-29 Thread Øyvind Harboe
On Wed, Jun 29, 2011 at 4:32 PM, Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com wrote: On 07:24 Wed 29 Jun     , Øyvind Harboe wrote: On Wed, Jun 29, 2011 at 2:30 AM, Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com wrote: On 20:20 Tue 28 Jun     , Øyvind Harboe wrote: Where

[Openocd-development] [PATCH] jimtcl: update to 0.71 based release

2011-06-29 Thread Spencer Oliver
From: Spencer Oliver ntfr...@users.sourceforge.net The actual release is 411e92fea9621630eb350e0c2bb43543e553b84f as we had a few issues relating to its use within openocd. Signed-off-by: Spencer Oliver ntfr...@users.sourceforge.net --- jimtcl |2 +- 1 files changed, 1 insertions(+), 1

Re: [Openocd-development] compiler warnings with dsp5680xx.c

2011-06-29 Thread Rodrigo Rosa
On Wed, Jun 29, 2011 at 12:44 AM, Øyvind Harboe oyvind.har...@zylin.com wrote: This is disturbing. Why switch to global variables? +static uint32_t data_read_dummy;  static int jtag_data_write(struct target * target, uint32_t instr,int num_bits, uint32_t * data_read){   int retval; -  

Re: [Openocd-development] compiler warnings with dsp5680xx.c

2011-06-29 Thread Øyvind Harboe
Seperate patch? Does this have anything to do with fixing warnings? -      counter = FLUSH_COUNT_FLASH; +      counter = FLUSH_COUNT_READ_WRITE; nothing to do with warnings, but it doesn't really affect anything, since both constants are defined to the same value (i'm was experimenting

Re: [Openocd-development] compiler warnings with dsp5680xx.c

2011-06-29 Thread Rodrigo Rosa
On Wed, Jun 29, 2011 at 12:20 PM, Øyvind Harboe oyvind.har...@zylin.com wrote: Seperate patch? Does this have anything to do with fixing warnings? -      counter = FLUSH_COUNT_FLASH; +      counter = FLUSH_COUNT_READ_WRITE; nothing to do with warnings, but it doesn't really affect anything,

Re: [Openocd-development] compiler warnings with dsp5680xx.c

2011-06-29 Thread Øyvind Harboe
Could you create a branch in your fork and post something when it's ready? Thanks! -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 / International +47 51 87 40 27 http://www.zylin.com/ ___

Re: [Openocd-development] compiler warnings with dsp5680xx.c

2011-06-29 Thread Rodrigo Rosa
patches 1,2,3,4 get the target to the state it was before it was disabled, but with the warnings fixed. why were the warnings not showing up when i originally submitted the patch? the dsp5680xx has been around for at least a month... i'm worried about not being able to get the compiler to show me

Re: [Openocd-development] compiler warnings with dsp5680xx.c

2011-06-29 Thread Andreas Fritiofson
On Wed, Jun 29, 2011 at 9:17 PM, Rodrigo Rosa rodrigorosa...@gmail.comwrote: On Wed, Jun 29, 2011 at 12:44 AM, Øyvind Harboe oyvind.har...@zylin.com wrote: This is disturbing. Why switch to global variables? +static uint32_t data_read_dummy; static int jtag_data_write(struct target *

Re: [Openocd-development] compiler warnings with dsp5680xx.c

2011-06-29 Thread Øyvind Harboe
The warnings are gone. I saw some more followup to your patches. Could you work over that feedback and push a fix to a branch in your fork and post a message when it's ready? Thanks! We may be moving to pull requests soon -- Øyvind Harboe - Can Zylin Consulting help on your project? US

Re: [Openocd-development] compiler warnings with dsp5680xx.c

2011-06-29 Thread Rodrigo Rosa
On Wed, Jun 29, 2011 at 3:43 PM, Andreas Fritiofson andreas.fritiof...@gmail.com wrote: On Wed, Jun 29, 2011 at 9:17 PM, Rodrigo Rosa rodrigorosa...@gmail.com wrote: On Wed, Jun 29, 2011 at 12:44 AM, Øyvind Harboe oyvind.har...@zylin.com wrote: This is disturbing. Why switch to global