On Wed, Jun 29, 2011 at 7:43 AM, simon qian simonqian.open...@gmail.com wrote:
Is it possible to update Versaloon driver in 0.5.0 release?
Mail me if there is any problem with the driver patch.
I don't have a problem with applying this patch as it only affects the versaloon
interface driver...
So when I send a pull request to you from my repository, would
you rebase or merge?
We now have a nice linear history, which gives me a warm fuzzy
feeling for a simple project like OpenOCD
What would a typical pull request look like?
Subject: Pull request - my master branch has some fixes
This is disturbing. Why switch to global variables?
+static uint32_t data_read_dummy;
static int jtag_data_write(struct target * target, uint32_t instr,int
num_bits, uint32_t * data_read){
int retval;
- uint32_t data_read_dummy;
Seperate patch? Does this have anything to do with fixing
Hi all,
I have additional questions about target_read_memory() and
target_read_u32() used to set/unset breakpoints.
I can see that target_read_memory() simply calls
mips_m4k_write_memory() and since I have big endian MIPS target, bytes
are not swapped.
However, target_read_u32(), besides calling
On 08:34 Wed 29 Jun , Øyvind Harboe wrote:
So when I send a pull request to you from my repository, would
you rebase or merge?
merge never rebase the master repo
We now have a nice linear history, which gives me a warm fuzzy
feeling for a simple project like OpenOCD
What would a
On 07:24 Wed 29 Jun , Øyvind Harboe wrote:
On Wed, Jun 29, 2011 at 2:30 AM, Jean-Christophe PLAGNIOL-VILLARD
plagn...@jcrosoft.com wrote:
On 20:20 Tue 28 Jun , Øyvind Harboe wrote:
Where is the plan?
I'll write the patch when we have finish the discussion about the workflow
now
On 08:13 Wed 29 Jun , Øyvind Harboe wrote:
On Wed, Jun 29, 2011 at 7:43 AM, simon qian simonqian.open...@gmail.com
wrote:
Is it possible to update Versaloon driver in 0.5.0 release?
Mail me if there is any problem with the driver patch.
I don't have a problem with applying this patch
On 07:21 Wed 29 Jun , Øyvind Harboe wrote:
I'd have some reservations about only one person having write
access, but not particularly the way of working. Call me old fashioned.
Does not mean you do not have the write access does just mean you dont use
it
As example if the release
On Wed, Jun 29, 2011 at 4:25 PM, Jean-Christophe PLAGNIOL-VILLARD
plagn...@jcrosoft.com wrote:
On 08:34 Wed 29 Jun , Øyvind Harboe wrote:
So when I send a pull request to you from my repository, would
you rebase or merge?
merge never rebase the master repo
I was thinking about branches
On Wed, Jun 29, 2011 at 4:32 PM, Jean-Christophe PLAGNIOL-VILLARD
plagn...@jcrosoft.com wrote:
On 07:24 Wed 29 Jun , Øyvind Harboe wrote:
On Wed, Jun 29, 2011 at 2:30 AM, Jean-Christophe PLAGNIOL-VILLARD
plagn...@jcrosoft.com wrote:
On 20:20 Tue 28 Jun , Øyvind Harboe wrote:
Where
From: Spencer Oliver ntfr...@users.sourceforge.net
The actual release is 411e92fea9621630eb350e0c2bb43543e553b84f as we
had a few issues relating to its use within openocd.
Signed-off-by: Spencer Oliver ntfr...@users.sourceforge.net
---
jimtcl |2 +-
1 files changed, 1 insertions(+), 1
On Wed, Jun 29, 2011 at 12:44 AM, Øyvind Harboe oyvind.har...@zylin.com wrote:
This is disturbing. Why switch to global variables?
+static uint32_t data_read_dummy;
static int jtag_data_write(struct target * target, uint32_t instr,int
num_bits, uint32_t * data_read){
int retval;
-
Seperate patch? Does this have anything to do with fixing warnings?
- counter = FLUSH_COUNT_FLASH;
+ counter = FLUSH_COUNT_READ_WRITE;
nothing to do with warnings, but it doesn't really affect anything,
since both constants are defined to the same value (i'm was
experimenting
On Wed, Jun 29, 2011 at 12:20 PM, Øyvind Harboe oyvind.har...@zylin.com wrote:
Seperate patch? Does this have anything to do with fixing warnings?
- counter = FLUSH_COUNT_FLASH;
+ counter = FLUSH_COUNT_READ_WRITE;
nothing to do with warnings, but it doesn't really affect anything,
Could you create a branch in your fork and post something when it's ready?
Thanks!
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434 / International +47 51 87 40 27
http://www.zylin.com/
___
patches 1,2,3,4 get the target to the state it was before it was
disabled, but with the warnings fixed.
why were the warnings not showing up when i originally submitted the patch?
the dsp5680xx has been around for at least a month...
i'm worried about not being able to get the compiler to show me
On Wed, Jun 29, 2011 at 9:17 PM, Rodrigo Rosa rodrigorosa...@gmail.comwrote:
On Wed, Jun 29, 2011 at 12:44 AM, Øyvind Harboe oyvind.har...@zylin.com
wrote:
This is disturbing. Why switch to global variables?
+static uint32_t data_read_dummy;
static int jtag_data_write(struct target *
The warnings are gone.
I saw some more followup to your patches. Could you work over
that feedback and push a fix to a branch in your fork and post
a message when it's ready?
Thanks!
We may be moving to pull requests soon
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US
On Wed, Jun 29, 2011 at 3:43 PM, Andreas Fritiofson
andreas.fritiof...@gmail.com wrote:
On Wed, Jun 29, 2011 at 9:17 PM, Rodrigo Rosa rodrigorosa...@gmail.com
wrote:
On Wed, Jun 29, 2011 at 12:44 AM, Øyvind Harboe oyvind.har...@zylin.com
wrote:
This is disturbing. Why switch to global
19 matches
Mail list logo