Re: [Openocd-development] [PATCH] fix warnings in usbprog

2009-04-19 Thread Øyvind Harboe
Committed. Thanks! -- Øyvind Harboe Embedded software and hardware consulting services http://consulting.zylin.com ___ Openocd-development mailing list Openocd-development@lists.berlios.de

[Openocd-development] [PATCH] fix warnings in usbprog

2009-04-18 Thread Zach Welch
Hi all, The attached patch fixes pointer-sign warnings in the usbprog module. In the process, I could not help but simplify the code to be a little more compact/readable (maintaining functional equivalence). Cheers, Zach Index: src/jtag/usbprog.c

Re: [Openocd-development] [PATCH] fix warnings in usbprog

2009-04-18 Thread Zach Welch
On Sat, 2009-04-18 at 15:35 -0700, Zach Welch wrote: Hi all, The attached patch fixes pointer-sign warnings in the usbprog module. In the process, I could not help but simplify the code to be a little more compact/readable (maintaining functional equivalence). Oops. I made a last second

Re: [Openocd-development] [PATCH] fix warnings in usbprog

2009-04-18 Thread Fab Clement
Hi From what I read in the patch no default test means possible crash, that was not possible with previous code My 2cts Fab On Sun, Apr 19, 2009 at 12:35 AM, Zach Welch z...@superlucidity.net wrote: Hi all, The attached patch fixes pointer-sign warnings in the usbprog module. In the

Re: [Openocd-development] [PATCH] fix warnings in usbprog

2009-04-18 Thread Zach Welch
Well, I checked around in the code, and it seems that function is only called with a type produced by jtag_scan_type. That function returns a value that is covered by the three cases; moreover, those three values are the only ones defined for enum scan_type. It really should never hit the