[devel] [PATCH 1 of 1] amfnd: issue callback to healthy components when fault occurs in quiescing state [#492]

2013-08-01 Thread praveen . malviya
osaf/services/saf/avsv/avnd/avnd_comp.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) A component is faulted with component restart recovery. During this restarting phase, active or quiescing states of assigned SIs may change to quiesced state due to fault in the any other comp

[devel] [PATCH 0 of 1] Review Request for amfnd: issue callback to healthy components when fault occurs in quiescing state [#492]

2013-08-01 Thread praveen . malviya
Summary: amfnd: issue callback to healthy components when fault occurs in quiescing state [#492] Review request for Trac Ticket(s):amf #492 Peer Reviewer(s):Nagendra, Hans Pull request to: <> Affected branch(es):All Development branch: <> Impacted area I

[devel] [PATCH 0 of 1] Review Request for amfnd: mark CSI state assigning for quiesced SI in comp restart recovery [#491]

2013-08-01 Thread praveen . malviya
Summary: amfnd: mark CSI state assigning for quiesced SI in comp restart recovery [#491] Review request for Trac Ticket(s):amf [#491] Peer Reviewer(s):Hans F., Nagendra Pull request to: <> Affected branch(es):All Development branch: <> Impacted area Impa

[devel] [PATCH 1 of 1] amfnd: mark CSI state assigning for quiesced SI in comp restart recovery [#491]

2013-08-01 Thread praveen . malviya
osaf/services/saf/avsv/avnd/avnd_comp.c | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) A component is faulted with component restart recovery. During this restarting phase, active or quiescing states of assigned SIs may change to quiesced state due to fault in the any ot

Re: [devel] [PATCH 1 of 1] plm: fix build errors thrown by gcc > 4.6 [#527]

2013-08-01 Thread Anders Widell
Ok, yes possibly some code analysis tool could be happier with (void) in front of them. I am happy either way! :-) regards, Anders Widell 2013-08-01 14:38, Mathivanan Naickan Palanivelu skrev: >> It is possible to add (void) in front of strtok(), but it's not necessary in >> order >> to get rid

Re: [devel] [PATCH 1 of 1] plm: fix build errors thrown by gcc > 4.6 [#527]

2013-08-01 Thread Mathivanan Naickan Palanivelu
> > It is possible to add (void) in front of strtok(), but it's not necessary in > order > to get rid of the compiler warnings. > Yes, I meant to cast it to void to satisfy some code analysis tools. > You can't remove the calls to strtok(), if that is what you mean. > strtok() has side effects!

Re: [devel] [PATCH 1 of 1] plm: fix build errors thrown by gcc > 4.6 [#527]

2013-08-01 Thread Anders Widell
It is possible to add (void) in front of strtok(), but it's not necessary in order to get rid of the compiler warnings. You can't remove the calls to strtok(), if that is what you mean. strtok() has side effects! regards, Anders Widell 2013-08-01 13:52, Mathivanan Naickan Palanivelu skrev: > P

Re: [devel] [PATCH 1 of 1] plm: fix build errors thrown by gcc > 4.6 [#527]

2013-08-01 Thread Anders Widell
Ack. regards, Anders Widell 2013-08-01 13:45, mathi.naic...@oracle.com skrev: > osaf/services/saf/plmsv/plms/hpi_intf/plms_epath_util.c | 3 --- > osaf/services/saf/plmsv/plms/hpi_intf/plms_hrb.c| 7 --- > osaf/services/saf/plmsv/plms/plms_imm.c | 14 +++--

Re: [devel] [PATCH 1 of 1] plm: fix build errors thrown by gcc > 4.6 [#527]

2013-08-01 Thread Mathivanan Naickan Palanivelu
Perhaps, its better to cast out the strotk() calls wherever the return values are ignored! Thanks, Mathi. > -Original Message- > From: Mathivanan Naickan Palanivelu > Sent: Thursday, August 01, 2013 5:15 PM > To: anders.wid...@ericsson.com > Cc: opensaf-devel@lists.sourceforge.net > Subje

[devel] [PATCH 1 of 1] plm: fix build errors thrown by gcc > 4.6 [#527]

2013-08-01 Thread mathi . naickan
osaf/services/saf/plmsv/plms/hpi_intf/plms_epath_util.c | 3 --- osaf/services/saf/plmsv/plms/hpi_intf/plms_hrb.c| 7 --- osaf/services/saf/plmsv/plms/plms_imm.c | 14 +++--- osaf/services/saf/plmsv/plms/plms_utils.c | 3 --- 4 files changed

[devel] [PATCH 0 of 1] Review Request for plm: fix build errors thrown by gcc version > 4.6 [#527]

2013-08-01 Thread mathi . naickan
Summary: plm: fix build errors generated by gcc version > 4.6 [#527] Review request for Trac Ticket(s): #527 Peer Reviewer(s): Anders Widell Pull request to: <> Affected branch(es): 4.2.x, 4.3.x, default Development branch: <> Impacted area Impact y/n -

Re: [devel] [PATCH 1 of 1] osaf: support killall cmd as non-root user for amfwdog [#451]

2013-08-01 Thread Anders Widell
Ack. regards, Anders Widell 2013-07-31 18:50, mathi.naic...@oracle.com skrev: > 00-README.conf| 3 ++- > opensaf.spec.in | 2 +- > osaf/services/saf/avsv/amfwdog/amf_wdog.c | 12 ++-- > 3 files changed, 13 insertions(+), 4 de