Re: [devel] Build error on 32-bit architecture

2013-09-09 Thread Nagendra Kumar
Hi Anders W, We will correct and push it along with 562 patch. Thanks -Nagu -Original Message- From: Anders Widell [mailto:anders.wid...@ericsson.com] Sent: 07 September 2013 20:43 To: opensaf-devel@lists.sourceforge.net Subject: [devel] Build error on 32-bit

Re: [devel] [PATCH 1 of 1] amfsv: Donot assign SUSI to instantiating SU during SG unlock [#562]

2013-09-09 Thread Hans Feldt
Oh well... Ack if you add something like this in the code: // TODO(nagu) remove saAmfSUPreInstantiable check and move into m_AVD_APP_SU_IS_INSVC Thanks, Hans On 09/09/2013 08:56 AM, Nagendra Kumar wrote: Hi Hans, This would be done as part of ticket # 445. Adding it in

Re: [devel] [PATCH 1 of 1] IMMTOOL: add missing library to Makefile.am of immcfg [#20]

2013-09-09 Thread Hans Feldt
Ack, builds for me /Hans On 09/06/2013 04:53 PM, Zoran Milinkovic wrote: osaf/tools/safimm/immcfg/Makefile.am | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) Add libdl library to Makefile.am for immcfg. On Ubuntu 13.04 with gcc 4.7.3, it's not possible to link files without

Re: [devel] [PATCH 0 of 1] Review Request for IMMTOOLS: add transactions to immcfg [#20]

2013-09-09 Thread Hans Feldt
Hi, I think some help text is missing (even better a man page but that is for later). I don't understand how to use this feature. Could you explain here first and add into the help text of immcfg? Thanks, Hans On 07/18/2013 03:27 PM, Zoran Milinkovic wrote: Summary: IMMTOOLS: add

[devel] [PATCH 0 of 1] Review Request for Amfd: Allow admin operation on middleware only when originated from SMF [#477]

2013-09-09 Thread nagendra . k
Summary: Amfd: Allow admin operation on middleware only when originated from SMF [#477] Review request for Trac Ticket(s): #477 Peer Reviewer(s): Mathi, Hans F, Hans N, Praveen Pull request to: LIST THE PERSON WITH PUSH ACCESS HERE Affected branch(es): All Development branch: Default

[devel] [PATCH 1 of 1] Amfd: Allow admin operation on middleware only when originated from SMF [#477]

2013-09-09 Thread nagendra . k
osaf/services/saf/amf/amfd/avd_su.cc | 27 +++ 1 files changed, 27 insertions(+), 0 deletions(-) diff --git a/osaf/services/saf/amf/amfd/avd_su.cc b/osaf/services/saf/amf/amfd/avd_su.cc --- a/osaf/services/saf/amf/amfd/avd_su.cc +++

[devel] [PATCH 0 of 1] Review Request for IMM: fix memory leak in imma_search_node_delete function [#549]

2013-09-09 Thread Zoran Milinkovic
Summary: IMM: fix memory leak in imma_search_node_delete function [#549] Review request for Trac Ticket(s): 549 Peer Reviewer(s): Neel Pull request to: Zoran Affected branch(es): opensaf-4.2.x, opensaf-4.3.x Development branch: opensaf-4.2.x Impacted area

Re: [devel] [PATCH 0 of 1] Review Request for IMM: fix memory leak in imma_search_node_delete function [#549]

2013-09-09 Thread Hans Feldt
Guess you should add a new test case? Sent from my smart phone Zoran Milinkovic zoran.milinko...@ericsson.com skrev: Summary: IMM: fix memory leak in imma_search_node_delete function [#549] Review request for Trac Ticket(s): 549 Peer Reviewer(s): Neel Pull request to: Zoran Affected

Re: [devel] [PATCH 0 of 1] Review Request for IMMTOOL: add missing library to Makefile.am of immcfg [#20]

2013-09-09 Thread Neelakanta Reddy
Hi zoran, Reviewed the patch. Ack. while adding help message to immcfg, add the ctrl+c and ctrl+d behavior with transaction mode. /Neel. On Friday 06 September 2013 08:23 PM, Zoran Milinkovic wrote: Summary: IMMTOOL: add missing library to Makefile.am of immcfg [#20] Review request for