Re: [devel] [PATCH 1 of 1] IMM: fix the memory leaks when ncs_lock failed in IMM agent

2013-09-20 Thread Zoran Milinkovic
In @@ -6469,8 +6478,7 @@ SaAisErrorT saImmOmSearchNext_2(SaImmSea if (m_NCS_LOCK(cb-cb_lock, NCS_LOCK_WRITE) != NCSCC_RC_SUCCESS) { TRACE_4(ERR_LIBRARY: Lock error); - return SA_AIS_ERR_LIBRARY; - /*Error case will leak memory. */ +

Re: [devel] [PATCH 1 of 1] IMM: fix the memory leaks when ncs_lock failed in IMM agent

2013-09-20 Thread Neelakanta Reddy
Hi zoran, will add the error code. /Neel. On Friday 20 September 2013 11:36 AM, Zoran Milinkovic wrote: In @@ -6469,8 +6478,7 @@ SaAisErrorT saImmOmSearchNext_2(SaImmSea if (m_NCS_LOCK(cb-cb_lock, NCS_LOCK_WRITE) != NCSCC_RC_SUCCESS) { TRACE_4(ERR_LIBRARY: Lock

Re: [devel] [PATCH 1 of 1] IMM: fix the memory leaks when ncs_lock failed in IMM agent

2013-09-20 Thread Neelakanta Reddy
Hi zoran, will update your comments, while pushing. /Neel. On Thursday 19 September 2013 08:03 PM, Zoran Milinkovic wrote: Hi Neel, I have tested saImmOmClassDescriptionMemoryFree_2() and it's ack. The rest of the code I just did a review without testing, and here are my comments: -