Re: [devel] [PATCH 1 of 1] amfd: Reject admin op if csi add/remove is in progress [#627]

2013-12-02 Thread Nagendra Kumar
Hi Hans, Thanks for the patch. But, this change is not in scope of this ticket. You can create a ticket for adding su in oper state and we can take test it in those scenarios. Thanks -Nagu -Original Message- From: Hans Feldt [mailto:hans.fe...@ericsson.com] Sent: 21 November

Re: [devel] make rpm is failing: ticket# 580

2013-12-02 Thread Anders Widell
Oops, forgot about that one. It is fixed now. thanks, Anders Widell 2013-12-02 07:43, Ramesh Betham skrev: Hi Anders, make rpm fails, please check. (osaf_poll.h, osaf_time.h should add in ../osaf/libs/core/common/includeMakefile.am) Thanks, Ramesh. libopensaf_common_la-osaf_poll.lo -MD

Re: [devel] [PATCH 1 of 1] base: Add osaf_poll.h and osaf_time.h APIs [#580]

2013-12-02 Thread Anders Widell
The POLLHUP seems to happen quite frequently (revents=17), so I will filter the log messages in that case. regards, Anders Widell 2013-11-29 09:53, Mathivanan Naickan Palanivelu skrev: Ack. Good that you were able to work on this ticket, would be a good value add. One comment is that, we

[devel] [PATCH 0 of 1] Review Request for logsv: Handle log files on both active and standby [#152]

2013-12-02 Thread Lennart Lund
Summary: logsv: Handle log files on both active and standby Review request for Trac Ticket(s): #152 Peer Reviewer(s): Pull request to: LIST THE PERSON WITH PUSH ACCESS HERE Affected branch(es): default (4.4) Development branch: IF ANY GIVE THE REPO URL Impacted

Re: [devel] [PATCH 1 of 1] amfd: Add oper state criteria for SUs for stopping Cluster Timer[#76]

2013-12-02 Thread Hans Feldt
Hi, It seems (from my testing) that the patch fixes the problem for pre-instantiable service units. But most likely not for non-pre-instantiable SUs. Your code comment started my thinking that we should really be checking SUs Readiness State for INSERVICE instead. Which means

Re: [devel] [PATCH 1 of 1] amfd: Add oper state criteria for SUs for stopping Cluster Timer[#76]

2013-12-02 Thread Nagendra Kumar
Hi Hans, NPI is not started till given assignment, so I don't understand, why npi su should be considered or was rather left out in the patch ? Please elaborate. I will change the function name. Thanks -Nagu -Original Message- From: Hans Feldt [mailto:hans.fe...@ericsson.com]

Re: [devel] [PATCH 1 of 1] amfd: Add oper state criteria for SUs for stopping Cluster Timer[#76]

2013-12-02 Thread Hans Feldt
The readiness state of a non-pre-instantiable service unit is in-service if all of the following conditions are met: * its operational state and the operational state of its containing node is enabled So what I mean is the logic cannot check presence state since NPI SUs would not be

Re: [devel] [PATCH 1 of 1] cpsv: standardize arrival callback API(s) with SAF syntax [#561]

2013-12-02 Thread Hans Feldt
Hi, I am confused by this: saCkptTrack - This function enable the Ckpt Track call back saCkptCheckpointTrack - This function enables the specific Checkpoint Track call back The latter is empty, can you explain? Thanks, Hans On 12/02/2013 07:37 AM, mahesh.va...@oracle.com wrote:

[devel] [PATCH 0 of 1] Review Request for IMM: Update the README file to document NO_DANGLING [#635]

2013-12-02 Thread Anders Bjornerstedt
Summary: IMM: Update the README file to document NO_DANGLING [#635] Review request for Trac Ticket(s): 635 Peer Reviewer(s): Neel ; Zoran Pull request to: Affected branch(es): default(4.4) Development branch: Impacted area Impact y/n

[devel] [PATCH 1 of 1] IMM: immadm aware of admowner safImmService for opensafImm=opensafImm, safApp=safImmService [#642]

2013-12-02 Thread Anders Bjornerstedt
osaf/tools/safimm/immadm/imm_admin.c | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/osaf/tools/safimm/immadm/imm_admin.c b/osaf/tools/safimm/immadm/imm_admin.c --- a/osaf/tools/safimm/immadm/imm_admin.c +++ b/osaf/tools/safimm/immadm/imm_admin.c @@ -37,6

[devel] [PATCH 0 of 1] Review Request for IMM: immadm aware of admowner safImmService for opensafImm=opensafImm, safApp=safImmService [#642]

2013-12-02 Thread Anders Bjornerstedt
Summary: IMM: immadm aware of admowner safImmService for opensafImm=opensafImm,safApp=safImmService [#642] Review request for Trac Ticket(s): 642 Peer Reviewer(s): Neel Pull request to: Affected branch(es): default(4.4) Development branch: Impacted area

Re: [devel] [PATCH 1 of 1] cpsv: standardize arrival callback API(s) with SAF syntax [#561]

2013-12-02 Thread A V Mahesh
Hi, The scope of this patch is primarily to convert the existing functionality to SAF API syntax. i.e The existing functionality supports tracking checkpoint writes per (user- initialized handle) SaCkptHandleT . So, this existing functionality shall be provided by this API saCkptTrack().

[devel] [PATCH 0 of 1] Review Request for cpsv: Memory Leaks when reploc node add delete in cpd [#529]

2013-12-02 Thread mahesh . valla
Summary:cpsv: Memory Leaks when reploc node add delete in cpd [#529] Review request for Trac Ticket(s): #529 Peer Reviewer(s): Ramesh Pull request to: LIST THE PERSON WITH PUSH ACCESS HERE Affected branch(es): default Development branch: default Impacted area

[devel] [PATCH 1 of 1] cpsv: Memory Leaks when reploc node add delete in cpd [#529]

2013-12-02 Thread mahesh . valla
osaf/libs/common/cpsv/include/cpd_cb.h | 5 +- osaf/services/saf/cpsv/cpd/cpd_db.c| 38 +++ osaf/services/saf/cpsv/cpd/cpd_imm.c | 39 ++- osaf/services/saf/cpsv/cpd/cpd_proc.c | 32 +-- osaf/services/saf/cpsv/cpd/cpd_sbevt.c |