Re: [devel] [PATCH 1 of 4] clm: add to the information model and update config, scripts [#220]

2013-12-13 Thread Mathivanan Naickan Palanivelu
> saVersion=1 would be better > > adding 4.0.0 was a mistake I did Wel, 4.0.0 is still && can-be considered as a baseline version! I suggest let's leave it at 4.0.0 itself, and increment everybody in the next release Or probably increment everybody in this release itself?!( I remember that is ho

Re: [devel] [PATCH 1 of 1] build: Add extra GCC hardening compilation flags [#650]

2013-12-13 Thread Mathivanan Naickan Palanivelu
The page is explaining more about the "order" of these flags. My interest in this page was more to do with the order in which these flags would get 'applied' on to the AM_**flags (and not in the context of C or C++!!) Basically wanted to be sure of any further chance of 'overwriding' of these fla

Re: [devel] [PATCH 1 of 1] build: Add extra GCC hardening compilation flags [#650]

2013-12-13 Thread Anders Widell
It was an interesting page; I haven't read it before. Btw the name CPPFLAGS could be confusing at first: "CPP" stands for C PreProcessor, not "C Plus Plus". So it applies to both C and C++ code. regards, Anders Widell 2013-12-13 11:34, Mathivanan Naickan Palanivelu skrev: > Ack. > I was going t

Re: [devel] [PATCH 1 of 1] base: skip syslog in logtrace when nospc [#658]

2013-12-13 Thread Anders Widell
Ack. Maybe you could consider if it makes sense to do the following improvement, though: Log to syslog ONCE until the error goes away. This could be done for all values of errno (execpt EAGAIN and EINTR) by introducing a flag. When write fails, log to syslog once and set the flag. Don't log an

[devel] [PATCH 1 of 1] smfd: smfBundleCheckCmd called as part of prerequisites test [656]

2013-12-13 Thread Ingvar Bergstrom
00-README.conf | 12 + osaf/services/saf/smfsv/scripts/smf-bundle-check | 139 ++ osaf/services/saf/smfsv/smfd/SmfCampState.cc | 90 ++ 3 files changed, 88 insertions(+), 153 deletions(-) Includes the invocation of the co

[devel] [PATCH 0 of 1] Review Request for SMF #656

2013-12-13 Thread Ingvar Bergstrom
Summary: smfd: smfBundleCheckCmd called as part of prerequisites test Review request for Trac Ticket(s): 656 Peer Reviewer(s): bertil Pull request to: Affected branch(es): default Development branch: default Impacted area Impact y/n -

[devel] [PATCH 1 of 1] base: skip syslog in logtrace when nospc [#658]

2013-12-13 Thread Hans Feldt
osaf/libs/core/common/logtrace.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/osaf/libs/core/common/logtrace.c b/osaf/libs/core/common/logtrace.c --- a/osaf/libs/core/common/logtrace.c +++ b/osaf/libs/core/common/logtrace.c @@ -120,7 +120,7 @@ write_retry: if (i

[devel] [PATCH 0 of 1] Review Request for base #658

2013-12-13 Thread Hans Feldt
Summary: <> Review request for Trac Ticket(s): 658 Peer Reviewer(s): Anders Widell Pull request to: <> Affected branch(es): <> Development branch: <> Impacted area Impact y/n Docsn Build system

Re: [devel] [PATCH 1 of 1] build: Add extra GCC hardening compilation flags [#650]

2013-12-13 Thread Mathivanan Naickan Palanivelu
Ack. I was going through this link to review this patch. http://www.gnu.org/software/automake/manual/html_node/Flag-Variables-Ordering.html It might be of interest to you too. Basically, I wanted to figure out whether CPP_FLAGS should be passed to AM_CPP FLAGS or to AM_CXX FLAGS. - Mathi. >

Re: [devel] [PATCH 0 of 1] Review Request for build: Add extra GCC hardening compilation flags [#650]

2013-12-13 Thread Hans Feldt
Hi, Can we have this pushed asap? It will only add to hardening of opensaf. Thanks, Hans On 12/09/2013 12:44 PM, Anders Widell wrote: > Summary: build: Add extra GCC hardening compilation flags [#650] > Review request for Trac Ticket(s): 650 > Peer Reviewer(s): Mathi -

Re: [devel] [PATCH 1 of 4] clm: add to the information model and update config, scripts [#220]

2013-12-13 Thread Anders Björnerstedt
The IMMSV_NUM_NODES and IMMSV_MAX_WAIT are just heuristic parameters with the goal of having a significant subset of the intended cluster participate in loading. Nodes that dont come up In time to participate in loading have to be synced after loading, which can increase the Time it takes for

Re: [devel] [PATCH 1 of 4] clm: add to the information model and update config, scripts [#220]

2013-12-13 Thread Mathivanan Naickan Palanivelu
> > And I forgot, please move clmna or whatever it will be called before immnd Yeah, we could have a renaming ceremony in 4.5, but Today I just left it to be termed as clmna(with recovery as node failfast), because handle management is still with CLMServer. Sure, I should change the binary name

Re: [devel] [PATCH 1 of 4] clm: add to the information model and update config, scripts [#220]

2013-12-13 Thread Hans Feldt
And I forgot, please move clmna or whatever it will be called before immnd in nodeinit.payload so that immnd does not get synced on a non member node. /Hans On 12/13/2013 08:59 AM, Hans Feldt wrote: > > > On 12/04/2013 02:00 PM, mathi.naic...@oracle.com wrote: >>opensaf.spec.in

Re: [devel] [PATCH 1 of 4] clm: add to the information model and update config, scripts [#220]

2013-12-13 Thread Hans Feldt
On 12/04/2013 02:00 PM, mathi.naic...@oracle.com wrote: > opensaf.spec.in | 1 + > osaf/services/saf/clmsv/config/Makefile.am | 3 +- > osaf/services/saf/clmsv/config/clmna.conf| 14 ++ > osaf/services/saf/clmsv/conf