[devel] [PATCH 1 of 1] smfd: turn on PBE in state completed [677]

2013-12-18 Thread Ingvar Bergstrom
osaf/services/saf/smfsv/smfd/SmfCampState.cc | 14 +++--- osaf/services/saf/smfsv/smfd/SmfUpgradeCampaign.cc | 2 +- 2 files changed, 12 insertions(+), 4 deletions(-) To avoid the need of restore in case of cluster reboot, SMF turn on PBE in completed state. diff --git a/osaf/

[devel] [PATCH 0 of 1] Review Request for SMF #677

2013-12-18 Thread Ingvar Bergstrom
Summary: smfd: turn on PBE in state completed Review request for Trac Ticket(s): 677 Peer Reviewer(s): bertil Pull request to: Affected branch(es): default Development branch: default Impacted area Impact y/n Docs

[devel] [PATCH 1 of 1] cpsv: standardize arrival callback API(s) with SAF syntax [#561]

2013-12-18 Thread mahesh . valla
opensaf.spec.in |1 + osaf/libs/agents/saf/cpa/cpa_api.c | 547 ++- osaf/libs/agents/saf/cpa/cpa_proc.c |6 +- osaf/libs/common/cpsv/cpsv_edu.c | 22 +- osaf/libs/common/cpsv/include/cpa_cb.h |4 +- osaf/libs/

[devel] [PATCH 0 of 1] Review Request for cpsv: standardize arrival callback API(s) with SAF syntax [#561]

2013-12-18 Thread mahesh . valla
Summary: cpsv: standardize arrival callback API(s) with SAF syntax [#561] Review request for Trac Ticket(s): #561 Peer Reviewer(s): Hans/Mathi/Sirisha Pull request to: <> Affected branch(es): default Development branch: default Impacted area Impact y/n --

Re: [devel] [PATCH 1 of 1] smfd: Call configured smfBundleCheckCmd for all SW bundles expected to be found in IMM [#675]

2013-12-18 Thread Bertil Engelholm
Looks OK. One minor thing, remove "to add" from this TRACE entry: +TRACE("SW Bundle to add %s will be created by campaign", val.c_str()); /Bertil -Original Message- From: Ingvar Bergström Sent: den 19 december 2013 07:04 To: Bertil Engelho

[devel] [PATCH 1 of 1] smfd: Call configured smfBundleCheckCmd for all SW bundles expected to be found in IMM [#675]

2013-12-18 Thread Ingvar Bergstrom
osaf/services/saf/smfsv/smfd/SmfCampState.cc | 340 +++--- 1 files changed, 94 insertions(+), 246 deletions(-) The ticket "SMF: Call configured smfBundleCheckCmd as part of prerequisites test [656]" does not work as expected. Correct behavior is: 1) call configured smfBundl

[devel] [PATCH 0 of 1] Review Request for SMF #675

2013-12-18 Thread Ingvar Bergstrom
Summary: smfd: Call configured smfBundleCheckCmd for all SW bundles expected to be found in IMM Review request for Trac Ticket(s): 675 Peer Reviewer(s): bertil Pull request to: Affected branch(es): default Development branch: default Impacted area Impact y/

Re: [devel] [PATCH 1 of 1] java: Replace select() with osaf_poll() to avoid 1024 fd limit [#452]

2013-12-18 Thread Ramesh Betham
Ack. Reviewed only in context of replace `select` with `osaf_poll`. Minor comment: good to set fd.revent = 0; esp. when FDs = malloc(). Thanks, Ramesh. On 12/17/2013 9:09 PM, Anders Widell wrote: > java/ais_api_impl_native/Makefile.am |1 + > java/ais_api_impl_native/j_ais_amf

[devel] OpenSAF 4.4 Status and Feature Freeze

2013-12-18 Thread Anders Widell
Hi all! First of all I would like to thank everyone who has been working to get the new features ready on time for the OpenSAF 4.4 feature freeze. I am really impressed by the progress that has been made during the last few weeks, and now we are in a very good shape to keep the planned freeze

Re: [devel] [PATCH 0 of 2] Review Request for IMM: Add support for searching NO_DANGLING references on an object [#50]

2013-12-18 Thread Zoran Milinkovic
Hi Neelakanta, Anders had already created a ticket for NO_DANGLING tests (ticket #636). Maybe we could change the ticket to a defect ticket, and include test cases in OpenSAF 4.4 after holidays. Regards, Zoran -Original Message- From: Neelakanta Reddy [mailto:reddy.neelaka...@oracle.com

Re: [devel] [PATCH 1 of 1] IMM: Update README to document support for NO_DANGLING search [#50]

2013-12-18 Thread Anders Bjornerstedt
Ok will fix that in README before pushing. /AndersBj Neelakanta Reddy wrote: > Hi Anders, > Reviewed the patch. > Ack. > > README is not updated with the immadm changes, related to #642. > > /Neel. > On Tuesday 17 December 2013 11:16 PM, Anders Bjornerstedt wrote: >> osaf/services/saf/immsv/REA

Re: [devel] [PATCH 0 of 2] Review Request for IMM: Add support for searching NO_DANGLING references on an object [#50]

2013-12-18 Thread Anders Björnerstedt
Update of immomtest for NO_DANGLING is covered by ¤636 https://sourceforge.net/p/opensaf/tickets/636/ I think we will have to transform this into a defect ticket. Its just missing test cases so it could be construed as a defect. /AndersBj -Original Message- From: Neelakanta Red

Re: [devel] [PATCH 1 of 1] IMM: Update README to document support for NO_DANGLING search [#50]

2013-12-18 Thread Neelakanta Reddy
Hi Anders, Reviewed the patch. Ack. README is not updated with the immadm changes, related to #642. /Neel. On Tuesday 17 December 2013 11:16 PM, Anders Bjornerstedt wrote: > osaf/services/saf/immsv/README | 17 +- > osaf/services/saf/immsv/README.NO_DANGLING | 47 > +

Re: [devel] [PATCH 0 of 2] Review Request for IMM: Add support for searching NO_DANGLING references on an object [#50]

2013-12-18 Thread Neelakanta Reddy
Hi zoran, Reviewed and tested the patch. Ack. comment: Add the test case related to NO_DANGLING including the search option to the IMMSv test (may be at a later stage with a new defect). /Neel. On Tuesday 17 December 2013 10:06 PM, Zoran Milinkovic wrote: > Summary: IMM: Add support for searchi

Re: [devel] [PATCH 1 of 2] IMM: Add support for searching NO_DANGLING references on an object to API [#50]

2013-12-18 Thread Anders Bjornerstedt
Ack from me if the comment below is fixed. /AndersBj Anders Bjornerstedt wrote: > REview comments on API/library patch for NO_DANGLING. > > Zoran Milinkovic wrote: >> osaf/libs/agents/saf/imma/imma_om_api.c | 64 >> +++- >> osaf/libs/saf/include/saImmOm_A_2_13.h |

Re: [devel] [PATCH 2 of 2] IMM: Add support for searching NO_DANGLING references on an object to the service [#50]

2013-12-18 Thread Anders Bjornerstedt
Review comments on server side patch for NO_DANGLING search. I was pleasantly surprised that this enhancement resulted in relatively moderate addition of code. Good job Zoran. A few comments below. Zoran Milinkovic wrote: > osaf/services/saf/immsv/immnd/ImmModel.cc | 101 > +++

[devel] [PATCH 1 of 1] cpsv: avoid stale ckpt IMM objects creation if Ckpt Open returns err 18 [#559]

2013-12-18 Thread mahesh . valla
osaf/services/saf/cpsv/cpnd/cpnd_evt.c | 7 +++ osaf/services/saf/cpsv/cpnd/cpnd_proc.c | 3 ++- 2 files changed, 9 insertions(+), 1 deletions(-) diff --git a/osaf/services/saf/cpsv/cpnd/cpnd_evt.c b/osaf/services/saf/cpsv/cpnd/cpnd_evt.c --- a/osaf/services/saf/cpsv/cpnd/cpnd_evt.c +++

[devel] [PATCH 0 of 1] Review Request for cpsv: avoid stale ckpt IMM objects creation if Ckpt Open returns err 18 [#559]

2013-12-18 Thread mahesh . valla
Summary:cpsv: avoid stale ckpt IMM objects creation if Ckpt Open returns err 18 [#559] Review request for Trac Ticket(s): #559 Peer Reviewer(s): Ramesh Pull request to: Mahesh Affected branch(es): opensaf-4.2.x opensaf-4.3.x & defualt Development branch: defualt ---

Re: [devel] [PATCH 1 of 2] IMM: Add support for searching NO_DANGLING references on an object to API [#50]

2013-12-18 Thread Anders Bjornerstedt
REview comments on API/library patch for NO_DANGLING. Zoran Milinkovic wrote: > osaf/libs/agents/saf/imma/imma_om_api.c | 64 > +++- > osaf/libs/saf/include/saImmOm_A_2_13.h | 13 ++ > 2 files changed, 66 insertions(+), 11 deletions(-) > > > diff --git a/osaf/l