Re: [devel] [PATCH 1 of 1] amfnd: escalate comp errors in quiesced HA state [#601]

2014-01-16 Thread Hans Feldt
My patch is not touching the code path below, does that means this is a new bug? Is it reproducible? Do you have traces? Around line 1760 in comp_csi_remove_done csi is a variable local to the loop but it is also a function parameter. I believe this should be OK in C++ but maybe you have an olde

Re: [devel] [PATCH 1 of 1] amfd : clear node level admin op related flags during sufailover [#663]

2014-01-16 Thread Hans Feldt
Ack with minor inline: * commit message comments * code comments Thanks, Hans > -Original Message- > From: praveen.malv...@oracle.com [mailto:praveen.malv...@oracle.com] > Sent: den 17 januari 2014 06:47 > To: Hans Feldt; nagendr...@oracle.com; Hans Nordebäck > Cc: opensaf-devel@lists.sou

Re: [devel] [PATCH 1 of 1] amfnd: escalate comp errors in quiesced HA state [#601]

2014-01-16 Thread praveen malviya
While testing #601 getting crash. case: Node shutdown and FAILED_OPERATION in quiescing callback. Crash does not come without patch. (gdb) bt #0 0x0039ef679b60 in strlen () from /lib64/libc.so.6 #1 0x0039ef646cb9 in vfprintf () from /lib64/libc.so.6 #2 0x0039ef6e72e8 in __vsnp

[devel] [PATCH 1 of 1] amfd : clear node level admin op related flags during sufailover [#663]

2014-01-16 Thread praveen . malviya
osaf/services/saf/amf/amfd/sgproc.cc | 36 +++- 1 files changed, 35 insertions(+), 1 deletions(-) When admin operation like lock and shutdown are performed on Node and this leads to sufailover, AMFD is not clearing the operation related flag in node pointer. This

[devel] [PATCH 0 of 1] Review Request for amfd : clear node level admin opensaf.specrelated flags during sufailover [#663]

2014-01-16 Thread praveen . malviya
Summary: amfd : clear node level admin op related flags during sufailover [#663]. Review request for Trac Ticket(s): AMF #663 Peer Reviewer(s): Hanf F., Nagendra Pull request to: <> Affected branch(es):4.4 and default Development branch: <> Impacted area

[devel] [PATCH 0 of 1] Review Request for amf refactoring app, csi v4 [#713]

2014-01-16 Thread Hans Nordeback
Summary: AMF refactor app, csi version 4 Review request for Trac Ticket(s): #713 Peer Reviewer(s): HansF, Nagu, Praveen Pull request to: Affected branch(es): default Development branch: default Impacted area Impact y/n Docs

[devel] [PATCH 1 of 1] amfd: use stl::map in app, csi, version 4 [#713]

2014-01-16 Thread Hans Nordeback
osaf/services/saf/amf/amfd/app.cc| 30 +++--- osaf/services/saf/amf/amfd/ckpt_enc.cc | 2 +- osaf/services/saf/amf/amfd/ckpt_updt.cc | 2 +- osaf/services/saf/amf/amfd/csi.cc| 22 +++--- osaf/services/saf/amf/amfd/include/app.h | 14

[devel] [PATCH 1 of 1] amfd: use stl::map in csi [#713]

2014-01-16 Thread Hans Nordeback
osaf/services/saf/amf/amfd/ckpt_enc.cc | 2 +- osaf/services/saf/amf/amfd/csi.cc| 52 osaf/services/saf/amf/amfd/include/app.h | 7 +++- osaf/services/saf/amf/amfd/include/csi.h | 26 ++- osaf/services/saf/amf/amfd/util.cc | 4 +-

[devel] [PATCH 0 of 1] Review Request for refactoring csi [#713]

2014-01-16 Thread Hans Nordeback
Summary: amfd: use stl::map in csi [#713] Review request for Trac Ticket(s): #713 Peer Reviewer(s): HansF, Nagu, Praveen Pull request to: Affected branch(es): default Development branch: default Impacted area Impact y/n Docs

[devel] [PATCH 1 of 1] IMM: fix wrong error codes in README.NO_DANGLING [#726]

2014-01-16 Thread Zoran Milinkovic
osaf/services/saf/immsv/README.NO_DANGLING | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/osaf/services/saf/immsv/README.NO_DANGLING b/osaf/services/saf/immsv/README.NO_DANGLING --- a/osaf/services/saf/immsv/README.NO_DANGLING +++ b/osaf/services/saf/immsv/README.NO_DA

[devel] [PATCH 0 of 1] Review Request for IMM: fix wrong error codes in README.NO_DANGLING [#726]

2014-01-16 Thread Zoran Milinkovic
Summary: IMM: fix wrong error codes in README.NO_DANGLING [#726] Review request for Trac Ticket(s): 726 Peer Reviewer(s): Neelakanta, Anders Pull request to: Zoran Affected branch(es): opensaf-4.4.x, default(4.5) Development branch: Impacted area Impact y/n

[devel] [PATCH 0 of 1] Review Request for IMMTEST: add new test cases for NO_DANGLING flag [#636]

2014-01-16 Thread Zoran Milinkovic
Summary: IMMTEST: add new test cases for NO_DANGLING flag [#636] Review request for Trac Ticket(s): 636 Peer Reviewer(s): Neelakanta Pull request to: Zoran Affected branch(es): opensaf-4.4.x, default(4.5) Development branch: default(4.5) Impacted area Impact

Re: [devel] [PATCH 1 of 1] amfnd: escalate comp errors in quiesced HA state [#601]

2014-01-16 Thread praveen malviya
Hi, I am testing the patch and got one doubt. While removing the quiesced assignment, if component fault then also compoent failover is escalated. Do we require component-failover escalation at the the time of removal of assignments through quiesced state.? Or component-failover escalation is re

Re: [devel] checkpoint problems

2014-01-16 Thread A V Mahesh
Hi Alex, On 1/15/2014 2:31 AM, Alex Jones wrote: If you guys really believe that this problem should be fixed in MDS, I am happy to test more patches. Thanks for the offer , problem could be because of low socket receive buffer , please give try with attached patch `MDS_improvements_beta_ve

[devel] [PATCH 1 of 1] smfd: deletion of object possible if sub tree contain runtime children only [723]

2014-01-16 Thread Ingvar Bergstrom
osaf/services/saf/smfsv/smfd/SmfImmOperation.cc | 75 +++- osaf/services/saf/smfsv/smfd/SmfUpgradeProcedure.cc | 3 +- osaf/services/saf/smfsv/smfd/SmfUtils.cc| 25 +- osaf/services/saf/smfsv/smfd/SmfUtils.hh| 3 +- 4 files changed, 94 insertio

[devel] [PATCH 0 of 1] Review Request for SMF #723

2014-01-16 Thread Ingvar Bergstrom
Summary: smfd: deletion of object possible if sub tree contain runtime children only Review request for Trac Ticket(s): 723 Peer Reviewer(s): Pull request to: Affected branch(es): 4.3, 4.4, default Development branch: default Impacted area Impact y/n -