[devel] [PATCH 2 of 4] clm: initialize saflog() early during clm init [#720]

2014-02-03 Thread mathi . naickan
osaf/services/saf/clmsv/clms/clms_main.c | 6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) This is necessary to avoid blocking in saflog during role changes. diff --git a/osaf/services/saf/clmsv/clms/clms_main.c b/osaf/services/saf/clmsv/clms/clms_main.c ---

[devel] [PATCH 0 of 4] Review Request for osaf: add safloginit routine and call early during init of clm, ntf - v2.0

2014-02-03 Thread mathi . naickan
Summary: osaf: add new safloginit routine and call early during init of clm, ntf - v2.0 [#720] Review request for Trac Ticket(s): #720 Peer Reviewer(s): HansF, Praveen, Lennart Pull request to: LIST THE PERSON WITH PUSH ACCESS HERE Affected branch(es): all branches Development branch: IF ANY

[devel] [PATCH 4 of 4] clm and ntf: increase csisetcallback timeout to 40 seconds [#720]

2014-02-03 Thread mathi . naickan
osaf/services/saf/clmsv/config/clmsv_objects.xml | 4 ++-- osaf/services/saf/ntfsv/config/ntfsv_objects.xml | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/osaf/services/saf/clmsv/config/clmsv_objects.xml b/osaf/services/saf/clmsv/config/clmsv_objects.xml ---

[devel] [PATCH 1 of 4] osaf: add a new safloginit routine [#720]

2014-02-03 Thread mathi . naickan
osaf/tools/saflog/include/saflog.h | 6 + osaf/tools/saflog/src/saflog.c | 45 + 2 files changed, 41 insertions(+), 10 deletions(-) There can be situations during switchover/failover when clients of LOG can be blocked because LOG is busy doing file

[devel] [PATCH 3 of 4] ntf: initialize saflog() early during clm init [#720]

2014-02-03 Thread mathi . naickan
osaf/services/saf/ntfsv/ntfs/Makefile.am | 4 +++- osaf/services/saf/ntfsv/ntfs/ntfs_main.c | 6 ++ 2 files changed, 9 insertions(+), 1 deletions(-) This is necessary to avoid blocking in saflog during role changes. diff --git a/osaf/services/saf/ntfsv/ntfs/Makefile.am

Re: [devel] [PATCH 0 of 2] Review Request for amf #539

2014-02-03 Thread Hans Feldt
Any feedback? I would like to push asap. /Hans On 01/06/2014 09:54 PM, Hans Feldt wrote: Summary: allow changes to comptype and hctype Review request for Trac Ticket(s): 539 Peer Reviewer(s): Nags Pull request to: LIST THE PERSON WITH PUSH ACCESS HERE Affected branch(es): default

Re: [devel] [PATCH 0 of 2] Review Request for amf #662 v2

2014-02-03 Thread Hans Feldt
Any feedback? I would like to push asap. /Hans On 01/28/2014 02:41 PM, Hans Feldt wrote: Summary: AMF #662 v2 Review request for Trac Ticket(s): 662 Peer Reviewer(s): Nags Pull request to: LIST THE PERSON WITH PUSH ACCESS HERE Affected branch(es): 4.4 default Development branch: 4.4

[devel] [PATCH 1 of 1] amfd: create comp if not found during decoding [#761]

2014-02-03 Thread nagendra . k
osaf/services/saf/amf/amfd/ckpt_dec.cc| 5 + osaf/services/saf/amf/amfd/comp.cc| 21 + osaf/services/saf/amf/amfd/include/comp.h | 1 + 3 files changed, 23 insertions(+), 4 deletions(-) Some times, because of timing issues, apply callback is reaching

[devel] [PATCH 0 of 1] Review Request for amfd: create comp if not found during decoding [#761]

2014-02-03 Thread nagendra . k
Summary: amfd: create comp if not found during decoding [#761] Review request for Trac Ticket(s): #761 Peer Reviewer(s): Hans F, Hans N, Praveen Pull request to: Affected branch(es) All: Development branch: Default Impacted area Impact y/n

Re: [devel] [PATCH 1 of 1] amfd: create comp if not found during decoding [#761]

2014-02-03 Thread Anders Björnerstedt
Sorry but I have to ask what apply callback is being discussed here. Do you mean the apply callback from the immsv ? For OIs/Apppliers ? The immsv guarantees that the CCB is applied at the *processor* where the apply callback is received for that ccb-id. The immsv dous not guarantee that if

[devel] [PATCH 1 of 1] amfd: use bool instead of SaBoolT V2 [#713]

2014-02-03 Thread Hans Nordeback
osaf/services/saf/amf/amfd/apptype.cc| 6 +++--- osaf/services/saf/amf/amfd/clm.cc| 8 osaf/services/saf/amf/amfd/cluster.cc| 2 +- osaf/services/saf/amf/amfd/comp.cc | 6 +++--- osaf/services/saf/amf/amfd/comptype.cc | 6 +++---

[devel] [PATCH 1 of 1] osaf: fix compiling problem for 32-bit environment [#758]

2014-02-03 Thread Zoran Milinkovic
osaf/libs/saf/include/saImmOm_A_2_13.h| 2 +- osaf/libs/saf/include/saNtf.h | 2 +- tests/clmsv/src/tet_saClmClusterNodeGet.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/osaf/libs/saf/include/saImmOm_A_2_13.h b/osaf/libs/saf/include/saImmOm_A_2_13.h

[devel] [PATCH 0 of 1] Review Request for osaf: fix compiling problem for 32-bit environment [#758]

2014-02-03 Thread Zoran Milinkovic
Summary: osaf: fix compiling problem for 32-bit environment [#758] Review request for Trac Ticket(s): 758 Peer Reviewer(s): Sirisha Pull request to: Zoran Affected branch(es): opensaf-4.4.x, default(4.5) Development branch: opensaf-4.4.x Impacted area Impact

Re: [devel] [PATCH 1 of 1] * remove saAmfStgValidSuTypes from 'struct avd_amf_sg_type_tag' as it appears to

2014-02-03 Thread Hans Feldt
Ack with minor comments: * commit message too long, amfd: fix valgrind reported errors [#715] is enough for me * check pointer with NULL, see inline Thanks, Hans On 01/13/2014 11:53 AM, Gary Lee wrote: osaf/services/saf/amf/amfd/csi.cc | 25 -

Re: [devel] [PATCH 1 of 1] amfnd: fix errors reported by valgrind [#716]

2014-02-03 Thread Hans Feldt
Ack with minor comments: * check with NULL * check for greater than 0 (Design rules for amf should be created...) See inline Thanks, Hans On 01/28/2014 07:32 AM, Gary Lee wrote: osaf/services/saf/amf/amfnd/amfnd.cc|4 +- osaf/services/saf/amf/amfnd/cbq.cc |

Re: [devel] [PATCH 1 of 1] amfd: fix out-of-bounds read from nodelist array [#719]

2014-02-03 Thread Hans Feldt
Ack /Hans On 01/24/2014 07:26 AM, Gary Lee wrote: osaf/services/saf/amf/amfd/include/node.h | 1 + osaf/services/saf/amf/amfd/nodegroup.cc | 35 ++- osaf/services/saf/amf/amfd/sg.cc | 19 +--- 3 files changed, 36 insertions(+), 19

Re: [devel] [PATCH 1 of 1] amfnd: fix errors reported by valgrind [#716]

2014-02-03 Thread Nagendra Kumar
Ack, not tested. -Nagu -Original Message- From: Gary Lee [mailto:gary@dektech.com.au] Sent: 28 January 2014 12:02 To: hans.nordeb...@ericsson.com; nku...@oracle.com; gary@dektech.com.au Cc: opensaf-devel@lists.sourceforge.net Subject: [devel] [PATCH 1 of 1] amfnd: fix

Re: [devel] [PATCH 1 of 2] amfd: require saAmfCtSwBundle when relpath in CLC-CLI cmds [#662]

2014-02-03 Thread Nagendra Kumar
The below line has been typed twice. One should be AmStop. + attr_name = saAmfCtRelPathAmStartCmd; Thanks -Nagu -Original Message- From: Hans Feldt [mailto:osafde...@gmail.com] Sent: 28 January 2014 19:11 To: Nagendra Kumar Cc: opensaf-devel@lists.sourceforge.net Subject:

Re: [devel] [PATCH 0 of 1] Review Request for uml: Update UML environment to Linux 3.13.1, busybox 1.21.1 [#762]

2014-02-03 Thread Lennart Lund
Tested Ok, Ack /Lennart -Original Message- From: Anders Widell Sent: den 31 januari 2014 14:10 To: Lennart Lund Cc: opensaf-devel@lists.sourceforge.net Subject: [PATCH 0 of 1] Review Request for uml: Update UML environment to Linux 3.13.1, busybox 1.21.1 [#762] Summary: uml:

Re: [devel] [PATCH 1 of 1] logsv: Fix updating of log root directory when check-pointing lgs config [#711]

2014-02-03 Thread Mathivanan Naickan Palanivelu
Ack (for this flow). I have not done the same test for shared file system, i.e. simulate a mkdir failure! Thanks, Mathi. -Original Message- From: Lennart Lund [mailto:lennart.l...@ericsson.com] Sent: Monday, January 27, 2014 9:34 PM To: Mathivanan Naickan Palanivelu Cc:

Re: [devel] [PATCH 1 of 1] amfd: create comp if not found during decoding [#761]

2014-02-03 Thread Hans Feldt
Please send a new patch with a corrected commit message, for defects it should contain 3 paragraphs: symptom, analysis and change description. See inline for comments. during decoding = during checkpointing? Thanks, Hans -Original Message- From: nagendr...@oracle.com

Re: [devel] [PATCH 1 of 1] amfd: create comp if not found during decoding [#761]

2014-02-03 Thread Nagendra Kumar
for defects it should contain 3 paragraphs: symptom, analysis and change description Do we have this informed to developers or written some where ? Thanks -Nagu -Original Message- From: Hans Feldt [mailto:hans.fe...@ericsson.com] Sent: 04 February 2014 01:58 To: Nagendra Kumar;

Re: [devel] [PATCH 1 of 1] IMM: README clarified ccb-op return codes for NO_DANGLING errors (#754)

2014-02-03 Thread Sirisha Alla
Anders, I still have concerns about the documentation for error codes for CCB Object Delete. The scenarios mentioned do not correspond to CCB Object Delete but duplicate of the scenarios mentioned in CCB Object Create. The only possibility of CCB Object Delete returning error is If an object

Re: [devel] [PATCH 1 of 2] amfd: require saAmfCtSwBundle when relpath in CLC-CLI cmds [#662]

2014-02-03 Thread Nagendra Kumar
Ack with comment: The below line has been typed twice. One should be AmStop. + attr_name = saAmfCtRelPathAmStartCmd; Thanks -Nagu -Original Message- From: Hans Feldt [mailto:osafde...@gmail.com] Sent: 28 January 2014 19:11 To: Nagendra Kumar Cc:

Re: [devel] [PATCH 2 of 2] amfnd: ignore saAmfCtSwBundle when abspath in CLC-CLI cmds [#662]

2014-02-03 Thread Hans Feldt
On 02/04/2014 08:23 AM, Nagendra Kumar wrote: Ack with comments. 1. Please change name of init_clc_cli_commands to init_clc_cli_commands_and_timeouts. Gets a bit long, how about init_clc_cli_attributes? 2. If I am configuring saAmfCtRelPathInstantiateCmd with relative patch