osaf/services/saf/amf/amfd/comp.cc| 4 +++-
osaf/services/saf/amf/amfnd/compdb.cc | 34 ++
2 files changed, 21 insertions(+), 17 deletions(-)
diff --git a/osaf/services/saf/amf/amfd/comp.cc
b/osaf/services/saf/amf/amfd/comp.cc
---
Summary: amf: add check for middleware component for automatic comp
instantiation and deletion [#597]
Review request for Trac Ticket(s): #597
Peer Reviewer(s): Hans F, Mathi, Hans N, Praveen
Pull request to: LIST THE PERSON WITH PUSH ACCESS HERE
Affected branch(es): 4.4 and default
Development
Ack with a minor comment.
W.r.t the following update
If the AMFND process on that CLM node exits (crashes) in a scenario
when OpenSAF does not controls the TIPC connectivity, i.e. when
OPENSAF_TIPC_MANAGE=NO flag is set in the /etc/opensaf/nid.conf.
I hope this is an impact of the changes
Summary: amf: Coverity issues in amfd/amfnd [#680]
Review request for Trac Ticket(s): 680
Peer Reviewer(s): Hans N, Hans F, Nagendra
Pull request to:
Affected branch(es): default
Development branch: default
Impacted area Impact y/n
This patch and AMFND patch for the SaBoolT changes seems ok to me.
But a there are lot of changes and discussion under the same ticket and
I am seeing a lot of patches.
So for patches 3 of 4 and 4 of 4 which are all to be reviewed or shall
I review these two patches floated on 14th Jan.
Considering #739 can you explain why you changed the while loop into a for loop?
After the call to avnd_comp_csi_remove_done() the memory that the csi
variable points to might have been freed thus can't be trusted for the
next iteration of the loop.
Otherwise the patch looks OK but I haven't
