Ack. Looks good. No more comments.
Thanks
Lennart
-Original Message-
From: Mathivanan Naickan Palanivelu [mailto:mathi.naic...@oracle.com]
Sent: den 21 februari 2014 11:33
To: Lennart Lund; opensaf-devel@lists.sourceforge.net
Subject: Re: [devel] Review of LOGSv PR update (for
Ack with comments.
1) It is probably a good idea to validate that role is within bounds
before accessing the array with strings role_string[role]. It could be
done e.g. in the following way:
LOG_NO(RDE role set to %s, role = 0 role sizeof(role_string) /
sizeof(role_string[0]) ?
Ack with comment. Please use NUM_FD instead of writing e.g. the number 5
directly in the code:
+static struct pollfd fds[5];
+static nfds_t nfds = 5;
replace with:
+static struct pollfd fds[NUM_FD];
+static nfds_t nfds = NUM_FD;
and:
+ while (osaf_poll(sel[0], 3, -1) 0) {
replace
These are legacy values.
PCS_RDA_UNDEFINED = 0,
PCS_RDA_ACTIVE,
PCS_RDA_STANDBY,
PCS_RDA_QUIESCED,
PCS_RDA_ASSERTING,
PCS_RDA_YIELDING
These values have to be removed/changed. That has to be done in a separate
ticket,
including changing/removing the
Summary: IMM: Use existing PBE mutation record to guard against concurrent
class create/delete [#757]
Review request for Trac Ticket(s): 757
Peer Reviewer(s): Neel
Pull request to:
Affected branch(es): 4.2(?); 4.3; 4.4: default(4.5)
Development branch:
Impacted
osaf/services/saf/immsv/immnd/ImmModel.cc | 100 ++---
1 files changed, 48 insertions(+), 52 deletions(-)
The existing mutation record for PBE operations includes records for
class-create and class-delete.
These are now used to detect any pre-existing and on-going PBE
Summary: IMM: add support for forwards compatibility of attribute flags [#116]
Review request for Trac Ticket(s): 116
Peer Reviewer(s): Neelakanta
Pull request to: Zoran
Affected branch(es): opensaf-4.2.x
Development branch: opensaf-4.2.x
Impacted area
osaf/tools/safimm/immcfg/imm_cfg.c | 31 -
osaf/tools/safimm/immcfg/imm_import.cc | 178 ++-
osaf/tools/safimm/immlist/imm_list.c|6 -
osaf/tools/safimm/immload/imm_loader.cc | 150 +-
4 files changed, 333 insertions(+), 32
osaf/libs/common/immsv/immpbe_dump.cc |2 +-
osaf/services/saf/immsv/immloadd/imm_loader.cc | 140 -
osaf/services/saf/immsv/immnd/ImmModel.cc | 36 +++--
osaf/services/saf/immsv/immnd/ImmSearchOp.cc |2 +-
Summary: IMM: add support for forwards compatibility of attribute flags [#116]
Review request for Trac Ticket(s): 116
Peer Reviewer(s): Neelakanta
Pull request to: Zoran
Affected branch(es): opensaf-4.3.x
Development branch: opensaf-4.3.x
Impacted area
osaf/tools/safimm/immcfg/imm_cfg.c | 31 -
osaf/tools/safimm/immcfg/imm_import.cc | 172 -
2 files changed, 193 insertions(+), 10 deletions(-)
For forwards compatibility, OpenSAF schema, where unknown attribute flags are
defined, must be provided to
Summary: IMM: add support for forwards compatibility of attribute flags [#116]
Review request for Trac Ticket(s): 116
Peer Reviewer(s): Neelakanta
Pull request to: Zoran
Affected branch(es): opensaf-4.4.x, default(4.5)
Development branch: default(4.5)
Impacted
Hello,
The 4.4RC2 release candidate is now available for download and testing.
It is also time for another maintenance release in the 4.2.x and 4.3.x release
streams, given that significant number of tickets have been fixed.
The maintenance release candidates 4.2.5RC1 and 4.3.2RC1 are also now
Hi,
With ticket #116 as an exception, please consider fixing only critical (and
important majors with the approval of TLC) tickets.
The tentative plan for 4.4 GA and 4.2.5, 4.3.2 is February 28th 2014.
Thanks,
Mathi.
-Original Message-
From: Mathivanan Naickan Palanivelu
Sent:
14 matches
Mail list logo
