Re: [devel] [PATCH 1 of 1] amfd: Ensure HA state notification is sent when a SI is first assigned to a SU [#544]

2014-03-25 Thread Hans Feldt
Hi, Nack because we get redundant system stream entries with this change. I think the log in the same function that you changed should be removed. Logging will be done from avd_gen_su_ha_state_changed_ntf The commit message is a bit long, why not just amfd: send notification when SI first

Re: [devel] [PATCH 1 of 1] amfd: Ensure HA state notification is sent when a SI is first assigned to a SU [#544]

2014-03-25 Thread Gary Lee
Hi Hans Thanks, I missed the redundant log entry. I thought the same with regards to the commit message, after sending the review request :) Please change and push for me. Thanks Gary On 25/03/14 17:05, Hans Feldt wrote: Hi, Nack because we get redundant system stream entries with this

[devel] [PATCH 1 of 1] IMMTOOLS: fix printing and dumping for float and double values [#53]

2014-03-25 Thread Zoran Milinkovic
osaf/libs/common/immsv/immpbe_dump.cc | 2 ++ osaf/tools/safimm/immlist/imm_list.c | 8 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/osaf/libs/common/immsv/immpbe_dump.cc b/osaf/libs/common/immsv/immpbe_dump.cc --- a/osaf/libs/common/immsv/immpbe_dump.cc +++

[devel] [PATCH 0 of 1] Review Request for amfnd: fix failover of NPI SU during SU lock with fault [#820]

2014-03-25 Thread praveen . malviya
Summary: amfnd: fix failover of NPI SU during SU lock with fault [#820] Review request for Trac Ticket(s): AMF #820 Peer Reviewer(s): Hans F., Nagendra Pull request to: LIST THE PERSON WITH PUSH ACCESS HERE Affected branch(es): All Development branch: IF ANY GIVE THE REPO URL

[devel] [PATCH 1 of 1] amfnd: fix failover of NPI SU during SU lock with fault [#820]

2014-03-25 Thread praveen . malviya
osaf/services/saf/amf/amfnd/comp.cc | 2 +- osaf/services/saf/amf/amfnd/include/avnd_su.h | 1 + osaf/services/saf/amf/amfnd/susm.cc | 34 -- 3 files changed, 33 insertions(+), 4 deletions(-) Problem: During lock of NPI SU, AMF does not failover