Any update/comment on this.
Thanks,
Praveen
On 01-Apr-14 2:27 PM, praveen malviya wrote:
On 01-Apr-14 1:27 PM, Hans Feldt wrote:
On 03/28/2014 02:14 PM, praveen.malv...@oracle.com wrote:
osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 23 +--
1 files changed, 13
Well my view point still stands. By separating the su_switch from invocation_id
we introduce even more sub-states and we
already have enough of those! Basically the same patch as you have with a small
addition causes the admin response to be
sent after recovery of the failed SU. Will send a
If the recovery of failed Su doesn't happen i.e. goes into instantiatin failed
state/termination failed state, then are you going to rerun failed operation ?
Thanks
-Nagu
-Original Message-
From: Hans Feldt [mailto:hans.fe...@ericsson.com]
Sent: 02 April 2014 12:14
To: praveen
Then I guess the admin op will just timeout which is about the same as BAD-OP
from the user perspective
/Hans
-Original Message-
From: Nagendra Kumar [mailto:nagendr...@oracle.com]
Sent: den 2 april 2014 09:01
To: Hans Feldt; Praveen Malviya
Cc: opensaf-devel@lists.sourceforge.net
The direct inclusion prevention is a good idea and should be added to these
files.
I think the current include file extension for the imm should be kept for now.
This mainly to avoid rocking the boat in this area unnecessarily.
Our users have a hard enough time as it is to grasp the distinction
Please check and comment the attached patch.
Thanks,
Hans
-Original Message-
From: Nagendra Kumar [mailto:nagendr...@oracle.com]
Sent: den 2 april 2014 09:01
To: Hans Feldt; Praveen Malviya
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [devel] [PATCH 1 of 1] amfd: return
Some comments:
1) In the patch with the change:
su_ha_state = avd_su_state_determine(su);
- if (su_ha_state == SA_AMF_HA_QUIESCED) {
- if (su-su_switch == AVSV_SI_TOGGLE_SWITCH) {
- AVD_SU_SI_REL *temp_susi;
-
I would also agree with these comments with one additional comment:
The below check is not required in complete_siswap():
+
+ if (su-su_switch == AVSV_SI_TOGGLE_STABLE)
+ goto done;
+
As we are not sure the removed code used to set to stable from unstable/stable,
because
The removed code in err.c
- /*
-* su-sis may be in assigning/removing state. signal csi
-* assign/remove done so that su-si assignment/removal algo can proceed.
-*/
- avnd_comp_cmplete_all_assignment(cb, failed_comp);
-
and
/* delete curr info of the failed
ack, code review only. /Rgds. HansN
-Original Message-
From: Hans Feldt [mailto:osafde...@gmail.com]
Sent: den 2 april 2014 07:03
To: Hans Nordebäck
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 3] amfd: remove cast from avd_class_impl_set [#713]
ack, code review only/Rgds. HansN
On 04/02/14 07:02, Hans Feldt wrote:
osaf/services/saf/amf/amfd/comp.cc | 23
osaf/services/saf/amf/amfd/imm.cc| 44
+++
osaf/services/saf/amf/amfd/include/imm.h | 2 +-
osaf/services/saf/avsv/avd/avd_node.c | 9 +
osaf/services/saf/avsv/avd/avd_su.c | 8
2 files changed, 17 insertions(+), 0 deletions(-)
Problem: When su is either in instantiating/Terminating/restarting state and
if either su/node lock-in operation is performed, then
it
osaf/tools/safimm/immcfg/imm_cfg.c | 69 +++--
1 files changed, 36 insertions(+), 33 deletions(-)
diff --git a/osaf/tools/safimm/immcfg/imm_cfg.c
b/osaf/tools/safimm/immcfg/imm_cfg.c
--- a/osaf/tools/safimm/immcfg/imm_cfg.c
+++
Summary: IMM: add error strings for CCB operations for ERR_NOT_EXIST error
[#459]
Review request for Trac Ticket(s): 459
Peer Reviewer(s): Anders, Neelakanta
Pull request to: Zoran
Affected branch(es): default(4.5)
Development branch: default(4.5)
Impacted area
osaf/services/saf/immsv/immnd/ImmModel.cc | 60 +++
osaf/services/saf/immsv/immnd/ImmModel.hh | 5 ++
osaf/services/saf/immsv/immnd/immnd_evt.c | 27 -
3 files changed, 89 insertions(+), 3 deletions(-)
When an implementer is detached from an
We had a discussion regarding this in TLC and the conclusion was that we
go for the originally proposed file name saAis_B_5_14.h for now so that
it is consistent with the names other existing header files, and then at
a later point we can revisit this issue and rename/consolidate the file
16 matches
Mail list logo
