Re: [devel] [PATCH 0 of 1] Review Request for IMMTOOLS: revert old way of parsing default values and add a flag for more strict parsing values in immcfg [#861]

Thanks for the comment. I'll add it to the help before I push the code. Thanks, Zoran -Original Message- From: Reddy Neelakanta Reddy Peddavandla [mailto:reddy.neelaka...@oracle.com] Sent: den 24 april 2014 16:07 To: Zoran Milinkovic Cc: opensaf-devel@lists.sourceforge.net Subject: Re:

Re: [devel] [PATCH 0 of 1] Review Request for Imm:Make immcfg aware of safImmService admin owner for opensafImm=opensafImm, safApp=safImmService [#840]

Hi Neelakanta, I have few comments to the patch: 1. Why did you disable enabling and disabling notifications in explicit commit mode ? 2. strcpy() in line 788 is not safe. adminOwnerName may have less allocated bytes than safImmService. For example: if an application change immcfg name into

Re: [devel] [PATCH 2 of 2] clm: add ETF file for CLMD [#848]

Nice start. Like Bertil commented, yes CLMNA should also be part of the same ETF for the CLM 'software'! And, What about the below, will they be part of some OpenSAF common ETF? +xs:element name=SUType++ +xs:element name=SGType-+--- +xs:element

Re: [devel] [PATCH 1 of 2] osaf: add make system support for etf xmls [#848]

I think rules should also be added to the rpm spec file. Thanks, Mathi. -Original Message- From: Hans Feldt [mailto:hans.fe...@ericsson.com] Sent: Thursday, April 24, 2014 7:10 PM To: bertil.engelh...@ericsson.com; Mathivanan Naickan Palanivelu Cc: opensaf-devel@lists.sourceforge.net

[devel] [PATCH 1 of 1] amfd: Allow multiple csi addition in single ccb [#750]

osaf/services/saf/avsv/avd/avd_csi.c | 46 --- osaf/services/saf/avsv/avd/avd_sgproc.c | 17 ++ osaf/services/saf/avsv/avd/include/avd_csi.h | 1 + 3 files changed, 51 insertions(+), 13 deletions(-) Problem: Amf rejects csi addition if previous

[devel] [PATCH 0 of 1] Review Request for amfd: Allow multiple csi addition in single ccb [#750]

Summary: amfd: Allow multiple csi addition in single ccb [#750] Review request for Trac Ticket(s): #750 Peer Reviewer(s): Hans F, Hans N, Praveen Pull request to: Affected branch(es): All Development branch: opensaf-4.3.x Impacted area Impact y/n

Re: [devel] [PATCH 0 of 1] Review Request for amfd: Allow multiple csi addition in single ccb [#750]

Sorry, forgot to mention in subject. This is for V2 review. Thanks -Nagu -Original Message- From: Nagendra Kumar Sent: 25 April 2014 16:43 To: hans.fe...@ericsson.com; hans.nordeb...@ericsson.com; Praveen Malviya Cc: opensaf-devel@lists.sourceforge.net Subject: [devel] [PATCH 0 of

Re: [devel] [PATCH 0 of 1] Review Request for amfd: Allow multiple csi addition in single ccb [#750]

1. This patch brings complexity of handling multiple csi in one go and has its own repercussions. 2. There may be problem in handling multiple csi addition failures at the same time. 3. Error test cases has not been tested and would wait for test results from reviewers.. Thanks

Re: [devel] [PATCH 1 of 1] log: allow zero sized log records for app streams [#857]

Ack. Have checked and tested and cannot see any problems Thanks Lennart -Original Message- From: mathi.naic...@oracle.com [mailto:mathi.naic...@oracle.com] Sent: den 18 april 2014 21:53 To: Lennart Lund Cc: opensaf-devel@lists.sourceforge.net Subject: [PATCH 1 of 1] log: allow zero

Re: [devel] [PATCH 0 of 1] Review Request for Imm:Make immcfg aware of safImmService admin owner for opensafImm=opensafImm, safApp=safImmService [#840]

Hi zoran, comments inline. /Neel. - Original Message - From: zoran.milinko...@ericsson.com To: reddy.neelaka...@oracle.com, anders.bjornerst...@ericsson.com Cc: opensaf-devel@lists.sourceforge.net Sent: Friday, April 25, 2014 3:08:07 PM GMT +05:30 Chennai, Kolkata, Mumbai, New Delhi

Re: [devel] [PATCH 0 of 1] Review Request for Imm:Make immcfg aware of safImmService admin owner for opensafImm=opensafImm, safApp=safImmService [#840]

Hi zoran, Ok, will publish a new patch, which is backward compatible. /Neel. - Original Message - From: zoran.milinko...@ericsson.com To: reddy.neelaka...@oracle.com Cc: anders.bjornerst...@ericsson.com, opensaf-devel@lists.sourceforge.net Sent: Friday, April 25, 2014 6:16:33 PM GMT