[devel] [PATCH 0 of 1] Review Request for amfd: use correct SU when calling set_su_failover [#713]

Summary: amfd: use correct SU when calling set_su_failover [#713] Review request for Trac Ticket(s): 713 Peer Reviewer(s): Hans F Pull request to: Affected branch(es): default Development branch: default Impacted area Impact y/n

[devel] [PATCH 1 of 1] amfd: use correct SU when calling set_su_failover [#713]

osaf/services/saf/amf/amfd/su.cc | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) A typo was introduced when some SU logic was moved from comp.cc to su.cc. This may have caused a segfault when set_su_failover() is called on a null pointer. set_su_failover() should be called on this SU

Re: [devel] [PATCH 1 of 1] amfd: use correct SU when calling set_su_failover [#713]

Ack /Hans -Original Message- From: Gary Lee [mailto:gary@dektech.com.au] Sent: den 22 maj 2014 09:20 To: Hans Feldt Cc: opensaf-devel@lists.sourceforge.net Subject: [PATCH 1 of 1] amfd: use correct SU when calling set_su_failover [#713] osaf/services/saf/amf/amfd/su.cc |

[devel] [PATCH 1 of 1] amfd: initialize current assignment attributes in SU constructor [713]

osaf/services/saf/amf/amfd/su.cc | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) SIs are not assigned to SU when SU was unlocked. AMFD checks su-saAmfSUNumCurrActiveSIs and assigns SIs if its value is less than saAmfSGMaxActiveSIsperSU then only SIs are assigned to the SU. Since

[devel] [PATCH 0 of 1] Review Request for base #910

Summary: FILL ME Review request for Trac Ticket(s): IF ANY LIST THE # Peer Reviewer(s): Ramesh Pull request to: LIST THE PERSON WITH PUSH ACCESS HERE Affected branch(es): LIST ALL AFFECTED BRANCH(ES) Development branch: IF ANY GIVE THE REPO URL Impacted area

[devel] [PATCH 0 of 1] Review Request for AMF: Use IMM applier in the AMF node director V2 [#819]

Summary: AMF: Use IMM applier in the AMF node director V2 [#819] Review request for Trac Ticket(s): #819 Peer Reviewer(s): HansF, Nagu, Praveen Pull request to: Affected branch(es): default Development branch: default Impacted area Impact y/n

[devel] [PATCH 1 of 1] AMF: Use IMM applier in the AMF node director V2 [#819]

osaf/libs/common/amf/include/amf_defs.h |6 + osaf/services/saf/amf/amfnd/Makefile.am |1 + osaf/services/saf/amf/amfnd/evt.cc |7 + osaf/services/saf/amf/amfnd/hcdb.cc | 159 osaf/services/saf/amf/amfnd/imm.cc | 765

Re: [devel] [PATCH 1 of 1] amfd: initialize current assignment attributes in SU constructor [713]

ack, /Regards Hans On 05/22/14 10:31, praveen.malv...@oracle.com wrote: osaf/services/saf/amf/amfd/su.cc | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) SIs are not assigned to SU when SU was unlocked. AMFD checks su-saAmfSUNumCurrActiveSIs and assigns SIs if its value is less

Re: [devel] [PATCH 1 of 1] amfd: replace patricia tree with stl::maps in nodegroup [#713]

I agree with HansF, we should use the provided iterator. /Regards HansN On 05/21/14 14:38, Hans Feldt wrote: getnext is not needed. Maps have a built in iterator that can/should be used directly At least that is the pattern followed so far. /HansF -Original Message- From:

[devel] [PATCH 0 of 1] Review Request for log: Fix calculation of timeout time on 32 bit systems [#918]

Summary: log: Fix calculation of timeout time on 32 bit systems Review request for Trac Ticket(s): #918 Peer Reviewer(s): mathi.naic...@oracle.com, anders.wid...@ericsson.com Pull request to: LIST THE PERSON WITH PUSH ACCESS HERE Affected branch(es): 4.4, default Development branch: IF ANY GIVE

[devel] [PATCH 1 of 1] log: handle ending quote for messages in variable log records [#882]

osaf/services/saf/logsv/lgs/lgs_evt.c | 2 +- osaf/services/saf/logsv/lgs/lgs_fmt.c | 26 +++--- osaf/services/saf/logsv/lgs/lgs_fmt.h | 2 +- osaf/services/saf/logsv/lgs/lgs_mbcsv.c | 2 +- 4 files changed, 26 insertions(+), 6 deletions(-) Currently, When

[devel] [PATCH 0 of 1] Review Request for imm: Add upgrade support for admin-op directly targeting implementer [#799]

Summary: imm: Add upgrade support for admin-op directly targeting implementer [#799] Review request for Trac Ticket(s): 799 Peer Reviewer(s): Neel Pull request to: Affected branch(es): default(4.5) Development branch: Impacted area Impact y/n

[devel] [PATCH 1 of 1] imm: Add upgrade support for admin-op directly targeting implementer [#799]

osaf/services/saf/immsv/immnd/ImmModel.cc | 15 ++- 1 files changed, 10 insertions(+), 5 deletions(-) Only allow admin-operation directly targeting implementer if protocol4.5 is allowed. This is an addition to enhancement [#799] not any defect fix. diff --git