Summary: IMM: Add config attribute 'opensafLongDnsAllowed' to class
'OpensafImm' [#897]
Review request for Trac Ticket(s): 897
Peer Reviewer(s): Neel; Zoran
Pull request to:
Affected branch(es): default(4.5)
Development branch:
Impacted area Impact y/n
osaf/libs/common/immsv/include/immsv_api.h | 2 +
osaf/services/saf/immsv/immloadd/imm_loader.cc | 10 +++-
osaf/services/saf/immsv/immnd/ImmModel.cc | 24 +
osaf/services/saf/immsv/immnd/ImmModel.hh | 1 +
samples/immsv/OpensafImm.xml | 64
Why the attribute name prefix opensaf?
It should not be needed and adds no value.
Thanks,
Hans
-Original Message-
From: Anders Bjornerstedt [mailto:anders.bjornerst...@ericsson.com]
Sent: den 9 juni 2014 08:18
To: reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
ack, code review only/Regards HansN
On 06/03/14 07:24, Hans Feldt wrote:
osaf/services/saf/amf/amfd/include/su.h | 2 ++
osaf/services/saf/amf/amfd/sgproc.cc| 26 +++---
osaf/services/saf/amf/amfd/su.cc| 19 +++
3 files changed, 24
I agree but the unfortunate thing is pattern of already existing attributes in
this class:
opensafImm
opensafImmSyncBatchSize
opensafImmNostdFlags
opensafImmEpoch
/AndersBj
-Original Message-
From: Hans Feldt
Sent: den 9 juni 2014 09:23
To: Anders
-Original Message-
From: Hans Nordebäck [mailto:hans.nordeb...@ericsson.com]
Sent: den 5 juni 2014 14:13
To: Hans Feldt
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [devel] [PATCH 1 of 4] amfd: remove mds copy support [#713]
ack, minor comment, lots of whitespace
ack, code review only/Regards HansN
On 06/03/14 07:24, Hans Feldt wrote:
osaf/services/saf/amf/amfd/include/su.h |9 +
osaf/services/saf/amf/amfd/su.cc| 461
+--
2 files changed, 257 insertions(+), 213 deletions(-)
complexity of su.cc dropped
no, I think the patch is ok as it is/BR HansN
-Original Message-
From: Hans Feldt
Sent: den 9 juni 2014 09:28
To: Hans Nordebäck; Hans Feldt
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [devel] [PATCH 1 of 4] amfd: remove mds copy support [#713]
-Original Message-
osaf/services/saf/amf/amfd/ckpt_dec.cc | 50 +
1 files changed, 14 insertions(+), 36 deletions(-)
diff --git a/osaf/services/saf/amf/amfd/ckpt_dec.cc
b/osaf/services/saf/amf/amfd/ckpt_dec.cc
--- a/osaf/services/saf/amf/amfd/ckpt_dec.cc
+++
osaf/services/saf/amf/amfd/ckpt_dec.cc| 17 +++-
osaf/services/saf/amf/amfd/ckpt_edu.cc| 51 +--
osaf/services/saf/amf/amfd/ckpt_enc.cc| 45 ---
osaf/services/saf/amf/amfd/include/ckpt_edu.h | 3 -
4 files changed, 23
Summary: Term failed improvements
Review request for Trac Ticket(s): 538
Peer Reviewer(s): AMF devels
Pull request to: LIST THE PERSON WITH PUSH ACCESS HERE
Affected branch(es): all
Development branch: 4.4
Impacted area Impact y/n
osaf/services/saf/amf/amfnd/clc.cc | 3 +-
osaf/services/saf/amf/amfnd/su.cc | 1 -
osaf/services/saf/amf/amfnd/susm.cc | 56 +++-
3 files changed, 13 insertions(+), 47 deletions(-)
Possible split brain on application level and spec violation.
The AMF
I got the below in README of imm:
But with the addition of multiple appliers, there is a risk is that
this is interpreted as an open-ended set of appliers, consuming an open
ended ammount of resources. This would be incorrect design.
Can this a bothering factor?
Thanks
-Nagu
-Original
00-README.conf | 18 ++
osaf/libs/saf/include/saAis.h| 4
osaf/libs/saf/include/saAis_B_5_14.h | 17 +
3 files changed, 39 insertions(+), 0 deletions(-)
Add declarations of saAisNameLend() and saAisNameBorrow() to
Summary: Extended Name Type [#191]
Review request for Trac Ticket(s): 191
Peer Reviewer(s): Mathi
Pull request to:
Affected branch(es): default(4.5)
Development branch: default
Impacted area Impact y/n
Docs
configure.ac |1 +
osaf/libs/common/Makefile.am |2 +-
osaf/libs/common/ais/Makefile.am | 27 ++
osaf/libs/common/ais/aisa_api.c | 140 ++
osaf/libs/saf/libSaAmf/Makefile.am|1 +
osaf/libs/core/common/Makefile.am |1 +
osaf/libs/core/common/include/Makefile.am |1 +
osaf/libs/core/common/include/osaf_extended_name.h | 232 +
osaf/libs/core/common/osaf_extended_name.c | 184
Not able to compile AMFND after applying this patch series on GCC 4.9:
|| echo './'`util.cc; \
then mv -f .deps/osafamfnd-util.Tpo
.deps/osafamfnd-util.Po; else rm -f .deps/osafamfnd-util.Tpo; exit
1; fi
util.cc: In function âuint32_t avnd_msg_copy(AVND_CB*, AVND_MSG*,
AVND_MSG*)â:
I have to NACK this patch due to some issues commented below.
Mainly performance related.
Zoran Milinkovic wrote:
osaf/libs/common/immsv/immsv_evt.c | 56 +-
osaf/libs/common/immsv/include/immsv_evt.h | 4 +
osaf/libs/common/immsv/include/immsv_evt_model.h |
Summary: build: Modernize autotools configuration [#901]
Review request for Trac Ticket(s): 901
Peer Reviewer(s): Mathi
Pull request to:
Affected branch(es): default(4.5)
Development branch: default
Impacted area Impact y/n
Makefile.am| 4 +-
configure.ac | 11 +-
contrib/plmc/configure.ac | 6 +-
java/ais_api_impl_native/Makefile.am | 34 +++---
osaf/Makefile.am
osaf/services/saf/amf/amfd/include/si.h | 5 +++-
osaf/services/saf/amf/amfd/si.cc| 43 ++--
2 files changed, 38 insertions(+), 10 deletions(-)
diff --git a/osaf/services/saf/amf/amfd/include/si.h
b/osaf/services/saf/amf/amfd/include/si.h
---
osaf/services/saf/amf/amfd/include/app.h| 6 ++--
osaf/services/saf/amf/amfd/include/sg.h | 31 ++--
osaf/services/saf/amf/amfd/include/si.h | 14 ++--
osaf/services/saf/amf/amfd/include/si_dep.h | 22 ++--
osaf/services/saf/amf/amfd/include/si.h | 5 ++-
osaf/services/saf/amf/amfd/si.cc| 45
2 files changed, 9 insertions(+), 41 deletions(-)
diff --git a/osaf/services/saf/amf/amfd/include/si.h
b/osaf/services/saf/amf/amfd/include/si.h
---
Summary: amfd: Convert AVD_SI from struct to a class [#713]
Review request for Trac Ticket(s): 713
Peer Reviewer(s): AMF maintainers
Pull request to:
Affected branch(es): default
Development branch: default
Impacted area Impact y/n
Hi Ted,
Currently it is available in default staging
you can do `hg clone http://hg.code.sf.net/p/opensaf/staging`
-AVM
On 6/10/2014 7:39 AM, Yao Cheng LIANG wrote:
Dear A V M,
IS that available for download?
Thanks.
Ted
-Original Message-
From: A V Mahesh
Hi
You can also get a snapshot of the latest code (not tested / not yet
released) from:
http://sourceforge.net/p/opensaf/staging/ci/default/tarball
On 10/06/14 12:44, Yao Cheng LIANG wrote:
Dear AVM,
Thanks. But could you tell me the command to download it? I am not familiar
with
Hi Mahesh,
Please check the respective corrective ckpt_data.dataSize = 0; should
also happen in cpnd_evt_proc_nd2nd_ckpt_sect_delete() while sending
CPA_EVT_ND2A_CKPT_ARRIVAL_NTFY event.
Thanks,
Ramesh.
On 6/3/2014 3:01 PM, mahesh.va...@oracle.com wrote:
osaf/services/saf/amf/amfd/sgproc.cc | 153 --
osaf/services/saf/amf/amfnd/err.cc |8 +-
osaf/services/saf/amf/amfnd/susm.cc | 58 -
3 files changed, 131 insertions(+), 88 deletions(-)
AMF performs node-switchover before the clean up of
29 matches
Mail list logo
