Re: [devel] [PATCH 1 of 1] amfnd : speed up shutdown of standby SC upon failover during its shutdown [#942]

2014-06-25 Thread Hans Feldt
Ack /Hans -Original Message- From: praveen.malv...@oracle.com [mailto:praveen.malv...@oracle.com] Sent: den 20 juni 2014 13:39 To: Hans Feldt; nagendr...@oracle.com Cc: opensaf-devel@lists.sourceforge.net Subject: [PATCH 1 of 1] amfnd : speed up shutdown of standby SC upon failover

Re: [devel] [PATCH 1 of 1] smf: update campaign state before restoring pbe in the completed state [#944]

2014-06-25 Thread Hans Feldt
Mathi, Ingvar is on vacation. We have our doubts about this patch. We would like to see SMF retry setting the campaign state to COMPLETED until it succeeds. This state change is a trigger for higher level SW management functionality. With the proposed change in SMF the next level is also

Re: [devel] [PATCH 1 of 1] base: add utilities for sending, receiving over a UNIX socket [#554]

2014-06-25 Thread Ramesh Betham
Ack. No major comments, except to fulfill the comments made with in the patch. Say., + int timeout = 1; // TODO allow configuration? and + char grpmembuf[16384]; // can use sysconf(_SC_GETPW_R_SIZE_MAX) Also can you please elaborate on the implementation scope of ticket #938

[devel] [PATCH 1 of 1] doing osaf_abort() for invalid fd in rda [#928]

2014-06-25 Thread ramesh . betham
osaf/libs/agents/infrastructure/rda/rda_papi.c | 7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) If recv() fails due to any other reason than EAGAIN or EINTR, does osaf_abort() to generate a core dump. diff --git a/osaf/libs/agents/infrastructure/rda/rda_papi.c

[devel] [PATCH 0 of 1] Review Request for Do osaf_abort() for invalid fd in rda [#928]

2014-06-25 Thread ramesh . betham
Summary: Do osaf_abort() for invalid fd in rda [#928] Review request for Trac Ticket(s): #928 Peer Reviewer(s): Mathi Affected branch(es): default, 4.4 and 4.3 Development branch: default Impacted area Impact y/n Docs

[devel] [PATCH 1 of 4] amfd: Change more SI functions to class member functions [#713]

2014-06-25 Thread Gary Lee
osaf/services/saf/amf/amfd/csi.cc | 4 ++-- osaf/services/saf/amf/amfd/include/si.h | 11 +++ osaf/services/saf/amf/amfd/sg_nway_fsm.cc | 4 ++-- osaf/services/saf/amf/amfd/si.cc | 25 - osaf/services/saf/amf/amfd/si_dep.cc | 2 +- 5

[devel] [PATCH 4 of 4] amfd: replace SI encode routines with simple encode [#713]

2014-06-25 Thread Gary Lee
osaf/services/saf/amf/amfd/ckpt_edu.cc | 64 -- osaf/services/saf/amf/amfd/ckpt_enc.cc | 204 2 files changed, 78 insertions(+), 190 deletions(-) diff --git a/osaf/services/saf/amf/amfd/ckpt_edu.cc b/osaf/services/saf/amf/amfd/ckpt_edu.cc ---

Re: [devel] [PATCH 1 of 1] smf: update campaign state before restoring pbe in the completed state [#944]

2014-06-25 Thread Mathivanan Naickan Palanivelu
Hi Hans, SMF retries for about ~ 3.5 minutes on the IMM apis. immutilWrapperProfile.nTries = 500; /* Times */ immutilWrapperProfile.retryInterval = 400; /* MS */ If PBE generation can take a long time, then i think the patch does addresses the issue. i.e. the patch

Re: [devel] [PATCH 1 of 1] smf: update campaign state before restoring pbe in the completed state [#944]

2014-06-25 Thread Mathivanan Naickan Palanivelu
When a campaign enters the completed state, all new software has been installed changes to the information model has been done. In this state, SMF enables the PBE to persist the changes to the cluster information model. In general terms, A campaign in completed state could be of value to the

[devel] [PATCH 0 of 1] Review Request for amfd: SI refactoring part 3 [#713]

2014-06-25 Thread Gary Lee
Summary: amfd: SI refactoring part 7 [#713] Review request for Trac Ticket(s): 713 Peer Reviewer(s): AMF maintainers Pull request to: Affected branch(es): default Development branch: default Impacted area Impact y/n

[devel] [PATCH 1 of 1] amfd: Convert remove_csi and add_csi to static member functions [#713]

2014-06-25 Thread Gary Lee
osaf/services/saf/amf/amfd/csi.cc | 4 ++-- osaf/services/saf/amf/amfd/include/si.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) These functions don't operate directly on this SI instance. Let's make them static member functions for now. diff --git