[devel] [PATCH 0 of 1] Review Request for AMF #911 part 2

2014-07-04 Thread Hans Feldt
Summary: AMF #911 part 2 Review request for Trac Ticket(s): IF ANY LIST THE # Peer Reviewer(s): AMF devels Pull request to: LIST THE PERSON WITH PUSH ACCESS HERE Affected branch(es): default Development branch: IF ANY GIVE THE REPO URL Impacted area Impact

[devel] [PATCH 1 of 1] amfd: allow deletion of UNLOCKED SUs [#911]

2014-07-04 Thread Hans Feldt
osaf/services/saf/amf/amfd/su.cc | 19 --- 1 files changed, 16 insertions(+), 3 deletions(-) diff --git a/osaf/services/saf/amf/amfd/su.cc b/osaf/services/saf/amf/amfd/su.cc --- a/osaf/services/saf/amf/amfd/su.cc +++ b/osaf/services/saf/amf/amfd/su.cc @@ -1361,9 +1361,21 @@

Re: [devel] [PATCH 1 of 1] amfd: allow admin commands before cluster timer expiry [#620]

2014-07-04 Thread Hans Feldt
Just review, see inline /Hans -Original Message- From: nagendr...@oracle.com [mailto:nagendr...@oracle.com] Sent: den 30 juni 2014 12:48 To: Hans Feldt; Hans Nordebäck; praveen.malv...@oracle.com Cc: opensaf-devel@lists.sourceforge.net Subject: [PATCH 1 of 1] amfd: allow admin

Re: [devel] [PATCH 2 of 4] amfd : send error report and clear notifications [#106]

2014-07-04 Thread Hans Feldt
Ack with minor comments inline /Hans -Original Message- From: praveen.malv...@oracle.com [mailto:praveen.malv...@oracle.com] Sent: den 23 juni 2014 14:14 To: Hans Feldt; nagendr...@oracle.com Cc: opensaf-devel@lists.sourceforge.net Subject: [PATCH 2 of 4] amfd : send error report

Re: [devel] [PATCH 4 of 4] amfnd : inform AMFD to send error clear notification [#106]

2014-07-04 Thread Hans Feldt
Ack, comment inline /Hans -Original Message- From: praveen.malv...@oracle.com [mailto:praveen.malv...@oracle.com] Sent: den 23 juni 2014 14:14 To: Hans Feldt; nagendr...@oracle.com Cc: opensaf-devel@lists.sourceforge.net Subject: [PATCH 4 of 4] amfnd : inform AMFD to send error

Re: [devel] [PATCH 1 of 1] amfd: allow admin commands before cluster timer expiry [#620]

2014-07-04 Thread Nagendra Kumar
Thanks for your review. I will incorporate these changes. Is this an Ack then? Thanks -Nagu -Original Message- From: Hans Feldt [mailto:hans.fe...@ericsson.com] Sent: 04 July 2014 16:47 To: Nagendra Kumar; Hans Nordebäck; Praveen Malviya Cc: opensaf-devel@lists.sourceforge.net

Re: [devel] [PATCH 1 of 1] amfd: allow admin commands before cluster timer expiry [#620]

2014-07-04 Thread Hans Feldt
-Original Message- From: Nagendra Kumar [mailto:nagendr...@oracle.com] Sent: den 4 juli 2014 13:44 To: Hans Feldt; Hans Nordebäck; Praveen Malviya Cc: opensaf-devel@lists.sourceforge.net Subject: RE: [PATCH 1 of 1] amfd: allow admin commands before cluster timer expiry [#620]

Re: [devel] [PATCH 1 of 5] NTF: Adapt NTF API to support long DNs [#873]

2014-07-04 Thread Zoran Milinkovic
Hi, Find my comments on ntfsv_sanamet_clone_strptr cases inline. -Original Message- From: Minh Hon Chau [mailto:minh.c...@dektech.com.au] Sent: den 2 juli 2014 07:50 To: Anders Widell; mathi.naic...@oracle.com; Hans Feldt; praveen.malv...@oracle.com Cc:

Re: [devel] [PATCH 2 of 5] NTF: Adapt NTF common library to support long DNs [#873]

2014-07-04 Thread Zoran Milinkovic
Hi, Find my comments inline started with [Zoran]. -Original Message- From: Minh Hon Chau [mailto:minh.c...@dektech.com.au] Sent: den 2 juli 2014 07:50 To: Anders Widell; mathi.naic...@oracle.com; Hans Feldt; praveen.malv...@oracle.com Cc: opensaf-devel@lists.sourceforge.net Subject:

Re: [devel] [PATCH 1 of 1] amfd: allow deletion of UNLOCKED SUs [#911]

2014-07-04 Thread Nagendra Kumar
Ack with: Amf PR doc update for SU creation in locked state and deletion in unlocked state if sg/node admin state is locked-in or node is absent. Thanks -Nagu -Original Message- From: Hans Feldt [mailto:hans.fe...@ericsson.com] Sent: 04 July 2014 15:41 To: Praveen Malviya Cc:

Re: [devel] [PATCH 2 of 5] NTF: Adapt NTF common library to support long DNs [#873]

2014-07-04 Thread minhchau
Please find comments inline Thanks, Minh On 7/4/2014 9:48 PM, Zoran Milinkovic wrote: Hi, Find my comments inline started with [Zoran]. -Original Message- From: Minh Hon Chau [mailto:minh.c...@dektech.com.au] Sent: den 2 juli 2014 07:50 To: Anders Widell;

Re: [devel] [PATCH 1 of 5] NTF: Adapt NTF API to support long DNs [#873]

2014-07-04 Thread minhchau
Please find my comments inline Thanks, Minh On 7/4/2014 9:48 PM, Zoran Milinkovic wrote: Hi, Find my comments on ntfsv_sanamet_clone_strptr cases inline. -Original Message- From: Minh Hon Chau [mailto:minh.c...@dektech.com.au] Sent: den 2 juli 2014 07:50 To: Anders Widell;