[devel] [PATCH 0 of 1] Review Request for amfnd: Log events relating to error escalation timers [#870]

2014-08-06 Thread Gary Lee
Summary: Log events relating to error escalation timers [#870] Review request for Trac Ticket(s): 870 Peer Reviewer(s): AMF maintainers Pull request to: Affected branch(es): default Development branch: default Impacted area Impact y/n

[devel] [PATCH 1 of 1] amfnd: Log events relating to error escalation timers [#870]

2014-08-06 Thread Gary Lee
osaf/services/saf/amf/amfnd/err.cc | 18 +++--- osaf/services/saf/amf/amfnd/include/avnd_tmr.h | 37 osaf/services/saf/amf/amfnd/mbcsv.cc | 4 +- osaf/services/saf/amf/amfnd/su.cc | 2 +- osaf/services/saf/amf/amfnd/susm.cc| 4 +-

[devel] [PATCH 1 of 1] amfd : update saAmfSINumCurrActv/StdbyAssignments in SI during nodefailover [#759]

2014-08-06 Thread praveen . malviya
osaf/services/saf/amf/amfd/sgproc.cc | 20 1 files changed, 20 insertions(+), 0 deletions(-) saAmfSINumCurrActiveAssignments and saAmfSINumCurrStandbyAssignment are the two attributes of SI which together decides saAmfSIAssignmentState of SI. When these two runtime

[devel] [PATCH 0 of 1] Review Request for amfd : update saAmfSINumCurrActv/StdbyAssignments in SI during nodefailover [#759]

2014-08-06 Thread praveen . malviya
Summary: amfd : update saAmfSINumCurrActv/StdbyAssignments in SI during nodefailover [#759] Review request for Trac Ticket(s): #759 Peer Reviewer(s): AMF contributors Pull request to: LIST THE PERSON WITH PUSH ACCESS HERE Affected branch(es): ALL Development branch: IF ANY GIVE THE REPO URL

[devel] [PATCH 0 of 1] Review Request for amfd: start clm track and mark sg stable after node failover [#708]

2014-08-06 Thread nagendra . k
Summary: amfd: start clm track and mark sg stable after node failover [#708] Review request for Trac Ticket(s): #708 Peer Reviewer(s): Hans F, Hans N, Praveen Pull request to: LIST THE PERSON WITH PUSH ACCESS HERE Affected branch(es): All Development branch: Default

[devel] [PATCH 1 of 1] amfd: start clm track and mark sg stable after node failover [#708]

2014-08-06 Thread nagendra . k
osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 44 osaf/services/saf/amf/amfd/sgproc.cc| 5 +++ 2 files changed, 32 insertions(+), 17 deletions(-) During si-swap of mw si, if standby su becomes Act and at that point of time if quiesced su goes down, Amfd isnot

Re: [devel] [PATCH 1 of 3] log: Make limit settings in config object runtime configurable [#921]

2014-08-06 Thread Mathivanan Naickan Palanivelu
Lennart, Couple of more comments: - the update_mailbox_limits() should be called only when there is a change in the role, i.e. Instead of calling update_mailbox_limits() from amf_active_state_handler, we should call it from amf_csi_set_callback() as below: if (role_change == true) { .

Re: [devel] [PATCH 1 of 3] log: Make limit settings in config object runtime configurable [#921]

2014-08-06 Thread Lennart Lund
Hi Mathi, Some comments on your comments: 1) This is a validation of user input and the oi error report is used to give feedback in case incorrect input is given. I don't think this should be logged to the system log (use system log carefully) even if there is a chance that the message is not

Re: [devel] [PATCH 1 of 3] log: Make limit settings in config object runtime configurable [#921]

2014-08-06 Thread Mathivanan Naickan Palanivelu
Inline: - lennart.l...@ericsson.com wrote: Hi Mathi, Yes maybe, but it should only be done if changing to active state and it really doesn't matter if it is done even if the state change fail. Actually, I was pointing out to the case where we can avoid calling update_mailbox_limits

Re: [devel] [PATCH 1 of 3] log: Make limit settings in config object runtime configurable [#921]

2014-08-06 Thread Mathivanan Naickan Palanivelu
Inline, - lennart.l...@ericsson.com wrote: Hi Mathi, Some comments on your comments: 1) This is a validation of user input and the oi error report is used to give feedback in case incorrect input is given. I don't think this should be logged to the system log (use system log

Re: [devel] [PATCH 1 of 3] log: Make limit settings in config object runtime configurable [#921]

2014-08-06 Thread Lennart Lund
Hi Mathi, - in future, we could consider using IMM applier. When the config object was introduced an IMM applier was used. It was removed and replaced by checkpointing because of some synchronization issues when the split file system feature was introduced. Thanks Lennart -Original

Re: [devel] [PATCH 1 of 1] smf: Support DNs longer than 255 bytes [#930]

2014-08-06 Thread Mathivanan Naickan Palanivelu
Hi Robert, Good start. Ack with the following comments: 1) Did you mean to check for 2048? +if (length 0x) { +LOG_ER(object name too long); 2) I tried changing the smf object smfConfig=1,safApp=safSmfService(both in the code and in smfsv_objects.xml) to a longer name, i

[devel] [PATCH 0 of 1] Review Request for PLM: increase plmd timeout and add blocking HPI call during plms init [#977]

2014-08-06 Thread Alex Jones
Summary: PLM: increase plmd timeout and add blocking HPI call during plmd init Review request for Trac Ticket(s): 977 Peer Reviewer(s): Mathi Pull request to: Mathi Affected branch(es): default Development branch: Impacted area Impact y/n

[devel] [PATCH 1 of 1] plm: increase plmd timeout and add blocking HPI call during plms init [#977]

2014-08-06 Thread Alex Jones
osaf/services/infrastructure/nid/config/nodeinit.conf.controller | 2 +- osaf/services/saf/plmsv/plms/hpi_intf/plms_hsm.c | 40 +++--- 2 files changed, 29 insertions(+), 13 deletions(-) The previous patch didn't quite fix the entire problem. Even though the SessionOpen