Hi,
With this patch, the lowest value for `logMaxLogrecsize` in the validation
is set to `256`.
But in logsv class definition, the default value of `
saLogStreamFixedLogRecordSize` is set to `150`.
I think the lowest value for ` logMaxLogrecsize` should be changed to `150`
instead.
Regards,
Vu
Ack, code review only/Thanks HansN
-Original Message-
From: Gary Lee [mailto:gary@dektech.com.au]
Sent: den 14 augusti 2015 07:56
To: nagendr...@oracle.com; Hans Nordebäck; praveen.malv...@oracle.com; Gary Lee
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] amfd:
python/pyosaf/utils/immoi/__init__.py | 402
python/pyosaf/utils/immoi/implementer.py | 893
++
python/samples/immoi/samples/README| 82 +
python/samples/immoi/samples/caps
python/pyosaf/utils/immoi/implementer.py | 7 +++
1 files changed, 7 insertions(+), 0 deletions(-)
When building the full content of the CCB on completed, a dn variable of create
was used without defining it. This patch fixes it.
diff --git a/python/pyosaf/utils/immoi/implementer.py
Summary: pyosaf: [Round 3] Add Python imm oi utils module and sample
applications [#1406]
Review request for Trac Ticket(s): #1406
Peer Reviewer(s): hans.nordeb...@ericsson.com, mathi.naic...@oracle.com,
hung.d.ngu...@dektech.com.au, srikanth.revan...@oracle.com
Pull request to:
python/samples/immoi/samples/users-inheritance-impl | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
Correct the inheritance implementation of the users sample OI to use the right
IMM object.
diff --git a/python/samples/immoi/samples/users-inheritance-impl
python/pyosaf/utils/immoi/__init__.py | 3 -
python/pyosaf/utils/immoi/implementer.py| 64 +---
python/pyosaf/utils/immom/__init__.py | 10 ++-
python/samples/immoi/samples/classes.xml| 15
python/samples/immoi/samples/README | 11 +++
1 files changed, 11 insertions(+), 0 deletions(-)
Add the users sample OI to the README
diff --git a/python/samples/immoi/samples/README
b/python/samples/immoi/samples/README
--- a/python/samples/immoi/samples/README
+++
python/samples/immoi/samples/classes.xml | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
Make the users attribute in the UsersSampleClass multivalued.
diff --git a/python/samples/immoi/samples/classes.xml
b/python/samples/immoi/samples/classes.xml
---
Hi Lennart,
Ack after converging on the following minor comments inline:
- vu.m.ngu...@dektech.com.au wrote:
Hi,
With this patch, the lowest value for `logMaxLogrecsize` in the
validation
is set to `256`.
But in logsv class definition, the default value of `
Summary: imm: classify abort error strings and prefix existing error strings
[#744]
Review request for Trac Ticket(s): 744
Peer Reviewer(s): Neelakanta, Hung
Pull request to: Zoran
Affected branch(es): default(4.7)
Development branch: default(4.7)
Impacted area
osaf/services/saf/immsv/immnd/ImmModel.cc | 126 +++-
osaf/services/saf/immsv/immnd/ImmModel.hh |5 +
osaf/services/saf/immsv/immnd/immnd_evt.c | 48 ++-
osaf/services/saf/immsv/immnd/immnd_init.h |6 +
4 files changed, 156 insertions(+), 29
osaf/services/saf/amf/amfd/include/si.h | 1 +
osaf/services/saf/amf/amfd/si.cc| 18 ++
osaf/services/saf/amf/amfd/siass.cc | 2 ++
3 files changed, 17 insertions(+), 4 deletions(-)
diff --git a/osaf/services/saf/amf/amfd/include/si.h
Summary: amfd: Don't send alarm SI has no current active assignments if node is
locked
Review request for Trac Ticket(s): #1465
Peer Reviewer(s): Nagu, Praveen, Gary
Pull request to:
Affected branch(es): default
Development branch: default
Impacted area
14 matches
Mail list logo
