Hi Vu,
Tested and Acked from me.
Only some minor things that you could consider.
Please see them in lines.
Best Regards,
Giang Do
On 20/08/2015 22:49, Lennart Lund wrote:
> osaf/services/saf/logsv/README | 82 +++-
> osaf/services/saf/logsv/config/logsv_classes.xml | 11
Hi Vu,
Tested and Acked from me.
Only some minor things that you could consider.
Please see them in lines.
Best Regards,
Giang Do
On 20/08/2015 22:49, Lennart Lund wrote:
> osaf/services/saf/logsv/README | 82 +++-
> osaf/services/saf/logsv/config/logsv_classes.xml | 11
osaf/libs/core/leap/os_defs.c | 20 +---
osaf/libs/core/leap/sysf_mem.c | 2 +-
osaf/libs/core/mds/mds_dt_tcp.c | 16 +---
3 files changed, 3 insertions(+), 35 deletions(-)
Since Linux 2.6.27, socketpair() supports the SOCK_NONBLOCK and SOCK_CLOEXEC
flags
Summary:Opensaf : Optimized fcntl() call for sckts/fd FD_CLOEXEC [#1337]
Review request for Trac Ticket(s): #1337
Peer Reviewer(s): Ramesh
Pull request to: <>
Affected branch(es): default
Development branch: default
Impacted area Impact y/n
Hi Zoran,
Ack from me, code reviewed only.
BR,
Tai Dinh
DEK Technologies Vietnam
121/137 Le Loi Street, Ben Thanh Ward,
District 1, HCM City, Vietnam
Mobile: +84 9 33 37 82 90
-Original Message-
From: Zoran Milinkovic [mailto:zoran.milinko...@ericsson.com]
Sent: Wednesday, August 26,
Hi Mathi,
Can you please explain what maintainability problems that we will get because
of this way of checkpointing?
By the way you said that you needed some more time to review #593 "#593 needs
more effort, will prioritize to close it on Monday(28th)". Can you say when
that can be?
Thanks
Hi Lennart,
Oops, I seemed to have replied to the wrong thread.
My ACK was meant for #593.
W.r.t the backward compatibility comment,
Yes, you might remember my comments on using MDS versioning or MBCSv scheme.
Like I said, there was need to create a new mechanism in logsv to start with.
ACK ,
Mathi.
> -Original Message-
> From: giang do [mailto:giang.t...@dektech.com.au]
> Sent: Monday, August 31, 2015 11:32 AM
> To: Lennart Lund; Mathivanan Naickan Palanivelu;
> vu.m.ngu...@dektech.com.au
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: Re: [PATCH 1 of 1] log: Add
I have acked on #593 separately.
That's a mix up :-)
Mathi.
> -Original Message-
> From: Mathivanan Naickan Palanivelu
> Sent: Monday, August 31, 2015 8:58 PM
> To: Lennart Lund; Giang Do T; Vu Nguyen M
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: Re: [devel] [PATCH 1 of 1] log:
Hi Zoran,
I have some inline comments, please see below for details.
Best Regards,
Hung Nguyen
DEK Technologies Vietnam
*From:*Zoran Milinkovic
*Sent:*Friday, August 28, 2015 9:06PM
*To:*Neelakanta Reddy
Hi Lennart,
Tested and Acked from me.
There are some minor comments in lines.
Best Regards,
Giang Do
On 25/08/2015 20:26, Lennart Lund wrote:
> osaf/services/saf/logsv/README | 21 +
> osaf/services/saf/logsv/lgs/lgs_config.c | 50 +-
>
Hi Giang,
Iam unable to apply the patch on the latest staging.
However, the changes look straight forward.
Should we also free logBuf?
Thanks,
Mathi.
> -Original Message-
> From: giang [mailto:giang.t...@dektech.com.au]
> Sent: Tuesday, August 25, 2015 11:24 AM
> To: Mathivanan Naickan
Ack, (On behalf of Ramesh)
Mathi.
> -Original Message-
> From: Zoran Milinkovic [mailto:zoran.milinko...@ericsson.com]
> Sent: Wednesday, August 26, 2015 8:52 PM
> To: tai.d...@dektech.com.au
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: [devel] [PATCH 1 of 1] osaf: fix memory leak
ACK,
On a different topic, I think we should remove this way of checkpointing!
We would end up(if not already) creating maintainability problems,
We should rather use the versioning scheme of mds or mbcsv to perform the
checkpointing.
Thanks,
Mathi.
> -Original Message-
> From: giang
14 matches
Mail list logo
