[devel] [PATCH 0 of 1] Review Request for cpsv: trace log enhancement build 32bit fails [#1524]

2015-10-07 Thread Nhat Pham
Summary: cpsv: trace log enhancement build 32bit fails Review request for Trac Ticket(s): #1524 Peer Reviewer(s): mahesh.va...@oracle.com; anders.wid...@ericsson.com Pull request to: mahesh.va...@oracle.com Affected branch(es): default Development branch: default

[devel] [PATCH 0 of 1] Review Request for log: fix crashed with saLogStreamFixedLogRecordSize=1 [#1466]

2015-10-07 Thread Vu Minh Nguyen
Summary: log: fix crashed with saLogStreamFixedLogRecordSize=1 [#1466] Review request for Trac Ticket(s): #1466 Peer Reviewer(s): mathi.naic...@oracle.com; lennart.l...@ericsson.com; giang.t...@dektech.com.au Pull request to: Lennart Affected branch(es): All branches Development branch: <>

Re: [devel] [PATCH 1 of 1] imm: synchronize applier set on all nodes [#1504]

2015-10-07 Thread Hung Nguyen
Hi Zoran, Reviewed and tested the patch. Ack from me. Best Regards, Hung Nguyen - DEK Technologies From: Zoran Milinkovic zoran.milinko...@ericsson.com Sent: Thursday, October 08, 2015 11:13AM To: Neelakanta

Re: [devel] [PATCH 1 of 1] imm: synchronize applier set on all nodes [#1504]

2015-10-07 Thread Zoran Milinkovic
Hi, Find my comment inline started with [Zoran_2] From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au] Sent: Wednesday, October 07, 2015 1:24 PM To: Zoran Milinkovic; reddy.neelaka...@oracle.com; Anders Björnerstedt Cc: opensaf-devel@lists.sourceforge.net Subject: Re: [devel] [PATCH 1 of 1]

Re: [devel] [PATCH 1 of 1] imm: synchronize applier set on all nodes [#1504]

2015-10-07 Thread Zoran Milinkovic
Hi Hung, Find my comments inline started with [Zoran] From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au] Sent: Wednesday, October 07, 2015 7:11 AM To: Zoran Milinkovic; reddy.neelaka...@oracle.com; Anders Björnerstedt Cc: opensaf-devel@lists.sourceforge.net Subject: Re: [devel] [PATCH 1 of

Re: [devel] [PATCH 1 of 1] imm: synchronize applier set on all nodes [#1504]

2015-10-07 Thread Hung Nguyen
Hi Zoran, Please find my comments started with [Hung_2]. Best Regards, Hung Nguyen - DEK Technologies From: Zoran Milinkovic zoran.milinko...@ericsson.com Sent: Wednesday, October 07, 2015 6:10PM To: Hung

[devel] [PATCH 1 of 1] imm: synchronize applier set on all nodes [#1504]

2015-10-07 Thread Zoran Milinkovic
osaf/services/saf/immsv/immnd/ImmModel.cc | 12 +--- osaf/services/saf/immsv/immnd/ImmModel.hh | 3 ++- osaf/services/saf/immsv/immnd/immnd_evt.c | 15 ++- osaf/services/saf/immsv/immnd/immnd_init.h | 2 +- 4 files changed, 22 insertions(+), 10 deletions(-) If

[devel] [PATCH 0 of 1] Review Request for imm: synchronize applier set on all nodes [#1504]

2015-10-07 Thread Zoran Milinkovic
Summary: imm: synchronize applier set on all nodes [#1504] Review request for Trac Ticket(s): 1504 Peer Reviewer(s): Neelakanta, Anders, Hung Pull request to: Zoran Affected branch(es): opensaf-4.5.x, opensaf-4.6.x, default(4.7) Development branch: default(4.7)

Re: [devel] [PATCH 1 of 1] imm: synchronize applier set on all nodes [#1504]

2015-10-07 Thread Anders Björnerstedt
Hi Hung, comments to your comments. :-) On 10/07/2015 07:11 AM, Hung Nguyen wrote: > Hi Zoran, > > Please find the inline comments below. > This patch fixes the problem but there are a few more things need to be done. > > 1) The only thing that the remote nodes should know about an appliers is