Re: [devel] [PATCH 0 of 1] Review Request for cpsv: Support preserving and recovering checkpoint replicas during headless state V2 [#1621]

2016-02-24 Thread A V Mahesh
Hi Nhat Pham, Please see my comment. -AVM On 2/25/2016 12:07 PM, Nhat Pham wrote: > > Hi Mahesh, > > Please see my comment below with [NhatPham2]. > > Best regards, > > Nhat Pham > > *From:*A V Mahesh [mailto:mahesh.va...@oracle.com] > *Sent:* Thursday, February 25, 2016 11:26 AM > *To:* Nhat

Re: [devel] [PATCH 1 of 5] NTF: Add support cloud resilience for NTF Agent [#1180]

2016-02-24 Thread Vu Minh Nguyen
Hi Minh, I have few comments below [Vu] and one question. I see, in some places, NTF APIs not always return TRY_AGAIN if both SCs down. I am not sure if I feel correctly or not. E.g: In `saNtfNotificationSend` API When the client thread comes to code line `ntfa_mds_msg_sync_send()`, headless

Re: [devel] [PATCH 0 of 1] Review Request for cpsv: Support preserving and recovering checkpoint replicas during headless state V2 [#1621]

2016-02-24 Thread Nhat Pham
Hi Mahesh, Please see my comment below with [NhatPham2]. Best regards, Nhat Pham From: A V Mahesh [mailto:mahesh.va...@oracle.com] Sent: Thursday, February 25, 2016 11:26 AM To: Nhat Pham ; 'Anders Widell' Cc:

Re: [devel] [PATCH 1 of 1] log: fix info represents by millisecond token is not correct [#1619]

2016-02-24 Thread Mathivanan Naickan Palanivelu
Ack, Mathi. > -Original Message- > From: Canh Truong [mailto:canh.v.tru...@dektech.com.au] > Sent: Tuesday, February 23, 2016 8:48 AM > To: vu.m.ngu...@dektech.com.au; lennart.l...@ericsson.com; > anders.wid...@ericsson.com; Mathivanan Naickan Palanivelu > Cc:

Re: [devel] [PATCH 0 of 1] Review Request for cpsv: Support preserving and recovering checkpoint replicas during headless state V2 [#1621]

2016-02-24 Thread A V Mahesh
Hi Nhat Pham, Please see my comment below. -AVM On 2/25/2016 7:54 AM, Nhat Pham wrote: > > Hi Mahesh, > > Would you agree with the comment below? > > To summarize, following are the comment so far: > > *Comment 1*: This functionality should be under checks if Hydra > configuration is enabled

Re: [devel] [PATCH 1 of 1] log: fix info represents by millisecond token is not correct [#1619]

2016-02-24 Thread Vu Minh Nguyen
Ack. Regards, Vu. >-Original Message- >From: Canh Truong [mailto:canh.v.tru...@dektech.com.au] >Sent: Tuesday, February 23, 2016 10:18 AM >To: vu.m.ngu...@dektech.com.au; lennart.l...@ericsson.com; >anders.wid...@ericsson.com; mathi.naic...@oracle.com >Cc:

Re: [devel] [PATCH 1 of 4] log: add support for cloud resilience feature (service part) [#1179]

2016-02-24 Thread Vu Minh Nguyen
Sorry. Please take this attach. Regards, Vu. >-Original Message- >From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au] >Sent: Thursday, February 25, 2016 9:23 AM >To: 'Mathivanan Naickan Palanivelu'; lennart.l...@ericsson.com >Cc: opensaf-devel@lists.sourceforge.net >Subject: Re:

Re: [devel] [PATCH 0 of 1] Review Request for cpsv: Support preserving and recovering checkpoint replicas during headless state V2 [#1621]

2016-02-24 Thread Nhat Pham
Hi Mahesh, Would you agree with the comment below? To summarize, following are the comment so far: Comment 1: This functionality should be under checks if Hydra configuration is enabled in IMM attrName = const_cast("scAbsenceAllowed"). Action: The code will be updated

Re: [devel] [PATCH 1 of 4] log: add support for cloud resilience feature (service part) [#1179]

2016-02-24 Thread Vu Minh Nguyen
Thanks, Mathi. Here is the fix for comments of patch 1/4 and 2/4. Regards, Vu. >-Original Message- >From: Mathivanan Naickan Palanivelu [mailto:mathi.naic...@oracle.com] >Sent: Wednesday, February 24, 2016 5:24 PM >To: vu.m.ngu...@dektech.com.au >Cc: lennart.l...@ericsson.com;

Re: [devel] [PATCH 0 of 1] Review Request for cpsv: Support preserving and recovering checkpoint replicas during headless state V2 [#1621]

2016-02-24 Thread Anders Widell
See my comments inline, marked [AndersW3]. regards, Anders Widell On 02/24/2016 07:32 AM, Nhat Pham wrote: > > Hi Mahesh and Anders, > > Please see my comments below. > > Best regards, > > Nhat Pham > > *From:*A V Mahesh [mailto:mahesh.va...@oracle.com] > *Sent:* Wednesday, February 24, 2016

Re: [devel] [PATCH 1 of 4] log: add support for cloud resilience feature (service part) [#1179]

2016-02-24 Thread Mathivanan Naickan Palanivelu
Ack for patch 1, You could use %PRIx64 for MDS addresses. Mathi. - vu.m.ngu...@dektech.com.au wrote: > osaf/services/saf/logsv/lgs/Makefile.am|6 +- > osaf/services/saf/logsv/lgs/lgs.h | 12 + > osaf/services/saf/logsv/lgs/lgs_cb.h | 14 + >

Re: [devel] [PATCH 2 of 4] log: add support for cloud resilience feature (agent part) [#1179]

2016-02-24 Thread Lennart Lund
Hi Vu In case of an "abandoned" stream the stream object will be removed after a timeout as I mentioned below but the log file that was the "current log file" will not be renamed (renamed with a close time stamp). A stream can be "abandoned" for two reasons: 1. The node with the only client(s)