[devel] [PATCH 1 of 2] log: Ensure output parameter is always initialized by fileclose_h() [#1743]

2016-04-08 Thread Anders Widell
osaf/services/saf/logsv/lgs/lgs_stream.cc | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) Initialize the errno_save output parameters in all code paths in the function fileclose_h(), to fix the following compilation error discovered when using GCC 6: In file included from

[devel] [PATCH 2 of 2] immtest: Remove dead code [#1743]

2016-04-08 Thread Anders Widell
tests/immsv/management/test_saImmOmCcbObjectCreate_2.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) Remove dead code to fix the following compilation error discovered when using GCC 6: test_saImmOmCcbObjectCreate_2.c:20:30: error: 'nonExistingClassName' defined but not used

[devel] [PATCH 0 of 2] Review Request for imm: Fix compilation errors [#1743]

2016-04-08 Thread Anders Widell
Summary: imm: Fix compilation errors [#1743] Review request for Trac Ticket(s): 1743 Peer Reviewer(s): Hung, Neelakanta, Zoran Pull request to: Affected branch(es): opensaf-5.0.x, default(5.1) Development branch: default Impacted area Impact y/n

[devel] [PATCH 1 of 2] immtools: Correct code indentation [#1743]

2016-04-08 Thread Anders Widell
osaf/tools/safimm/immdump/imm_dumper.cc | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) Correct code indentation to fix the following compilation error discovered when using GCC 6: imm_dumper.cc: In function 'int main(int, char**)': imm_dumper.cc:149:5: error: this 'if' clause does

[devel] [PATCH 1 of 1] amfd: allow increase of saAmfSGMaxStandbySIsperSU for N+M SG while UNLOCKED [#1741]

2016-04-08 Thread Alex Jones
osaf/services/saf/amf/amfd/sg.cc | 23 +++ 1 files changed, 23 insertions(+), 0 deletions(-) amfd disallows changing saAmfSGMaxStandbySIsperSU while the SG is UNLOCKED A check is performed in the code to disallow it. Code needs to be added to handle the modification.

Re: [devel] [PATCH 1 of 1] amf: Support AMF configurations containing more than two OpenSAF 2N SUs [#79]

2016-04-08 Thread Anders Widell
Hi! To re-iterate on the comment regarding addition of new validations: what I didn't realise when first commenting on this is that introducing such additional restrictions would not be backwards compatible. We could introduce additional restrictions like this, but then these new restrictions

Re: [devel] [PATCH 1 of 1] clm: Decrease the default election delay time to 200 ms [#1724]

2016-04-08 Thread Anders Widell
We don't actually have any global configuration file; nid.conf is only common for the NID started services. I think we can wait until OpenSAF 5.1 and maybe introduce a global configuration file in that release. regards, Anders Widell On 04/07/2016 06:15 PM, Mathivanan Naickan Palanivelu wrote:

[devel] [PATCH 0 of 1] Review Request for amfnd: change handling of saAmfCSIDependencies to be same for STANDBY as ACTIVE [#1734]

2016-04-08 Thread Alex Jones
Summary: amfnd: change handling of saAmfCSIDependencies to be same for STANDBY as ACTIVE Review request for Trac Ticket(s): 1734 Peer Reviewer(s): praveen, nagu Pull request to: praveen Affected branch(es): default, 5.0, 4.7, 4.6 Development branch: Impacted area

Re: [devel] Review request for NTF: Update PR doc for cloud resilience [#1707]

2016-04-08 Thread Vu Minh Nguyen
Hi Minh, No comment from me. Ack. Regards, Vu. >-Original Message- >From: minh chau [mailto:minh.c...@dektech.com.au] >Sent: Thursday, April 07, 2016 7:28 AM >To: praveen malviya; Lennart Lund; Vu Minh Nguyen >Cc: opensaf-devel@lists.sourceforge.net >Subject: Re: [devel] Review request