Re: [devel] [PATCH 1 of 1] clm: Fix performance regression for standby SC startup time [#1845]

2016-06-14 Thread Mathivanan Naickan Palanivelu
Ack, Mathi. > -Original Message- > From: Anders Widell [mailto:anders.wid...@ericsson.com] > Sent: Wednesday, June 08, 2016 4:14 PM > To: Mathivanan Naickan Palanivelu > Cc: opensaf-devel@lists.sourceforge.net > Subject: [PATCH 1 of 1] clm: Fix performance regression for standby SC >

[devel] [PATCH 0 of 1] Review Request for smf: smfd must be thread safe when IMMND is restarted after the campaign start [#1878]

2016-06-14 Thread reddy . neelakanta
Summary: smf: smfd must be thread safe when IMMND is restarted after the campaign start [#1878] Review request for Trac Ticket(s): 1878 Peer Reviewer(s): Lennart, Rafel, Mathi Affected branch(es): 4.7.x, 5.0.x, default Development branch: default Impacted area

[devel] [PATCH 1 of 1] smf: smfd must be thread safe when IMMND is restarted after the campaign start [#1878]

2016-06-14 Thread reddy . neelakanta
osaf/services/saf/smfsv/smfd/smfd.h | 4 + osaf/services/saf/smfsv/smfd/smfd_campaign_oi.cc | 19 - osaf/services/saf/smfsv/smfd/smfd_cb.h | 1 + osaf/services/saf/smfsv/smfd/smfd_main.c | 86 ++- 4 files changed, 104 insertions(+), 6

[devel] [PATCH 1 of 1] imm: Allow admo hard finalize messages for sync-clients during sync [#1827]

2016-06-14 Thread Hung Nguyen
osaf/services/saf/immsv/immnd/ImmModel.cc | 23 --- osaf/services/saf/immsv/immnd/immnd_evt.c | 29 - osaf/services/saf/immsv/immnd/immnd_init.h | 1 + 3 files changed, 29 insertions(+), 24 deletions(-) This patch is an alternative solution

Re: [devel] [PATCH 1 of 1] log: fix issue with priority of messages adding to mailbox in the server[1396]

2016-06-14 Thread Canh Truong
Hi Mahesh, I have created new test case for multiple threads. Please help check new patch in attachment. Thanks, Canh. -Original Message- From: A V Mahesh [mailto:mahesh.va...@oracle.com] Sent: Tuesday, June 14, 2016 11:03 AM To: Canh Van Truong; vu.m.ngu...@dektech.com.au;

Re: [devel] [PATCH 1 of 1] immtools: Fix memory leak in init_param() [#1876]

2016-06-14 Thread Zoran Milinkovic
Hi Hung, param->paramName alsp need to be freed. Reviewed the patch. Ack from me. Thanks, Zoran -Original Message- From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au] Sent: Tuesday, June 14, 2016 10:37 AM To: Zoran Milinkovic ;

[devel] [PATCH 0 of 1] Review Request for amfnd: do not repair su without AMFD request in su-failover escalation [#1863]

2016-06-14 Thread praveen . malviya
Summary: amfnd: do not repair su without AMFD request in su-failover escalation [#1863]. Review request for Trac Ticket(s): #1863 Peer Reviewer(s): AMF devs Pull request to: <> Affected branch(es): ALL Development branch: <> Impacted area Impact y/n

[devel] [PATCH 1 of 1] amfnd: do not repair su without AMFD request in su-failover escalation [#1863]

2016-06-14 Thread praveen . malviya
osaf/services/saf/amf/amfnd/clc.cc | 5 - osaf/services/saf/amf/amfnd/err.cc | 2 -- osaf/services/saf/amf/amfnd/susm.cc | 5 - 3 files changed, 8 insertions(+), 4 deletions(-) In thre reported problem, lock operation on SU got timeout when a quiesced comp fault with su-failover

Re: [devel] [PATCH 1 of 1] cpnd: To reject creating section which has id length longer than MAX_SEC_ID_LEN [#1667]

2016-06-14 Thread A V Mahesh
Hi Hoang Vo, This patch is already published by Nhat Pham , and it is under review, I also provided few comments ( attached ) , please check. -AVM On 6/14/2016 1:48 PM, Hoang Vo wrote: osaf/services/saf/cpsv/cpnd/cpnd_evt.c | 11 +++ 1 files changed, 11 insertions(+), 0

[devel] [PATCH 0 of 1] Review Request for immtools: Fix memory leak in init_param() [#1876]

2016-06-14 Thread Hung Nguyen
Summary: immtools: Fix memory leak in init_param() [#1876] Review request for Trac Ticket(s): 1876 Peer Reviewer(s): Zoran, Neel Pull request to: Affected branch(es): 4.7, 5.0, 5.1 Development branch: 5.1 Impacted area Impact y/n

[devel] [PATCH 1 of 1] immtools: Fix memory leak in init_param() [#1876]

2016-06-14 Thread Hung Nguyen
osaf/tools/safimm/immadm/imm_admin.c | 7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) Fix memory leak in init_param(). diff --git a/osaf/tools/safimm/immadm/imm_admin.c b/osaf/tools/safimm/immadm/imm_admin.c --- a/osaf/tools/safimm/immadm/imm_admin.c +++

Re: [devel] [PATCH 2 of 2] amfd: fix amfd crash while decoding NG admin state [#1766]

2016-06-14 Thread Hans Nordebäck
ack, code review only/Thanks HansN On 06/09/2016 12:45 PM, praveen.malv...@oracle.com wrote: > osaf/services/saf/amf/amfd/ckpt_dec.cc | 6 +- > 1 files changed, 5 insertions(+), 1 deletions(-) > > > Standby AMFD may get MBCSV checkpoint update for NG admin state after > deletion of >

[devel] [PATCH 0 of 1] Review Request for log: fix fail to delete appstream post headless when controllers come back [#1877]

2016-06-14 Thread Vu Minh Nguyen
Summary: log: fix fail to delete appstream post headless when controllers come back [#1877] Review request for Trac Ticket(s): #1877 Peer Reviewer(s): Lennart, Mahesh Pull request to: <> Affected branch(es): 5.0, default Development branch: default Impacted area

[devel] [PATCH 1 of 1] log: fix fail to delete appstream post headless when controllers come back [#1877]

2016-06-14 Thread Vu Minh Nguyen
osaf/services/saf/logsv/lgs/lgs_imm.cc | 54 +++ tests/logsv/logtest.c | 2 + tests/logsv/logtest.h | 1 + tests/logsv/tet_Log_recov.c| 57 ++ 4 files changed, 100 insertions(+), 14