Re: [devel] [PATCH 1 of 1] amfd: allow lock and unlock operation on NoRed MW SI. [#1834]

2016-07-04 Thread praveen malviya
Hi, Please provide your feedback on this patch. I would like to push this patch by tomorrow. Thanks, Praveen On 24-Jun-16 11:06 AM, praveen.malv...@oracle.com wrote: > osaf/services/saf/amf/amfd/si.cc | 20 +++- > 1 files changed, 19 insertions(+), 1 deletions(-) > > > In the

Re: [devel] [PATCH 2 of 8] cpnd: Add support for extended SaNameT v1 [#1574]

2016-07-04 Thread A V Mahesh
Hi Hoan, On 6/23/2016 4:23 PM, Hoang Vo wrote: > + buf = m_MMGR_ALLOC_CPND_DEFAULT(CPND_MAX_REPLICA_NAME_LENGTH); > + memset(buf, '\0', CPND_MAX_REPLICA_NAME_LENGTH); > + strncpy(buf, cp_node->ckpt_name, CPND_REP_NAME_MAX_CKPT_NAME_LENGTH); > + > + sprintf(buf + strlen(buf) - 1,

Re: [devel] [PATCH 0 of 1] Review Request for smfd:check smfNodeBundleActCmd at the time of modification [#1903]

2016-07-04 Thread Rafael Odzakow
ACK On 06/30/2016 12:47 PM, reddy.neelaka...@oracle.com wrote: > Summary:smfd:check smfNodeBundleActCmd at the time of modification [#1903] > Review request for Trac Ticket(s): 1903 > Peer Reviewer(s): Lennart, Rafael > Affected branch(es): 4.7.x, 5.0.x, default > Development branch: default > >

Re: [devel] [PATCH 1 of 1] libs/core: add support for long DN in sanamet encode & decode functions [#1674]

2016-07-04 Thread ramesh betham
Ack. Code review only. Hope testing covers backward compatibility validations. Regards, Ramesh. On 7/4/2016 1:56 PM, Gary Lee wrote: > Just a friendly reminder to review this patch. > > I would like to push the patch, as we’re planning to send out the long DN > patches for AMF this week, which

[devel] [PATCH 1 of 1] imm: Return ERR_NO_RESOURCES to IMM when PBE fails to get ccb outcome [#1904]

2016-07-04 Thread Hung Nguyen
osaf/libs/common/immsv/immpbe_dump.cc| 4 ++-- osaf/services/saf/immsv/immpbed/immpbe_daemon.cc | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) When getting ccb outcome after a restart, if PBE fails to find the CCB, ERR_NO_RESOURCES will be returned to IMM server. That

[devel] [PATCH 0 of 1] Review Request for imm: Return ERR_NO_RESOURCES to IMM when PBE fails to get ccb outcome [#1904]

2016-07-04 Thread Hung Nguyen
Summary: imm: Return ERR_NO_RESOURCES to IMM when PBE fails to get ccb outcome [#1904] Review request for Trac Ticket(s): 1904 Peer Reviewer(s): Zoran, Neel Pull request to: Affected branch(es): 4.7, 5.0, 5.1 Development branch: 5.1 Impacted area Impact y/n

Re: [devel] [PATCH 1 of 1] libs/core: add support for long DN in sanamet encode & decode functions [#1674]

2016-07-04 Thread ramesh betham
Hi Gary, will try to post my comments by tomorrow at max. Thanks, Ramesh. On 7/4/2016 1:56 PM, Gary Lee wrote: > Just a friendly reminder to review this patch. > > I would like to push the patch, as we’re planning to send out the long DN > patches for AMF this week, which is based on this

Re: [devel] [PATCH 1 of 1] libs/core: add support for long DN in sanamet encode & decode functions [#1674]

2016-07-04 Thread Gary Lee
Just a friendly reminder to review this patch. I would like to push the patch, as we’re planning to send out the long DN patches for AMF this week, which is based on this proposal. Thanks Gary > On 23 Jun 2016, at 4:17 PM, Gary Lee wrote: > >