Hi Gary,
Forgot to say that there are lots of white spaces especially in
utils.cc, please remove all of them and check at other places also.
Thanks
-Nagu
> -Original Message-
> From: Nagendra Kumar
> Sent: 28 July 2016 16:42
> To: Gary Lee; minh.c...@dektech.com.au;
Hi Mahesh,
See my comments inline, started with [Vu].
Regards, Vu
> -Original Message-
> From: mahesh.va...@oracle.com [mailto:mahesh.va...@oracle.com]
> Sent: Tuesday, July 26, 2016 3:43 PM
> To: vu.m.ngu...@dektech.com.au; lennart.l...@ericsson.com
> Cc:
Hi Mahesh,
I have few comments, started with [Vu]:
General: some places use tabs, some other places use spaces.
Regards, Vu
> -Original Message-
> From: mahesh.va...@oracle.com [mailto:mahesh.va...@oracle.com]
> Sent: Tuesday, July 26, 2016 3:43 PM
> To: vu.m.ngu...@dektech.com.au;
Dear Mahesh,
We do not have specific test case and environment for in-service update.
So my test work is based on osaftest cases.
I tested with old d - new nd and new d - old nd cases.
There are failed test cases but after investigating, they are intensional
when old one cannot recognize new
Hi Gary,
Ack with the following comment:
There is chance of getting Amfnd into loop, so please change :
// this loop construct is to handle BAD_HANDLE from
immutil_saImmOmSearchNext_2()
for (;;) {
To
As implemented in avd_imm_reinit_bg_thread in amfd-> imm.cc
Summary:immtools: setting of explcit admin-owner is allowed in explicit commit
mode [#1383]
Review request for Trac Ticket(s): 1383
Peer Reviewer(s): Zoran, Hung
Affected branch(es): default
Development branch: default
Impacted area Impact y/n
Summary: amfd: handle SaNameT properly in avd_saImmOiRtObjectUpdate() [#1642]
Review request for Trac Ticket(s): 1642
Peer Reviewer(s): AMF devs
Pull request to: <>
Affected branch(es): default
Development branch: default
Impacted area Impact y/n
osaf/services/saf/amf/amfd/imm.cc | 13 ++---
1 files changed, 10 insertions(+), 3 deletions(-)
SaNameT and SaStringT types need to be deep copied
diff --git a/osaf/services/saf/amf/amfd/imm.cc
b/osaf/services/saf/amf/amfd/imm.cc
--- a/osaf/services/saf/amf/amfd/imm.cc
+++
Hi Hoang,
I just started reviewing please share following :
I hope this Long DN should support In-service upgrade , if so,
please share the test case that you run , it will help me in reviewing
and in test uncovered use/test cases.
-AVM
On 7/21/2016 3:04 PM, Hoang Vo wrote:
>
