Re: [devel] [PATCH 1 of 3] lga: agent Cluster Membership (CLM) integration [#1638] V1

Hi Vu, I incorporated most of your comments , please find my response with [AVM] & code change in V2 patch ( lga: agent Cluster Membership (CLM) integration [#1638] V2) -AVM On 7/29/2016 9:20 AM, Vu Minh Nguyen wrote: > Hi Mahesh, > > I have few comments, started with [Vu]: > > General:

[devel] [PATCH 1 of 3] lga: agent Cluster Membership (CLM) integration [#1638] V2

osaf/libs/agents/saf/lga/lga.h | 2 + osaf/libs/agents/saf/lga/lga_api.c | 47 osaf/libs/agents/saf/lga/lga_mds.c | 69 ++ osaf/libs/agents/saf/lga/lga_util.c| 2 +

[devel] [PATCH 0 of 3] Review Request for lgsv: Log Service CLM integration [#1638] V2

Summary:lga: agent Cluster Membership (CLM) integration [#1638] V2 Review request for Trac Ticket(s): #1638 Peer Reviewer(s):Vu, Lennart,Anders Widell Pull request to: <> Affected branch(es): default Development branch: default Impacted area Impact y/n

Re: [devel] [PATCH 2 of 3] lgs: director Cluster Membership (CLM) integration [#1638] V1

Hi Vu, I incorporated most of your comments , please find my response with [AVM] & code changes V2 patch (lgs: director Cluster Membership (CLM) integration [#1638] V2) -AVM On 7/29/2016 9:34 AM, Vu Minh Nguyen wrote: > Hi Mahesh, > > See my comments inline, started with [Vu]. > > Regards,

[devel] [PATCH 3 of 3] logtest: change related to Cluster Membership (CLM) integration [#1638] V2

tests/logsv/saflogtest.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Test : #amf-adm lock safNode=PL-4,safCluster=myClmCluster failed with code SA_AIS_ERR_UNAVAILABLE (31). #amf-adm unlock safNode=PL-4,safCluster=myClmCluster failed with code SA_AIS_ERR_UNAVAILABLE

Re: [devel] [PATCH 0 of 3] Review Request for lgsv: Log Service CLM integration [#1638] V1

Hi Anders Widell, I incorporated most of your comments except NCS_PATRICIA_TREE refactoring to std::map. Please find my response with [AVM] & code changes V2 patch (lgs: director Cluster Membership (CLM) integration [#1638] V2) -AVM On 7/27/2016 6:54 PM, Anders Widell wrote: > Hi! > > Some

Re: [devel] [PATCH 1 of 5] amfd: replace SaNameT with string in include dir [#1642]

Hi Praveen On 1/08/2016 4:29 PM, praveen malviya wrote: > Hi Gary, Long, > > Some comments/observations: > -In AMFD saAisNameBorrow() is used in logging and AMFND uses > osaf_extended_name_borrow(). > For osaf_extended_name_borrow() note in osaf_extended_name.h says it > is intended for mainly

Re: [devel] [PATCH 1 of 1] imm:send 2PBE preload information for controller IMMND [#1925]

Hi Hung, comments inline. Thanks, Neel. On 2016/07/29 04:32 PM, Hung Nguyen wrote: > Hi Neel, > > Reviewed and tested the patch. > Ack with minor comments below. > > BR, > Hung Nguyen - DEK Technologies > > > From:

Re: [devel] [PATCH 1 of 5] amfd: replace SaNameT with string in include dir [#1642]

Hi Gary, Long, Some comments/observations: -In AMFD saAisNameBorrow() is used in logging and AMFND uses osaf_extended_name_borrow(). For osaf_extended_name_borrow() note in osaf_extended_name.h says it is intended for mainly agent libraries. But middle-ware services always use core libs. At