Re: [devel] [PATCH 2 of 2] AMFND: Admin operation continuation if csi callback completes during headless [#1725 part 1] V1

Hi Praveen, There's a bug in V1 at AMFD side, so I floated V2. The change is commented in V2: " This V2 avoid AMFD crash if scAbsence is not configured. V2's diff (from V1) is at avd_process_state_info_queue() " So latest patches are below: [PATCH 0 of 2] Review Request for AMF: Support admin

Re: [devel] [PATCH 2 of 2] AMFND: Admin operation continuation if csi callback completes during headless [#1725 part 1] V1

Hi Minh, Not all the patches are received. Also in the two received patches contents are same but commit messages are different. If this because of size of the patches, please upload in the ticket. Thanks, Praveen On 05-Aug-16 2:50 AM, Minh Hon Chau wrote: > osaf/services/saf/amf/amfnd/di.cc

Re: [devel] [PATCH 2 of 3] lgs: director Cluster Membership (CLM) integration [#1638] V3

Hi Mahesh, I have some comments [Vu]. Regards, Vu > -Original Message- > From: mahesh.va...@oracle.com [mailto:mahesh.va...@oracle.com] > Sent: Thursday, August 4, 2016 6:13 PM > To: vu.m.ngu...@dektech.com.au; lennart.l...@ericsson.com; > anders.wid...@ericsson.com > Cc:

Re: [devel] [PATCH 1 of 1] dtm: When IPv4 broadcast address is not configured, derive it from IP and netmask [#1930]

Hi Anders Widell, Did you verified IP6 or you want me to test ? -AVM On 8/4/2016 2:22 PM, Anders Widell wrote: > osaf/services/infrastructure/dtms/dtm/dtm_read_config.c | 36 > +++- > 1 files changed, 32 insertions(+), 4 deletions(-) > > > The IPv4 broadcast address is

Re: [devel] [PATCH 1 of 1] pyosaf: Add __str__ method into non extended SaNameT class [#1737]

Hi, Please help review! Thanks, Quyen -Original Message- From: Quyen Dao [mailto:quyen@dektech.com.au] Sent: Wednesday, May 25, 2016 11:45 AM To: hans.nordeb...@ericsson.com; srikanth.revan...@oracle.com Cc: opensaf-devel@lists.sourceforge.net Subject: [devel] [PATCH 1 of 1]

Re: [devel] [PATCH 1 of 1] ntfsv: refactor logging long dn notification [#1585]

Hi Praveen, Truncation is removed as LOG supports Long DN now. Means, NTF would not get INVALID_PARAM if logging longdn-contained notifications. Regards, Vu > -Original Message- > From: praveen malviya [mailto:praveen.malv...@oracle.com] > Sent: Thursday, August 4, 2016 8:24 PM > To: Vu

[devel] [PATCH 0 of 2] Review Request for AMF: Support admin operation continuation after headless [#1725 Part 1] V2

Summary: AMF: Support admin operation continuation after headless [#1725 Part 1] V2 Review request for Trac Ticket(s): 1725 Peer Reviewer(s): AMF devs Pull request to: <> Affected branch(es): default Development branch: default Impacted area Impact y/n

[devel] [PATCH 1 of 2] AMFD: Introduce new RTA states for admin operation continuation after headless [#1725 part 1] V2

osaf/services/saf/amf/amfd/cluster.cc|4 + osaf/services/saf/amf/amfd/csi.cc| 38 - osaf/services/saf/amf/amfd/imm.cc|5 +- osaf/services/saf/amf/amfd/include/csi.h |1 - osaf/services/saf/amf/amfd/include/imm.h |5 +-

[devel] [PATCH 2 of 2] AMFND: Admin operation continuation if csi callback completes during headless [#1725 part 1] V1

osaf/services/saf/amf/amfnd/di.cc | 199 + osaf/services/saf/amf/amfnd/include/avnd_di.h |1 + 2 files changed, 134 insertions(+), 66 deletions(-) The patch buffers susi_resp_msg during headless stage and resend it to AMFD after headless. diff --git

[devel] OpenSAF 5.1 Feature Complete Tagging on August 29

Hi all! We are planning to tag OpenSAF 5.1.FC (feature complete) on August 29. Please plan your work on enhancement tickets that you wish to include in OpenSAF 5.1 so that they are pushed to the default branch before we tag 5.1.FC. Remember that code review can take some time, so make sure to

Re: [devel] [PATCH 2 of 3] lgs: director Cluster Membership (CLM) integration [#1638] V3

Hi Mahesh I still have some comments. Please see my comments inline [Lennart] Thanks Lennart > -Original Message- > From: mahesh.va...@oracle.com [mailto:mahesh.va...@oracle.com] > Sent: den 4 augusti 2016 13:13 > To: Vu Minh Nguyen ; Lennart Lund >

Re: [devel] [PATCH 1 of 1] ntfsv: refactor logging long dn notification [#1585]

Hi Vu, TWith this patch Ntf will not perform any truncation on long dn while saflogging alrams.Is it with the log service (after supporting long dn) also or log service is performing any truncation before logging? Thanks, Praveen On 22-Jul-16 4:46 PM, Vu Minh Nguyen wrote: >

[devel] [PATCH 1 of 2] AMFD: Introduce new RTA states for admin operation continuation after headless [#1725 P1]

osaf/services/saf/amf/amfd/cluster.cc|4 + osaf/services/saf/amf/amfd/csi.cc| 38 - osaf/services/saf/amf/amfd/imm.cc|5 +- osaf/services/saf/amf/amfd/include/csi.h |1 - osaf/services/saf/amf/amfd/include/imm.h |5 +-

[devel] [PATCH 0 of 2] Review Request for AMF: Support admin operation continuation after headless [#1725 Part 1]

Summary: AMF: Support admin operation continuation after headless [#1725 Part 1] Review request for Trac Ticket(s): 1725 Peer Reviewer(s): AMF devs Pull request to: <> Affected branch(es): default Development branch: default Impacted area Impact y/n

[devel] [PATCH 2 of 2] AMFND: Admin operation continuation if csi callback completes during headless [#1725 P2]

osaf/services/saf/amf/amfnd/di.cc | 199 + osaf/services/saf/amf/amfnd/include/avnd_di.h |1 + 2 files changed, 134 insertions(+), 66 deletions(-) The patch buffers susi_resp_msg during headless stage and resend it to AMFD after headless. diff --git

Re: [devel] [PATCH 3 of 3] logtest: change related to Cluster Membership (CLM) integration [#1638] V3

Hi Mahesh Please create UML test cases. In log service it is possible if needed to create test cases that does not run as part of the legacy test suite (when using command logtest without options or parameters). It is also possible to create test cases where the tester is asked to do actions

Re: [devel] [PATCH 0 of 3] Review Request for lgsv: Log Service CLM integration [#1638] V2

Hi Anders Widell, I ran & cleared all the warnings provide by "make cppcheck" and "make cpplint" tools in new files lgs_clm.cc & lgs_clm.h in V3 patch please review. -AVM On 8/2/2016 4:02 PM, Anders Widell wrote: > Hi! > > I ran "make cppcheck" and "make cpplint" on these new patches,

Re: [devel] [PATCH 2 of 3] lgs: director Cluster Membership (CLM) integration [#1638] V2

Hi Lennar, I incorporated most of your review comments except creating a LgsClm class in V3 patch please review. -AVM On 8/2/2016 6:30 PM, Lennart Lund wrote: > Hi > > My comments for patch 2 > > I have found some things that should be considered in order to get as clean > code as possible: >

[devel] [PATCH 2 of 3] lgs: director Cluster Membership (CLM) integration [#1638] V3

osaf/services/saf/logsv/lgs/Makefile.am |7 +- osaf/services/saf/logsv/lgs/lgs_cb.h|9 + osaf/services/saf/logsv/lgs/lgs_clm.cc | 403 osaf/services/saf/logsv/lgs/lgs_clm.h | 39 +++ osaf/services/saf/logsv/lgs/lgs_evt.cc | 15 +

[devel] [PATCH 1 of 3] lga: agent Cluster Membership (CLM) integration [#1638] V3

osaf/libs/agents/saf/lga/lga.h | 3 + osaf/libs/agents/saf/lga/lga_api.c | 52 ++ osaf/libs/agents/saf/lga/lga_mds.c | 69 ++ osaf/libs/agents/saf/lga/lga_util.c| 2 +

[devel] [PATCH 0 of 3] Review Request for lgsv: Log Service CLM integration [#1638] V3

Summary:lgsv: Log Service CLM integration [#1638] V3 Review request for Trac Ticket(s): #1638 Peer Reviewer(s): Vu, Lennart,Anders Widell Pull request to: <> Affected branch(es): default Development branch: default Impacted area Impact y/n

Re: [devel] [PATCH 1 of 1] plm: resurrect PLM tests [#1924]

FYI, I just pushed #1813 and #1924 Mathi. > > -Original Message- > > From: Mathivanan Naickan Palanivelu > > Sent: Monday, July 25, 2016 2:48 PM > > To: Alex Jones > > Cc: opensaf-devel@lists.sourceforge.net > > Subject: Re: [devel] [PATCH 1 of 1] plm: resurrect PLM tests [#1924] > > > >

Re: [devel] [PATCH 1 of 1] log: fix issue with priority of messages adding to mailbox in the server[1396]

Hi Lennart, I'd like to send to you latest patch that shall be reviewed. Thanks, Canh. -Original Message- From: Lennart Lund [mailto:lennart.l...@ericsson.com] Sent: Thursday, August 04, 2016 5:38 PM To: A V Mahesh; Canh Van Truong; Vu Minh Nguyen Cc:

Re: [devel] [PATCH 1 of 1] ntfsv: refactor logging long dn notification [#1585]

Hi, F.Y.I: #1315 was pushed. You now can test this patch. Regards, Vu > -Original Message- > From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au] > Sent: Monday, July 25, 2016 9:59 AM > To: 'minh chau' ; 'praveen malviya' > ;

Re: [devel] [PATCH 1 of 1] log: fix issue with priority of messages adding to mailbox in the server[1396]

Hi Canh My comments are very old, October 2015 and they are mostly about list handling (see attached mail). Since then the log server has been refactored to C++ so C++ tools for lists can be used. There seems to be a lot of mail conversations with included patches etc. and since I haven't been

Re: [devel] long DN [#1315]

Hi Vu, I have looked at the latest REAME files you sent. There are some issues but I think they are good enough. However Anders Widell has also sent some comments. After fixing those ACK from me. Regards Lennart > -Original Message- > From: Vu Minh Nguyen

Re: [devel] [PATCH 1 of 1] log: Readme file for long DN support [#1315]

Thanks Anders. I will do that before pushing. Regards, Vu From: Anders Widell [mailto:anders.wid...@ericsson.com] Sent: Thursday, August 4, 2016 3:23 PM To: Vu Minh Nguyen ; 'Lennart Lund' ; mahesh.va...@oracle.com Cc:

Re: [devel] [PATCH 1 of 1] amfa: enable long DN support [#1642]

Please find some comments inline with [Praveen] Thanks, Praveen On 11-Jul-16 3:38 PM, Long HB Nguyen wrote: > osaf/libs/agents/saf/amfa/Makefile.am |1 + > osaf/libs/agents/saf/amfa/amf_agent.cc | 638 > ++- > osaf/libs/agents/saf/amfa/ava_hdl.cc

[devel] [PATCH 1 of 1] dtm: When IPv4 broadcast address is not configured, derive it from IP and netmask [#1930]

osaf/services/infrastructure/dtms/dtm/dtm_read_config.c | 36 +++- 1 files changed, 32 insertions(+), 4 deletions(-) The IPv4 broadcast address is sometimes not configured when running in some container environments (e.g. docker). In these cases, derive the broadcast address from

[devel] [PATCH 0 of 1] Review Request for dtm: When IPv4 broadcast address is not configured, derive it from IP and netmask [#1930]

Summary: dtm: When IPv4 broadcast address is not configured, derive it from IP and netmask [#1930] Review request for Trac Ticket(s): 1930 Peer Reviewer(s): Mahesh Pull request to: Affected branch(es): default(5.1) Development branch: default Impacted area

Re: [devel] [PATCH 1 of 1] log: Readme file for long DN support [#1315]

Hi Vu! Could you re-format the README files so that you keep the line length below 80 characters? Hint: If you are using the emacs configuration provided on the wiki (which you should :-), then you can easily re-format the text by pressing M-q in each paragraph. Also delete all trailing

Re: [devel] [PATCH 4 of 4] log: create test cases and update logtest for long DN [#1315]

Hi Vu ACK Thanks Lennart > -Original Message- > From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au] > Sent: den 1 juli 2016 12:42 > To: mahesh.va...@oracle.com; Lennart Lund > Cc: opensaf-devel@lists.sourceforge.net > Subject: [PATCH 4 of 4] log: create

Re: [devel] [PATCH 1 of 4] log: add one new option -f to saflogger tool [#1315]

Thanks Lennart for your info. I will put that header back before pushing. Regards, Vu > -Original Message- > From: Lennart Lund [mailto:lennart.l...@ericsson.com] > Sent: Thursday, August 4, 2016 2:10 PM > To: Vu Minh Nguyen ; > mahesh.va...@oracle.com > Cc:

Re: [devel] [PATCH 1 of 4] log: add one new option -f to saflogger tool [#1315]

Hi Vu [Vu] The header "saAis.h" contains core definitions. It must be included in > each service API header file (e.g "saLog.h") > I think the application no need to include that core header file, include > service API header file is enough. It is correct as you say that saAis.h has to be