Re: [devel] [PATCH 6 of 8] cpsv: Apply new messages supporting extended SaNameT to CPD, CPND, and CPA v1 [#1574]

2016-08-11 Thread A V Mahesh
Hi Hoang, We don't required any new event like CPND_EVT_D2ND_CKPT_CREATE_2 even though NEW CPND might might be sending event to OLD CPD. In general Opensaf rule is that any newly introduce enhancement/feature functionality can be used once Cluster is completely upgraded to new version.So while

Re: [devel] [PATCH 4 of 8] cpsv: Add new message to support extended SaNameT v1 [#1574]

2016-08-11 Thread A V Mahesh
Hi Hoang, I completed the testing most of the in service & normal test case are working fine , so I stated reviewing code now can please answer below : 1) This patch introduced multiple new event between Agent to ND which are always local to the node ( in a new version software cpa & cpnd

Re: [devel] [PATCH 1 of 1] cpsv: To update checkpoint user number for each node [#1669] V4

2016-08-11 Thread A V Mahesh
I will test for you send the patch. -AVM On 8/11/2016 3:38 PM, Vo Minh Hoang wrote: > Dear Mahesh, > > Would you please tell me the case that produce this error? > I review source code and found that encode/decode function missed 1 > attribute. > But running test in our environment could not

Re: [devel] [PATCH 1 of 1] fm: Enabling remote fencing is not correct [#1949]

2016-08-11 Thread Mathivanan Naickan Palanivelu
ACK, Mathi > -Original Message- > From: Hans Nordeback [mailto:hans.nordeb...@ericsson.com] > Sent: Thursday, August 11, 2016 2:38 PM > To: anders.wid...@ericsson.com; Mathivanan Naickan Palanivelu > Cc: opensaf-devel@lists.sourceforge.net > Subject: [PATCH 1 of 1] fm: Enabling remote

Re: [devel] [PATCH 1 of 1] cpsv: To update checkpoint user number for each node [#1669] V4

2016-08-11 Thread Vo Minh Hoang
Dear Mahesh, Would you please tell me the case that produce this error? I review source code and found that encode/decode function missed 1 attribute. But running test in our environment could not reproduce this problem. Thank you and best regards, Hoang -Original Message- From: A V

[devel] [PATCH 1 of 1] fm: Enabling remote fencing is not correct [#1949]

2016-08-11 Thread Hans Nordeback
osaf/services/infrastructure/fm/fms/fm_main.c | 9 +++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/osaf/services/infrastructure/fm/fms/fm_main.c b/osaf/services/infrastructure/fm/fms/fm_main.c --- a/osaf/services/infrastructure/fm/fms/fm_main.c +++

[devel] [PATCH 0 of 1] Review Request for fm: Enabling remote fencing is not correct [#1949]

2016-08-11 Thread Hans Nordeback
Summary: fm: Enabling remote fencing is not correct Review request for Trac Ticket(s): #1949 Peer Reviewer(s): AndersW, Mathi Pull request to: Affected branch(es): default Development branch: default Impacted area Impact y/n

[devel] [PATCH 1 of 1] imm: Return implementer ID to timed out client [#1948]

2016-08-11 Thread Hung Nguyen
osaf/services/saf/immsv/immnd/ImmModel.cc | 12 ++-- osaf/services/saf/immsv/immnd/immnd_evt.c | 9 - osaf/services/saf/immsv/immnd/immnd_init.h | 2 +- 3 files changed, 19 insertions(+), 4 deletions(-) When receiving redundant request that comes from timed out client,

[devel] [PATCH 0 of 1] Review Request for imm: Return implementer ID to timed out client [#1948]

2016-08-11 Thread Hung Nguyen
Summary: imm: Return implementer ID to timed out client [#1948] Review request for Trac Ticket(s): 1948 Peer Reviewer(s): Zoran, Neel Pull request to: Affected branch(es): 4.7, 5.0, 5.1 Development branch: 5.1 Impacted area Impact y/n

[devel] [PATCH 0 of 1] Review Request for ntfsv: refactor logging long dn notification [#1585] V2

2016-08-11 Thread Vu Minh Nguyen
Summary: ntfsv: refactor logging long dn notification [#1585] Review request for Trac Ticket(s): #1585 Peer Reviewer(s): NTF maintainers Pull request to: <> Affected branch(es): Default Development branch: Default Impacted area Impact y/n

[devel] [PATCH 1 of 1] ntfsv: refactor logging long dn notification [#1585]

2016-08-11 Thread Vu Minh Nguyen
osaf/services/saf/ntfsv/ntfs/NtfLogger.cc | 51 +- tests/ntfsv/tet_longDnObject_notification.c | 188 +++- 2 files changed, 196 insertions(+), 43 deletions(-) Remove the part of code that truncates the long DN. And update the long DN test suite (#36) to make

[devel] [PATCH 1 of 1] imm: Do not revert isApplier and isPbe flag when timeout occurs [#1943]

2016-08-11 Thread Hung Nguyen
osaf/libs/agents/saf/imma/imma_oi_api.c | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) Do not revert isApplier and isPbe flag when timeout occurs. diff --git a/osaf/libs/agents/saf/imma/imma_oi_api.c b/osaf/libs/agents/saf/imma/imma_oi_api.c ---

[devel] [PATCH 0 of 1] Review Request for imm: Do not revert isApplier and isPbe flag when timeout occurs [#1943]

2016-08-11 Thread Hung Nguyen
Summary: imm: Do not revert isApplier and isPbe flag when timeout occurs [#1943] Review request for Trac Ticket(s): 1943 Peer Reviewer(s): Zoran, Neel Pull request to: Affected branch(es): 4.7, 5.0, 5.1 Development branch: 5.1 Impacted area Impact y/n

[devel] [PATCH 1 of 1] imm: Return implementer ID to timed out client [#1948]

2016-08-11 Thread Hung Nguyen
osaf/services/saf/immsv/immnd/ImmModel.cc | 12 ++-- osaf/services/saf/immsv/immnd/immnd_evt.c | 10 +- osaf/services/saf/immsv/immnd/immnd_init.h | 2 +- 3 files changed, 20 insertions(+), 4 deletions(-) When receiving redundant request that comes from timed out client,

[devel] [PATCH 0 of 1] Review Request for log: improve test cases for log service [#1913]

2016-08-11 Thread Canh Van Truong
Summary: log: improve test cases for log service [#1913] Review request for Trac Ticket(s): #1913 Peer Reviewer(s): Vu, Mahesh, Lennart Pull request to: Vu Affected branch(es): default Development branch: default Impacted area Impact y/n

Re: [devel] [PATCH 1 of 1] dtm: When IPv4 broadcast address is not configured, derive it from IP and netmask [#1930]

2016-08-11 Thread A V Mahesh
Hi Anders Widell, ACK with assumption, that In Container environments IV6 not being used/issue doesn't observed. -AVM On 8/4/2016 2:22 PM, Anders Widell wrote: > osaf/services/infrastructure/dtms/dtm/dtm_read_config.c | 36 > +++- > 1 files changed, 32 insertions(+), 4