Re: [devel] [PATCH 3 of 5] imm: Checking of Imm limits [#195]

2016-08-12 Thread Zoran Milinkovic
Hi Neelakanta, Find my comments inline -Original Message- From: reddy.neelaka...@oracle.com [mailto:reddy.neelaka...@oracle.com] Sent: den 27 juli 2016 10:32 To: Zoran Milinkovic; Hung Duc Nguyen Cc: opensaf-devel@lists.sourceforge.net Subject: [PATCH 3 of 5] imm: Checking of Imm limits

Re: [devel] [PATCH 1 of 5] amfd: replace SaNameT with string in include dir [#1642]

2016-08-12 Thread praveen malviya
Hi Long, I have checked. The problem is not with ava_sanamet_is_valid(). Agent is getting that env variable for AMFND when it instantiates the component using CLC-CLI script. This needs to be fixed in amfnd patch. Thanks, Praveen On 12-Aug-16 3:33 PM, praveen malviya wrote: > > > On

Re: [devel] [PATCH 1 of 1] imm:send 2PBE preload information for controller IMMND [#1925]

2016-08-12 Thread Zoran Milinkovic
Hi Neelakanta, Ack from me. Thanks, Zoran -Original Message- From: Neelakanta Reddy [mailto:reddy.neelaka...@oracle.com] Sent: den 10 augusti 2016 11:44 To: Zoran Milinkovic; Hung Duc Nguyen Cc: opensaf-devel@lists.sourceforge.net Subject: Re: [PATCH 1 of 1] imm:send 2PBE preload

Re: [devel] [PATCH 0 of 2] Review Request for imm: Use high resolution time measurements [#1704]

2016-08-12 Thread Neelakanta Reddy
Hi Hung, Reviewed and tested the patch. Ack. /Neel. On 2016/08/05 01:59 PM, Hung Nguyen wrote: > Summary: imm: Use high resolution time measurements [#1704] > Review request for Trac Ticket(s): 1704 > Peer Reviewer(s): Zoran, Neel > Pull request to: > Affected branch(es): 5.1 > Development

Re: [devel] [PATCH 1 of 5] amfd: replace SaNameT with string in include dir [#1642]

2016-08-12 Thread praveen malviya
On 12-Aug-16 1:27 PM, Long Nguyen wrote: > Hi Praveen, > > Actually, since Anders introduced the extended SaNameT in leap core, he > also added the osaf_extended_name_init() into leap. > Amf agent uses leap library (i.e. saAmfInitialize()). So, applications > under amf control enabled long DN

Re: [devel] [PATCH 1 of 1] log: fix incorrect usage of saImmRtObjectDelete on cfg app stream [#1330]

2016-08-12 Thread Vu Minh Nguyen
Hi Lennart, Thanks for your good finding. I will fix it before pushing. Regards, Vu > -Original Message- > From: Lennart Lund [mailto:lennart.l...@ericsson.com] > Sent: Friday, August 12, 2016 3:27 PM > To: Vu Minh Nguyen ; > mahesh.va...@oracle.com > Cc:

Re: [devel] [PATCH 1 of 1] log: fix incorrect usage of saImmRtObjectDelete on cfg app stream [#1330]

2016-08-12 Thread Lennart Lund
Hi Vu, Ack with comments Seems as if the isRtStream flag is not set to true when a rt-stream is recovered see lgs_recov.cc Thanks Lennart > -Original Message- > From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au] > Sent: den 20 juli 2016 08:11 > To: mahesh.va...@oracle.com;

Re: [devel] [PATCH 1 of 5] amfd: replace SaNameT with string in include dir [#1642]

2016-08-12 Thread Long Nguyen
Hi Praveen, Actually, since Anders introduced the extended SaNameT in leap core, he also added the osaf_extended_name_init() into leap. Amf agent uses leap library (i.e. saAmfInitialize()). So, applications under amf control enabled long DN implicitly. The SA_AIS_ERR_NAME_TOO_LONG return code

Re: [devel] [PATCH 0 of 1] Review Request for log: improve test cases for log service [#1913]

2016-08-12 Thread A V Mahesh
Hi Canh Van Truong, On 8/11/2016 11:50 AM, Canh Van Truong wrote: > 2) Remove abort (safassert) in test case and handle it as test case failed. Still seeing abort (safassert) Suite 2: Log Service

Re: [devel] [PATCH 1 of 1] cpsv: To update checkpoint user number for each node [#1669] V4

2016-08-12 Thread Vo Minh Hoang
Dear Mahesh, Thank you very much for your help. I send the attached patch that fix missing in encode/decode function. Thank you and best regards, Hoang -Original Message- From: A V Mahesh [mailto:mahesh.va...@oracle.com] Sent: Friday, August 12, 2016 10:15 AM To: Vo Minh Hoang

Re: [devel] [PATCH 0 of 2] Review Request for AMF: Support admin operation continuation after headless [#1725 Part 1] V2

2016-08-12 Thread minh chau
Hi Nagu, Praveen, Can you please give me comments if you have any so far, that would help me revise some codes first while you can continue reviewing? There are some changes in SG codes, I hope it doesn't break the SG's existing logic. Thanks, Minh On 05/08/16 07:20, Minh Hon Chau wrote: >