Hi Nagu
ack (review only)
Thanks
On 4/08/2016 3:20 PM, nagendr...@oracle.com wrote:
> osaf/services/saf/amf/amfnd/susm.cc | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
>
> During component failover recovery (NPI SU), Amfnd
> attempt to send SUSI resp to Amfd though there is
Hi Nagu
Would it be possible to reuse avd_ng_config_get()?
Thanks
Gary
On 4/08/2016 8:58 PM, nagendr...@oracle.com wrote:
> osaf/services/saf/amf/amfd/nodegroup.cc | 35
> +---
> 1 files changed, 31 insertions(+), 4 deletions(-)
>
>
> There are chances that node
Summary: AMFD: Correct setting SU in-server [#1938]
Review request for Trac Ticket(s): 1938
Peer Reviewer(s): AMF maintainers
Pull request to: <>
Affected branch(es): 5.0, default
Development branch: default
Impacted area Impact y/n
Hi Nagu,
I got this.
CXX osafamfd-sg_2n_fsm.o
CXX osafamfd-sg_nored_fsm.o
sg_2n_fsm.cc: In member function ‘virtual SaAisErrorT
SG_2N::si_swap(AVD_SI*, SaInvocationT)’:
sg_2n_fsm.cc:775:6: error: ‘cb’ was not declared in this scope
((cb->node_id_avd_other != 0) &&
Hi Zoran,
Reviewed the patch.
Ack.
/Neel.
On 2016/08/16 04:22 PM, Hung Nguyen wrote:
> Summary: imm: Add readme for SC absence feature [#1856]
> Review request for Trac Ticket(s): 1856
> Peer Reviewer(s): Zoran, Neel
> Pull request to:
> Affected branch(es): 5.0, 5.1
> Development branch: 5.1
>
Hi Hung,
Reviewed the patch.
Ack from me.
Thanks,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 16 augusti 2016 12:52
To: Zoran Milinkovic; reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 0 of 1] Review
osaf/services/saf/immsv/README| 2 +
osaf/services/saf/immsv/README.SC_ABSENCE | 78 +++
2 files changed, 80 insertions(+), 0 deletions(-)
Add readme for SC absence feature.
diff --git a/osaf/services/saf/immsv/README b/osaf/services/saf/immsv/README
Summary: imm: Add readme for SC absence feature [#1856]
Review request for Trac Ticket(s): 1856
Peer Reviewer(s): Zoran, Neel
Pull request to:
Affected branch(es): 5.0, 5.1
Development branch: 5.1
Impacted area Impact y/n
Hi Praveen,
Yes, the option 3 has a problem to make the names to be unique.
For the option 2, I agree that it will be complex.
We would like to understand more in the situation. Why do we need to
support adding csi (long DN) dynamically to an application (does not
support long DN) while we can
Hi,
ACK , tested
Please re-base before publishing.
-AVM
On 8/4/2016 9:36 AM, Canh Van Truong wrote:
> osaf/services/saf/logsv/lgs/lgs_imm.cc | 52
> +-
> 1 files changed, 26 insertions(+), 26 deletions(-)
>
>
> When changing saLogStreamFileName with other
osaf/services/saf/logsv/lgs/lgs_evt.cc | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
Assertion failed in log_stream_close() because the caller did not check NULL
before calling the function.
This patch adds the protection.
diff --git a/osaf/services/saf/logsv/lgs/lgs_evt.cc
Summary: log: assertion failed in log_stream_close [#1954]
Review request for Trac Ticket(s): #1954
Peer Reviewer(s): Lennart, Mahesh
Pull request to: <>
Affected branch(es): all branches
Development branch: default
Impacted area Impact y/n
Hi Zoran,
ACK Not tested.
-AVM
On 8/16/2016 3:01 PM, Zoran Milinkovic wrote:
> osaf/services/saf/clmsv/clms/clms_imm.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>
> Fix string format for size_t type, so that 32-bit compilers can compile
> OpenSAF without errors.
>
>
Ack.
Thanks,
Praveen
On 11-Aug-16 2:03 PM, Vu Minh Nguyen wrote:
> osaf/services/saf/ntfsv/ntfs/NtfLogger.cc | 51 +-
> tests/ntfsv/tet_longDnObject_notification.c | 188
> +++-
> 2 files changed, 196 insertions(+), 43 deletions(-)
>
>
> Remove the part of code
Summary: clm: fix string format for size_t type [#1906]
Review request for Trac Ticket(s): 1906
Peer Reviewer(s): Mathi
Pull request to: Zoran
Affected branch(es): default(5.1)
Development branch: default(5.1)
Impacted area Impact y/n
Hi Zoran,
ACK tested.
-AVM
On 8/16/2016 1:31 PM, Zoran Milinkovic wrote:
> osaf/libs/common/clmsv/clmsv_enc_dec.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
>
> Add null-terminated string to the end of decoded string for SaNameT type.
>
> diff --git
Please review it by today.
Thanks
-Nagu
> -Original Message-
> From: Nagendra Kumar
> Sent: 04 August 2016 10:51
> To: hans.nordeb...@ericsson.com; Praveen Malviya;
> minh.c...@dektech.com.au; gary@dektech.com.au
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: [devel] [PATCH 1
On 15-Aug-16 5:05 PM, Long Nguyen wrote:
Hi Praveen,
Thanks for your suggestions.
Please see my comments marked with [Long[.
Best regards,
Long Nguyen.
On 8/12/2016 5:03 PM, praveen malviya wrote:
On 12-Aug-16 1:27 PM, Long Nguyen wrote:
Hi Praveen,
Actually, since Anders introduced
osaf/services/saf/amf/amfd/csi.cc | 6 --
osaf/services/saf/amf/amfd/csiattr.cc | 6 --
2 files changed, 8 insertions(+), 4 deletions(-)
This fixes various CSI related problems reported by Praveen in
https://sourceforge.net/p/opensaf/tickets/1642/#5579
Credit: Praveen
diff --git
Summary: amfd: fix various CSI related problems [#1642]
Review request for Trac Ticket(s): 1642
Peer Reviewer(s): AMF devs
Pull request to: <>
Affected branch(es): default
Development branch: default
Impacted area Impact y/n
This patch still has the problem
Bring SC-2 as standby ( With this patch ) & Brint SC-1 Active ( With out
this patch )
And run following test case on SC-2( With this patch node )
1) Init with general callback
2) Asynchrously opened ckpt
Hi Neelakanta,
Ack on all patches.
No need for sending the code on another review. They are all minor changes
mostly related on code-style, and not on functionality.
Thanks,
Zoran
-Original Message-
From: Neelakanta Reddy [mailto:reddy.neelaka...@oracle.com]
Sent: den 16 augusti 2016
Hi Zoran,
All the attribute definition will be moved to the top of the file.
The response for the remaining comments.
Thanks,
Neel.
On 2016/08/12 07:36 PM, Zoran Milinkovic wrote:
> Hi Neelakanta,
>
> Find my comments inline
>
> -Original Message-
> From: reddy.neelaka...@oracle.com
Hi Mathi,
I just sent the fix to the review.
Thanks,
Zoran
-Original Message-
From: A V Mahesh [mailto:mahesh.va...@oracle.com]
Sent: den 16 augusti 2016 08:37
To: Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: osafclmna[5375]: ER Exiting
Hi Zoran Milinkovic,
It
Summary: clm: fix decoding for SaNameT type [#1906]
Review request for Trac Ticket(s): 1906
Peer Reviewer(s): Mathi
Pull request to: Zoran
Affected branch(es): default(5.1)
Development branch: default(5.1)
Impacted area Impact y/n
osaf/libs/common/clmsv/clmsv_enc_dec.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
Add null-terminated string to the end of decoded string for SaNameT type.
diff --git a/osaf/libs/common/clmsv/clmsv_enc_dec.c
b/osaf/libs/common/clmsv/clmsv_enc_dec.c
---
Hi Hoang,
ACK tested with normal configuration .
Note : not created error SA_AIS_ERR_BAD_HANDLE.
-AVM
On 8/16/2016 12:15 PM, Hoang Vo wrote:
> osaf/services/saf/cpsv/cpd/cpd_init.c | 67
> ++-
> 1 files changed, 66 insertions(+), 1 deletions(-)
>
>
>
Hi Zoran,
will change OPENSAF_IMMSV_* to OPENSAF_IMM_* while pushing.
Thanks,
Neel.
On 2016/08/12 07:35 PM, Zoran Milinkovic wrote:
> Hi Neelakanta,
>
> In the bottom of the patch is next change:
> +#define OPENSAF_IMMSV_MAX_CLASSES "maxClasses"
> +#define OPENSAF_IMMSV_MAX_IMPLEMENTERS
Hi zoran,
will update while pushing the patch.
Thanks,
Neel.
On 2016/08/12 07:35 PM, Zoran Milinkovic wrote:
> Hi Neelakanta,
>
> Find the typo comment inline
>
> -Original Message-
> From: reddy.neelaka...@oracle.com [mailto:reddy.neelaka...@oracle.com]
> Sent: den 27 juli 2016 10:32
>
osaf/services/saf/cpsv/cpd/cpd_init.c | 67 ++-
1 files changed, 66 insertions(+), 1 deletions(-)
Problem:
---
cpd doesn't seem to currently recover from BAD_HANDLE when calling
saClmDispatch()
This is important if a node is promoted to a controller.
Summary: cpd: handle BAD_HANDLE from saClmDispatch [#1822]
Review request for Trac Ticket(s): #1822
Peer Reviewer(s): mahesh.va...@oracle.com; anders.wid...@ericsson.com
Pull request to: mahesh.va...@oracle.com
Affected branch(es): default
Development branch: default
I was starting SC-2 as Active
-AVM
On 8/16/2016 12:07 PM, A V Mahesh wrote:
> Hi Zoran Milinkovic,
>
> It seems some problem with thees patches :
>
> Opensaf is not comingup with error `SC-2 osafclmna[5375]: ER*SC-2m*
> is not a configured node` & ` SC-2 osafclmna[5375]: ER Exiting`
>
>
Hi Zoran Milinkovic,
It seems some problem with thees patches :
Opensaf is not comingup with error `SC-2 osafclmna[5375]: ER*SC-2m* is
not a configured node` & ` SC-2 osafclmna[5375]: ER Exiting`
=
changeset: 7855:bc669776cf7f
Dear Mahesh,
Thank you very much for your clarifying.
When other service did also, I will update and provide patch that don't use
new messages.
Thank you and best regards,
Hoang
-Original Message-
From: A V Mahesh [mailto:mahesh.va...@oracle.com]
Sent: Tuesday, August 16, 2016 11:29
34 matches
Mail list logo
