Hi Hoang,
ACK for [PATCH 4 of 8] assuming unrequited comment code will be removed
Note : tested default functionality , LONG DN functionality not tested
in full fledged
-AVM
On 8/18/2016 12:48 PM, Hoang Vo wrote:
> osaf/libs/common/cpsv/cpsv_evt.c | 439
>
Hi Hoang,
ACK for [PATCH 3 of 8] with following minor comment
I think API should return SA_AIS_ERR_TOO_BIG = 26 instead of
SA_AIS_ERR_INVALID_PARAM ( please sync-up with other service return
values ).
Note : tested default functionality , LONG DN functionality not tested
in full fledged
Hi Gary, Long,
Ack for all the patches.
Please update Readme and AMF Pr doc.
Thanks,
Praveen
On 22-Aug-16 6:23 AM, Gary Lee wrote:
> Hi Long
>
> ack (review only)
>
>
> On 19/08/2016 4:33 PM, Long HB Nguyen wrote:
>> osaf/services/saf/amf/amfnd/util.cc | 546
>>
Hi,
The callback looks like this:
typedef void
(*SaAmfProtectionGroupTrackCallbackT_4)(
const SaNameT *csiName,
SaAmfProtectionGroupNotificationBufferT_4 *notificationBuffer,
SaUint32T numberOfMembers,
SaAisErrorT error);
Inside this callback, application is supposed to call
Hi Praveen,
The problem with B.04.01 is the API:
saAmfProtectionGroupNotificationFree_4(SaAmfHandleT hdl,
SaAmfProtectionGroupNotificationT_4 *notification) does not have
numberOfItems.
Agent does not know how many element in *notification, each of element
can hide a longDn inside it.
Hi Minh,
SaAmfProtectionGroupNotificationBufferT_4() contains numberOfItems to
iterate over. In case of B.04.01, it should be simple as agent can call
direclty osaf_extended_name_free() during iteration inside
saAmfProtectionGroupNotificationFree_4(). So I think, only a for loop
which will
Dear Mahesh,
I would like to send my ideal about this.
Please consider it.
- I'm agree this modification will enhance writing performance.
- I checked opensaf-4.7.x both newest changeset (7886) and tested changeset
(7640) and found the same source code. So I think that this fixing will not
solve
Tested, Ack
Mathi.
> -Original Message-
> From: Anders Widell [mailto:anders.wid...@ericsson.com]
> Sent: Tuesday, July 19, 2016 7:33 PM
> To: Mathivanan Naickan Palanivelu
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: [PATCH 1 of 1] osaf: Fix name collision between OpenSAF CLC
Hi Long
ack (review only)
On 19/08/2016 4:33 PM, Long HB Nguyen wrote:
> osaf/services/saf/amf/amfnd/util.cc | 546
>
> 1 files changed, 0 insertions(+), 546 deletions(-)
>
>
> diff --git a/osaf/services/saf/amf/amfnd/util.cc
>
