Hi Minh and Praveen,
I have just sent out the patch (amfa: fix memory leak in protection group).
Please help to review. Thanks so much.
Best regards,
Long Nguyen.
On 8/26/2016 12:47 PM, minh.c...@dektech.com.au wrote:
> Hi Praveen,
>
> Long is preparing the patch adding sentinel element.
>
> Tha
Summary: amfa: fix memory leak in protection group [#1642]
Review request for Trac Ticket(s): #1642
Peer Reviewer(s): AMF devs
Pull request to: AMF maintainers
Affected branch(es): default
Development branch: default
Impacted area Impact y/n
-
osaf/libs/agents/saf/amfa/amf_agent.cc | 17 ++---
osaf/libs/agents/saf/amfa/ava_hdl.cc | 16 +++-
2 files changed, 21 insertions(+), 12 deletions(-)
diff --git a/osaf/libs/agents/saf/amfa/amf_agent.cc
b/osaf/libs/agents/saf/amfa/amf_agent.cc
--- a/osaf/libs/agents/s
Summary: imm: Remove the poll timeout in IMM testcases [#1970]
Review request for Trac Ticket(s): 1970
Peer Reviewer(s): Zoran, Neel
Pull request to:
Affected branch(es): 4.7, 5.0, 5.1
Development branch: 5.1
Impacted area Impact y/n
-
tests/immsv/common/immtest.c | 27 ++
tests/immsv/common/immtest.h |4 +
tests/immsv/implementer/test_SaImmOiCcb.c | 61 -
tests/immsv/implementer/test_saImmOiAugmentCcbInitialize.c | 47 +++-
tests/immsv/im
Hi,
I have gone through amfd traces. Also patch for NG seems to be ok but
some minor can be done.
As pointed by Minh, when whole SG is mapped in NG (say case a), AMFD
uses SG_ADMIN flow and SG admin state without exposing it to the user
through IMM for 2N model. In the other case when only one
Hi Praveen,
Long is preparing the patch adding sentinel element.
Thanks,
Minh
> Hi Minh,
>
> I think this is subject to interpretation. After finalize(), handle
> becomes invalid. So an application cannot call Free_4() to free any
> memory. In such a case, freeing any resources associated with t
Hi Minh,
I think this is subject to interpretation. After finalize(), handle
becomes invalid. So an application cannot call Free_4() to free any
memory. In such a case, freeing any resources associated with this
handle in finalize() seems to be ok.
Anyways freeing in finalize() can be postpon
Hi Praveen
Some initial comments below:
Thanks
Gary
diff --git a/osaf/libs/agents/saf/amfa/amf_agent.cc
b/osaf/libs/agents/saf/amfa/amf_agent.cc
--- a/osaf/libs/agents/saf/amfa/amf_agent.cc
+++ b/osaf/libs/agents/saf/amfa/amf_agent.cc
@@ -2812,6 +2812,7 @@
*/
SaAisErrorT saAmfInitialize_
Hi Praveen,
Just to confirm if I understand correctly the problem you mentioned in
saAmfFinalize(). As the specification says application should call
free()/Free_4() to release the allocated memory, if application does not
release memory then it's most likely application misuses API. Or do you
Hi,
The test failed because two reasons:
1. There are two places that nodegroup operation borrows 2N SG FSM, but
the AdminState of SG is not stored to IMM
saAmfSGAdminState = ng->saAmfNGAdminState;
...
su->sg_of_su->saAmfSGAdminState = SA_AMF_ADMIN_UNLOCKED;
This setting needs to
Further testing results:
Node group lock has resulted in SG unstable. Logs and configuration file
attached.
Configuration : SC-1, PL-3 and PL-4.
Steps:
1. Unlock SU1(on PL-3), SU2 and SU3 (Both on PL-4).
2. Create node group of PL-3 and PL-4:
3. Lock the node group.
amf-adm lock safAmfNodeGrou
Hi!
This is what the TIPC user documentation says about TIPC_DEST_DROPPABLE:
"This option governs the handling of messages sent by the socket if the
message cannot be delivered to its destination, either because the
receiver is congested or because the specified receiver does not exist.
If ena
Hi Praveen,
I think we need to come back a bit to non-headless feature.
The cluster init timer expiry ensures all nodes having MW SUs assigned
and node state are PRESENT. It's the unique entry point to non-ncs SU
assignment phase.
We also need to keep this principle in headless for #1725.
...
Hi Minh,
AMFA currently does not remember the allocated memory. It relies on the
application always to free the memory. In saAmfFinalize() also, it does
not free the memory. I think AMFA should remember memory by associating
it with handle because process which is starting PG tracking may not b
Hi HansN,
On 8/23/2016 5:22 PM, Hans Nordebäck wrote:
> Hi Mahesh,
>
> Yes, this is my understanding too, if TIPC_DROPPABLE = true tipc may drop
> messages silently, at receive sock buffer full condition, but do not return
> any ancillary message.
> If TIPC_DROPPABLE = false tipc may drop
Hi Vu,
Ack from me for PR doc.
I see this limitation still documented in README, but I think it's just
fine to be there (under 4.5). You can also make another paragraph to say
it's removed in 5.1.
I'm ok with both, since nothing is interesting in 5.1 to say.
Thanks,
Minh
On 25/08/16 12:39, Vu
Thanks Praveen,
Actually, the PR doc only contains the implementation detail part in
readme file.
I will remove the internal amfd and amfnd changes in the PR doc.
Best regards,
Long Nguyen.
On 8/25/2016 11:42 AM, praveen malviya wrote:
> Ack.
>
> I think implementation details should go in PR d
Hi Minh,
One minor correction is still needed.
node_up event comes very early. In case atleast one node up event has
come from all amfnds then AMFD stops Node sync timer very early even
before cluster timer has started:
if (rc_node_up == sync_nd_size) {
if (cb->node_
19 matches
Mail list logo
