[devel] [PATCH 0 of 1] Review Request for amfnd: avoid sending multiple node-switchover recovery request for same fault[#1935]

2016-09-01 Thread praveen . malviya
Summary:amfnd: avoid sending multiple node-switchover recovery request for same fault[#1935] Review request for Trac Ticket(s): #1935 Peer Reviewer(s): AMF devs Pull request to: <> Affected branch(es): ALL Development branch: <> Impacted area Impact y/n

[devel] [PATCH 1 of 1] amfnd: avoid sending multiple node-switchover recovery request for same fault[#1935]

2016-09-01 Thread praveen . malviya
osaf/services/saf/amf/amfnd/susm.cc | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) In the reported problem, AMFND sends multiple mode-switchover recovery request for same fault when nodeautorepair is disabled. Sometimes, amfnd is successful in sending the request but it may crash

Re: [devel] Immnd: maximum Ccbs limit 10000 has been reached very quickly

2016-09-01 Thread A V Mahesh
Hi Zoran, Thanks for the update , you are right ERR_NO_RESOURCES only justifiable if 1 IMM application concurrently holding 1 CCB`s ( active CCB), in current case agent is already finalized. By the way by roll backing which change set I can continue my testing ? -AVM On 9/1/2016

Re: [devel] Immnd: maximum Ccbs limit 10000 has been reached very quickly

2016-09-01 Thread Neelakanta Reddy
Hi Mahesh, The Active ccbs which are applied will be removed after 5 minutes not 5 seconds. Thanks, Neel. On 2016/09/01 06:02 PM, Neelakanta Reddy wrote: > Hi Mahesh, > > comments inline. > > On 2016/09/01 03:05 PM, A V Mahesh wrote: >> Hi Neel, >> >> On 9/1/2016 2:39 PM, Neelakanta Reddy

Re: [devel] Immnd: maximum Ccbs limit 10000 has been reached very quickly

2016-09-01 Thread Neelakanta Reddy
Hi Mahesh, comments inline. On 2016/09/01 03:05 PM, A V Mahesh wrote: > Hi Neel, > > On 9/1/2016 2:39 PM, Neelakanta Reddy wrote: >> Hi, >> >> I think this is not yet documented and will be documented. >> Try to increase the ccb limits and check. > Increasing the ccb limits will extend the issue

Re: [devel] Immnd: maximum Ccbs limit 10000 has been reached very quickly

2016-09-01 Thread Zoran Milinkovic
Hi Neelakanta, This is definitely a bug. When CCB is finalized, it's still shown as an active CCB. If you check number of CCBs with resource display functionality, you will see that number of CCBs is not decreasing. BR, Zoran -Original Message- From: Neelakanta Reddy

Re: [devel] Immnd: maximum Ccbs limit 10000 has been reached very quickly

2016-09-01 Thread Chani Srivastava
Thanks for clarification Zoran. Will raise it in sourceforge. -Chani On 9/1/2016 4:22 PM, Zoran Milinkovic wrote: > Hi Mahesh, > > This must be a new introduced bug with some of new patches. > I tested, and CCBs remain as active CCBs until they are cleared (after 5 > minutes). > Non active CCB

Re: [devel] Immnd: maximum Ccbs limit 10000 has been reached very quickly

2016-09-01 Thread Zoran Milinkovic
Hi Mahesh, This must be a new introduced bug with some of new patches. I tested, and CCBs remain as active CCBs until they are cleared (after 5 minutes). Non active CCB should not be considered as a live CCB. Thanks, Zoran -Original Message- From: A V Mahesh

Re: [devel] Immnd: maximum Ccbs limit 10000 has been reached very quickly

2016-09-01 Thread Chani Srivastava
Hi Neel, Here are my observations for the issue: *In 5.0 * * Number of IMMSV_MAX_CCB limits the number of Open Ccbs (Ccb which are not yet committed) * If the MAX_CCB is 1000, the below code works as ccbs are committing . The below code could be used to create 3 objects with

[devel] [PATCH 1 of 1] ntf: fix to keep MDS connection when last client finalize [#1895]

2016-09-01 Thread Canh Van Truong
osaf/libs/agents/saf/ntfa/ntfa_api.c | 1 + osaf/libs/agents/saf/ntfa/ntfa_util.c | 19 - tests/ntfsv/tet_saNtfFinalize.c | 36 -- 3 files changed, 43 insertions(+), 13 deletions(-) Currently, when finalizing the last client, ntfa

[devel] [PATCH 0 of 1] Review Request for ntf: fix to keep MDS connection when last client finalize [#1895]

2016-09-01 Thread Canh Van Truong
Summary: ntf: fix to keep MDS connection when last client finalize [#1895] Review request for Trac Ticket(s): #1895 Peer Reviewer(s): Minh, Lennart, Praveen Pull request to: Praveen Affected branch(es): 4.7.x, 5.0.x, 5.1.x, default Development branch: default

Re: [devel] Immnd: maximum Ccbs limit 10000 has been reached very quickly

2016-09-01 Thread A V Mahesh
Hi Neel, On 9/1/2016 2:39 PM, Neelakanta Reddy wrote: > Hi, > > I think this is not yet documented and will be documented. > Try to increase the ccb limits and check. Increasing the ccb limits will extend the issue for more number of CCB operations it will not reslove the issue . As far as A

[devel] [PATCH 0 of 1] Review Request for smfd: Merge rolling to singlestep procedures for several nodes [#1685]

2016-09-01 Thread Rafael Odzakow
Summary: Merge rolling to singlestep procedures for several nodes Review request for Trac Ticket(s): #1685 Peer Reviewer(s): lennart, reddy Pull request to: <> Affected branch(es): <> Development branch: <> Impacted area Impact y/n

[devel] [PATCH 1 of 1] smfd: Merge rolling to singlestep procedures for several nodes [#1685]

2016-09-01 Thread Rafael Odzakow
osaf/services/saf/smfsv/config/smfsv_classes.xml| 13 + osaf/services/saf/smfsv/smfd/Makefile.am|6 +- osaf/services/saf/smfsv/smfd/SmfCampState.cc| 126 +- osaf/services/saf/smfsv/smfd/SmfCampaign.cc | 77 ++-

Re: [devel] [PATCH 1 of 1] log: fix errors reported by cppcheck version 1.75 [#1985]

2016-09-01 Thread Vu Minh Nguyen
Ack Regards, Vu > -Original Message- > From: Canh Van Truong [mailto:canh.v.tru...@dektech.com.au] > Sent: Wednesday, August 31, 2016 1:34 PM > To: vu.m.ngu...@dektech.com.au; lennart.l...@ericsson.com; > mahesh.va...@oracle.com > Cc: opensaf-devel@lists.sourceforge.net > Subject: [PATCH

Re: [devel] Immnd: maximum Ccbs limit 10000 has been reached very quickly

2016-09-01 Thread Chani Srivastava
Hi, With current 5.1 OpenSAF changeset 7997 the issue is reproducible == Sep 1 12:16:52 OSAF-SC1 osafimmnd[27298]: NO Ccb 10002 COMMITTED (chaniTestClass) Sep 1 12:16:52 OSAF-SC1 osafimmnd[27298]: NO Ccb 10003 COMMITTED (chaniTestClass) Sep 1

Re: [devel] Immnd: maximum Ccbs limit 10000 has been reached very quickly

2016-09-01 Thread Neelakanta Reddy
Hi, can you verify the same with 5.1. /Neel. On 2016/09/01 12:58 PM, Chani Srivastava wrote: > Hi All, > > I verified this is a break in functionality. In OpenSAF 5.0 I tried > creating 15000 objects per CCB and it worked fine. > > = > Nov 26 15:21:17

Re: [devel] [PATCH 1 of 1] log: fix errors reported by cppcheck version 1.75 [#1985]

2016-09-01 Thread A V Mahesh
Hi Canh, ACK with following comment( not tested ). On 9/1/2016 12:06 PM, Canh Truong wrote: > [AVM] why string changed , what was the errors, reported by cppcheck ? > [Canh] No, this is not reported by cppcheck. Please accommodate this fix description/commit message , it will help to find out

Re: [devel] [PATCH 2 of 2] AMFND: Admin operation continuation if csi callback completes during headless [#1725 part 1] V1

2016-09-01 Thread praveen malviya
Hi Minh, Please see response inline with [Praveen] Thanks, Praveen On 31-Aug-16 11:19 AM, minh chau wrote: > Hi Praveen > > I think @admin_ng needs to be restore as well as > @ng_using_saAmfSGAdminState, since just found that @admin_ng check is > required in avd_node_down_appl_susi_failover(),

Re: [devel] Immnd: maximum Ccbs limit 10000 has been reached very quickly

2016-09-01 Thread Chani Srivastava
Hi All, I verified this is a break in functionality. In OpenSAF 5.0 I tried creating 15000 objects per CCB and it worked fine. = Nov 26 15:21:17 SCALE_SLOT-91 osafimmnd[24451]: NO Ccb 237 COMMITTED (chaniTestClass) Nov 26 15:21:17 SCALE_SLOT-91

Re: [devel] [PATCH 1 of 1] log: fix cppcheck with performance severity [#1975]

2016-09-01 Thread Canh Truong
Hi Mahesh, I run cppcheck with latest version 1.75. I got from: https://sourceforge.net/projects/cppcheck/files/cppcheck/1.75/ And build, then run with option --enable=performance. Regards, Canh. -Original Message- From: A V Mahesh [mailto:mahesh.va...@oracle.com] Sent: Thursday,

Re: [devel] [PATCH 1 of 1] log: fix errors reported by cppcheck version 1.75 [#1985]

2016-09-01 Thread Canh Truong
Hi Mahesh, Please see my comment inline. Regards, Canh. -Original Message- From: A V Mahesh [mailto:mahesh.va...@oracle.com] Sent: Thursday, September 01, 2016 10:59 AM To: Canh Van Truong; vu.m.ngu...@dektech.com.au; lennart.l...@ericsson.com Cc: opensaf-devel@lists.sourceforge.net