Re: [devel] [PATCH 1 of 1] amfd: fix amfd crash while dumping state [#1995]

Hi Praveen, ack, one comment below. /Thanks HansN On 09/08/2016 03:20 PM, praveen.malv...@oracle.com wrote: > osaf/services/saf/amf/amfd/imm.cc | 6 ++ > 1 files changed, 6 insertions(+), 0 deletions(-) > > > diff --git a/osaf/services/saf/amf/amfd/imm.cc >

Re: [devel] [PATCH 0 of 1] Review Request for AMF: Fix SG unstable from admin continuation of nodegroup after headless [#1987]

Hi Minh, I have started reviewing it. Thanks, Praveen On 08-Sep-16 11:45 AM, minh chau wrote: > Hi, > > Please help to review this ticket. > > Thanks, > Minh > > On 05/09/16 11:43, Minh Hon Chau wrote: >> Summary: AMF: Fix SG unstable from admin continuation of nodegroup >> after headless

[devel] [PATCH 0 of 1] Review Request for amfd: fix amfd crash while dumping state [#1995]

Summary: amfd: fix amfd crash while dumping state [#1995] Review request for Trac Ticket(s): #1995 Peer Reviewer(s): AMf devs Pull request to: <> Affected branch(es): default and 5.1 Development branch: <> Impacted area Impact y/n

[devel] [PATCH 1 of 1] amfd: fix amfd crash while dumping state [#1995]

osaf/services/saf/amf/amfd/imm.cc | 6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/osaf/services/saf/amf/amfd/imm.cc b/osaf/services/saf/amf/amfd/imm.cc --- a/osaf/services/saf/amf/amfd/imm.cc +++ b/osaf/services/saf/amf/amfd/imm.cc @@ -644,6 +644,12 @@ static

Re: [devel] [PATCH 0 of 1] Review Request for Review Request for smfd: Merge rolling to singlestep procedures for several nodes [#1685]

Hi Rafel, Reviewed and tested the patch. Ack with the following comments. comments: 1. The bt has to be corrected: Program terminated with signal 11, Segmentation fault. #0 0x004293c9 in SmfUpgradeCampaign::execute() () at SmfUpgradeCampaign.cc:802 802 SmfUpgradeCampaign.cc: No

Re: [devel] [PATCH 1 of 1] AMFND: Fix amfnd coredump if sc failover while shutting down [#2008]

ack, code review only/Thanks HansN On 09/08/2016 02:01 PM, Minh Hon Chau wrote: > osaf/libs/common/amf/include/amf_db_template.h | 11 +++ > osaf/services/saf/amf/amfnd/clc.cc | 6 ++ > osaf/services/saf/amf/amfnd/term.cc| 16 ++-- > 3

Re: [devel] [PATCH 1 of 1] log: assertion failed in log_stream_close [#1954]

Hi Lennart, Last time, before raising this ticket, I also question how can it happened but I have not yet found out the cause. I will push the ticket now, and will investigate the cause later. Regards, Vu > -Original Message- > From: Lennart Lund [mailto:lennart.l...@ericsson.com] >

[devel] [PATCH 0 of 1] Review Request for AMFND: Fix amfnd coredump if sc failover while shutting down [#2008]

Summary: AMFND: Fix amfnd coredump if sc failover while shutting down [#2008] Review request for Trac Ticket(s): 2008 Peer Reviewer(s): AMF devs Pull request to: <> Affected branch(es): 5.1, default Development branch: default Impacted area Impact y/n

[devel] [PATCH 1 of 1] AMFND: Fix amfnd coredump if sc failover while shutting down [#2008]

osaf/libs/common/amf/include/amf_db_template.h | 11 +++ osaf/services/saf/amf/amfnd/clc.cc | 6 ++ osaf/services/saf/amf/amfnd/term.cc| 16 ++-- 3 files changed, 19 insertions(+), 14 deletions(-) During cluster shutting down phase, if both

[devel] [PATCH 1 of 1] ntf: cluster rebooted with ntfd crashed on both controllers [#2006]

osaf/libs/agents/saf/ntfa/ntfa_api.c | 18 + osaf/libs/common/ntfsv/include/ntfsv_msg.h | 1 - osaf/libs/common/ntfsv/ntfsv_mem.c | 2 +- tests/ntfsv/tet_ntf_common.c | 5 +- tests/ntfsv/tet_saNtfNotificationSend.c| 92 ++ 5

[devel] [PATCH 0 of 1] Review Request for ntf: cluster rebooted with ntfd crashed on both controllers [#2006]

Summary: ntf: cluster rebooted with ntfd crashed on both controllers [#2006] Review request for Trac Ticket(s): #2006 Peer Reviewer(s): NTF maintainers Pull request to: <> Affected branch(es): all Development branch: default Impacted area Impact y/n

[devel] [PATCH 1 of 1] clm: keep additionalText and lengthAdditionalText consistant [#2012]

osaf/services/saf/clmsv/clms/clms_ntf.c | 12 ++-- 1 files changed, 10 insertions(+), 2 deletions(-) According to NTF AIS, `additionalText` and `lengthAdditionalText` must be consistant. But CLM did set an hard-code to `lengthAdditionalText`. This patch makes them consistancy. diff

[devel] [PATCH 0 of 1] Review Request for clm: keep additionalText and lengthAdditionalText consistant [#2012]

Summary: clm: keep additionalText and lengthAdditionalText consistant [#2012] Review request for Trac Ticket(s): #2012 Peer Reviewer(s): CLM Maintainers Pull request to: <> Affected branch(es): all Development branch: default Impacted area Impact y/n

Re: [devel] [PATCH 1 of 1] MDS: Log TIPC dropped messages [#1957]

Hi HansN, So far I was not successful in creating TIPC_ERR_OVERLOAD case , so I am planing to rebuilding `tipc.ko` with less OVERLOAD_LIMIT_BASE value of tipc. Currently I am working on priority open tickets on the 5.1.RC1 milestone, I will get back to you soon. -AVM On 9/8/2016 2:02 PM, Hans

[devel] [PATCH 1 of 1] amf: handle csi attributes using long dn APIs in assignment messages [#1993]

osaf/libs/common/amf/n2avamsg.c | 5 +- osaf/services/saf/amf/amfd/csiattr.cc | 1 + osaf/services/saf/amf/amfd/util.cc | 49 osaf/services/saf/amf/amfnd/comp.cc | 7 +--

[devel] [PATCH 0 of 1] Review Request for amf: handle csi attributes using long dn APIs in assignment messages [#1993]

Summary: amf: handle csi attributes using long dn APIs in assignment messages [#1993] Review request for Trac Ticket(s): #1993 Peer Reviewer(s): AMF devs. Pull request to: <> Affected branch(es): Default and 5.1 Development branch: <> Impacted area

Re: [devel] [PATCH 1 of 1] MDS: Log TIPC dropped messages [#1957]

Hi Mahesh, Any updates on this? /Thanks HansN -Original Message- From: A V Mahesh [mailto:mahesh.va...@oracle.com] Sent: den 1 september 2016 07:55 To: Hans Nordebäck Cc: opensaf-devel@lists.sourceforge.net; Anders Widell ;

Re: [devel] [PATCH 1 of 1] amfnd: send recovery request to amfd for term-failed su [#2003]

Ack. Thanks -Nagu > -Original Message- > From: Praveen Malviya > Sent: 06 September 2016 15:00 > To: hans.nordeb...@ericsson.com; Nagendra Kumar; > gary@dektech.com.au; minh.c...@dektech.com.au > Cc: opensaf-devel@lists.sourceforge.net > Subject: [PATCH 1 of 1] amfnd: send recovery

Re: [devel] [PATCH 0 of 1] Review Request for imm: Remove pthread_exit from IMM test [#1973]

Hi Hung, Reviewed the patch. Ack. /Neel. On 2016/08/26 04:14 PM, Hung Nguyen wrote: > Summary: imm: Remove pthread_exit from IMM test [#1973] > Review request for Trac Ticket(s): 1973 > Peer Reviewer(s): Zoran, Neel > Pull request to: > Affected branch(es): 4.7, 5.0, 5.1 > Development branch:

Re: [devel] [PATCH 0 of 1] Review Request for imm: Remove the poll timeout in IMM testcases [#1970]

Hi Hung, Reviewed and tested the patch. Ack. /Neel. On 2016/08/26 12:02 PM, Hung Nguyen wrote: > Summary: imm: Remove the poll timeout in IMM testcases [#1970] > Review request for Trac Ticket(s): 1970 > Peer Reviewer(s): Zoran, Neel > Pull request to: > Affected branch(es): 4.7, 5.0, 5.1 >

Re: [devel] [PATCH 0 of 1] Review Request for AMF: Fix SG unstable from admin continuation of nodegroup after headless [#1987]

Hi, Please help to review this ticket. Thanks, Minh On 05/09/16 11:43, Minh Hon Chau wrote: > Summary: AMF: Fix SG unstable from admin continuation of nodegroup after > headless [#1987] > Review request for Trac Ticket(s): 1987 > Peer Reviewer(s): AMF devs > Pull request to: <> > Affected

Re: [devel] [PATCH 1 of 1] amf: update mds version in main process[#1996]

ack, code review and tests run. /Thanks HansN On 09/07/2016 02:03 PM, praveen.malv...@oracle.com wrote: > osaf/services/saf/amf/amfd/csiattr.cc | 2 + > osaf/services/saf/amf/amfd/include/evt.h| 6 + > osaf/services/saf/amf/amfd/include/proc.h | 1 + >