Re: [devel] [PATCH 1 of 1] ntf: fix ntfa does not remove subscriber in subscriberNoList at finalize [#1978]

2016-10-05 Thread Canh Truong
Hi Praveen, What I understand about deadlock as below: When other API and saNtfFinalize() called in parallel, both take the ntfhandle by ncshm_take_hdl(), the cell->use_ct increase (and > 1). The saNtfFinalize() call ncshm_destroy_hdl() to destroy ntfhandle, but ncshm_destroy_hdl() will check

[devel] [PATCH 0 of 1] Review Request for smfd: handle failed si-swap of middleware [#1605]

2016-10-05 Thread Alex Jones
Summary: smfd: handle failed middleware si-swap Review request for Trac Ticket(s): 1605 Peer Reviewer(s): mathi, neel, lennart, rafael Pull request to: <> Affected branch(es): default, 5.1, 5.0 Development branch: <> Impacted area Impact y/n

[devel] [PATCH 0 of 1] Review Request for smf: reading of IMM longdn attribute at the camapign admin operation [#2087]

2016-10-05 Thread reddy . neelakanta
Summary:smf: reading of IMM longdn attribute at the camapign admin operation [#2087] Review request for Trac Ticket(s): 2087 Peer Reviewer(s): Lenart, Rafel Affected branch(es): 5.0.x, 5.1.x, default Development branch: default Impacted area Impact y/n

[devel] [PATCH 1 of 1] smf: reading of IMM longdn attribute at the camapign admin operation [#2087]

2016-10-05 Thread reddy . neelakanta
osaf/services/saf/smfsv/smfd/SmfCampaignInit.cc | 14 +- osaf/services/saf/smfsv/smfd/smfd_campaign_oi.cc | 13 - 2 files changed, 13 insertions(+), 14 deletions(-) Reading of IMM longdn atribute is changed from camapaign init to oi admin operation. with this each

Re: [devel] [PATCH 1 of 1] ntf: fix ntfa does not remove subscriber in subscriberNoList at finalize [#1978]

2016-10-05 Thread praveen malviya
Hi Canh, Please find one comment inline with [Praveen]. Thanks, Praveen On 28-Sep-16 9:05 AM, Canh Van Truong wrote: > osaf/libs/agents/saf/ntfa/ntfa_api.c | 2 + > osaf/libs/agents/saf/ntfa/ntfa_util.c| 68 > +++ >

[devel] [PATCH 0 of 1] Review Request for log: fix runtime log stream is deleted after restarting from headless [#2071]

2016-10-05 Thread Vu Minh Nguyen
Summary: log: fix saLogStreamOpen_2 returns SA_AIS_ERR_BAD_OPERATION during si-swap [#2093] Review request for Trac Ticket(s): #2093 Peer Reviewer(s): Lennart, Mahesh Pull request to: <> Affected branch(es): all Development branch: default Impacted area

[devel] [PATCH 1 of 1] log: fix saLogStreamOpen_2 returns SA_AIS_ERR_BAD_OPERATION during si-swap [#2093]

2016-10-05 Thread Vu Minh Nguyen
osaf/services/saf/logsv/lgs/lgs_amf.cc | 4 1 files changed, 4 insertions(+), 0 deletions(-) immOiHandle was not reset when changing roles, so during si-swap there was possibility for Open API to get BAD_OPERATION. Need to reset the handle after IMM OI implementer is cleared. diff --git

Re: [devel] [PATCH 1 of 1] log: fix logtest fails when run after immomtest [#2028]

2016-10-05 Thread Vu Minh Nguyen
Hi, The ticket number is wrong in the email subject, it should be #1989. #1989 was pushed. But not yet #2028. You meant #2028? It not yet ack from you & Lennart. Regards, Vu > -Original Message- > From: A V Mahesh [mailto:mahesh.va...@oracle.com] > Sent: Wednesday, October 5, 2016

Re: [devel] [PATCH 1 of 1] log: fix logtest fails when run after immomtest [#2028]

2016-10-05 Thread A V Mahesh
Hi Vu, Can you please push this ? -AVM On 9/20/2016 9:50 AM, A V Mahesh wrote: > ACK, > > Not tested. > > -AVM > > > On 9/13/2016 4:50 PM, Vu Minh Nguyen wrote: >>tests/logsv/tet_log_longDN.c | 131 >> +++--- >>1 files changed, 73 insertions(+), 58