Re: [devel] [PATCH 0 of 3] Review Request for log: implement SaLogFilterSetCallbackT and version handling V4 [#2146]

Hi Mahesh, The test case " logtest 1 10" and " logtest 1 11" are created for version handling. In standby node, it has new code for log agent (with #2146), that means that version handling in log agent have been added. The log agent check if minor version bigger than the agent support, it will

Re: [devel] [PATCH 0 of 1] Review Request for imm: Cleanup orphaned implementers and admowners when headless [#2309]

Hi Neel, The problem is, in immnd_proc_discard_other_nodes(), it fails to use immnd_client_node_getnext() to get the client_node associated to the OI that being discarded. The reason is the client_node has already been removed from cb->client_info_db when the client was killed. I had imm

Re: [devel] [PATCH 0 of 3] Review Request for log: implement SaLogFilterSetCallbackT and version handling V4 [#2146]

Hi Canh, I was jut testing Agent in-service upgrade , so I have following setup and run the New FilterSetCallback test case and i was expecting case should receive fail/not-supported , but they are getting succeed how ? -SC-2 ACTIVE Old Node ( LOG is old code with out #2146 patch ) -SC-1

[devel] [PATCH 3 of 3] imm: immnd changes for integrating IMM with CLMS [#1640] v2

src/imm/Makefile.am |5 +- src/imm/immnd/ImmModel.cc | 44 +++- src/imm/immnd/ImmModel.h |2 + src/imm/immnd/immnd_cb.h | 18 +++ src/imm/immnd/immnd_clm.c | 200 ++ src/imm/immnd/immnd_db.c | 125

[devel] [PATCH 2 of 3] imm: imm agent changes for integrating IMM with CLMS [#1640] v2

src/imm/agent/imma_cb.h | 11 +- src/imm/agent/imma_db.cc | 37 +++- src/imm/agent/imma_init.cc |2 + src/imm/agent/imma_oi_api.cc | 96 ++- src/imm/agent/imma_om_api.cc | 211 +++--- src/imm/agent/imma_proc.cc | 31

[devel] [PATCH 1 of 3] imm: README changes for integrating IMM with CLMS [#1640] v2

src/imm/README | 44 +++- 1 files changed, 43 insertions(+), 1 deletions(-) diff --git a/src/imm/README b/src/imm/README --- a/src/imm/README +++ b/src/imm/README @@ -2934,7 +2934,49 @@ Operation-id '1' invoked on the object:

[devel] [PATCH 0 of 3] Review Request for Integrate IMM service with CLM [#1640] V2

Summary: Integrate IMM service with CLM [#1640] V2 Review request for Trac Ticket(s): 1640 Peer Reviewer(s): Zoran, Hung Affected branch(es): default Development branch: default Impacted area Impact y/n Docs

Re: [devel] [PATCH 1 of 1] AMFND: Ensure su operational message synchronizes with component failover sequence [#2233]

Hi Minh, Please find my response inline with [Praveen]. Thanks, Praveen On 20-Feb-17 6:58 AM, minh chau wrote: > Hi Praveen, > > Thanks for your V2 patch, I have tested V2 in scenario of ticket #2233 > and #1902, it also can fix the problem. > Here we have 2 solutions: > - The one I sent for

Re: [devel] [PATCH 0 of 3] Review Request for Integrate IMM service with CLM [#1640]

Forgot to hg add the newly created file, will send the next version of the patch Thanks, Neel. On 2017/02/21 11:08 AM, reddy.neelaka...@oracle.com wrote: > Summary: Integrate IMM service with CLM [#1640] > Review request for Trac Ticket(s): 1640 > Peer Reviewer(s): Zoran, Hung > Affected

[devel] [PATCH 2 of 3] imm: imm agent changes for integrating IMM with CLMS [#1640]

src/imm/agent/imma_cb.h | 11 +- src/imm/agent/imma_db.cc | 37 +++- src/imm/agent/imma_init.cc |2 + src/imm/agent/imma_oi_api.cc | 96 ++- src/imm/agent/imma_om_api.cc | 211 +++--- src/imm/agent/imma_proc.cc | 31

[devel] [PATCH 3 of 3] imm: immnd changes for integrating IMM with CLMS [#1640]

src/imm/Makefile.am |5 +- src/imm/immnd/ImmModel.cc | 44 -- src/imm/immnd/ImmModel.h |2 + src/imm/immnd/immnd_cb.h | 18 ++ src/imm/immnd/immnd_db.c | 125 ++ src/imm/immnd/immnd_evt.c | 31

[devel] [PATCH 1 of 3] imm: README changes for integrating IMM with CLMS [#1640]

src/imm/README | 40 +++- 1 files changed, 39 insertions(+), 1 deletions(-) diff --git a/src/imm/README b/src/imm/README --- a/src/imm/README +++ b/src/imm/README @@ -2934,7 +2934,45 @@ Operation-id '1' invoked on the object:

Re: [devel] [PATCH 1 of 1] dtm: Append existing log file after a node restart [#2291]

Hi Anders Widell, As work around while pushing patch, Just consider to have condition either number of accumulated logs exceed some count ( say 10 ) or every 15 seconds for log server to flushes messages to disk. -AVM On 2/20/2017 9:02 AM, A V Mahesh wrote: > ACK, tested as well. > >

Re: [devel] [PATCH 1 of 1] msgd: only call saClmFinalize if CLM init fails [#2308]

Hi Alex, ACK Not tested. -AVM On 2/15/2017 2:12 AM, Alex Jones wrote: > src/msg/msgd/mqd_api.c | 53 > ++--- > 1 files changed, 28 insertions(+), 25 deletions(-) > > > If a node is hosting a msg queue, and the node is rebooted, it can take 20 >

Re: [devel] [PATCH 2 of 2] mds: Use the new base class Conf for reading the FQDN [#2267]

Ok , I hope this is documented in REAMED . ACK , tested. -AVM On 2/20/2017 4:38 PM, Anders Widell wrote: > We earlier introduced a new OpenSAF config object with the name > opensafConfigId=opensafGlobalConfig,safApp=OpenSAF, containing the > attribute opensafNetworkName. I think the

[devel] [PATCH 1 of 1] base: fix ncs_edp_sanamet for arrays [#2314]

src/base/ncs_saf_edu.h| 3 +++ src/base/saf_edu.c| 46 ++ src/msg/msgd/mqd_mbedu.c | 2 +- src/plm/common/plms_edu.c | 2 +- 4 files changed, 51 insertions(+), 2 deletions(-) PLM and MSG standby do not come up in 5.1.0. Both PLM

[devel] [PATCH 1 of 1] lgs: Add new multivalue attributes to configuration handler [#2258]

src/log/Makefile.am |5 +- src/log/apitest/imm_tstutil.c| 126 +++ src/log/apitest/imm_tstutil.h| 61 +++ src/log/apitest/logtest.h|2 +- src/log/apitest/saflogtest.c | 29 - src/log/apitest/tet_LogOiOps.c

Re: [devel] [PATCH 1 of 1] imm: Fix problems with removing coordinator role when cluster goes headless [#2296]

Hi Hung, Reviewed and tested the patch. No more zombie processes. Ack from me. Thanks, Zoran -Original Message- From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au] Sent: den 13 februari 2017 05:00 To: Zoran Milinkovic ; reddy.neelaka...@oracle.com

Re: [devel] [PATCH 0 of 1] Review Request for imm: Cleanup orphaned implementers and admowners when headless [#2309]

Hi Hung, The local implementers will be discarded in "immnd_proc_discard_other_nodes" while discarding clients. The implementers from the other node will be discarded in immModel_isolateThisNode. If the IMMD broadcast misses also this should be covered in either of the above. /Neel. On

Re: [devel] [PATCH 2 of 2] mds: Use the new base class Conf for reading the FQDN [#2267]

We earlier introduced a new OpenSAF config object with the name opensafConfigId=opensafGlobalConfig,safApp=OpenSAF, containing the attribute opensafNetworkName. I think the recommendation is to set this attribute to the same value as the domain name of the nodes in the cluster. regards, Anders

Re: [devel] [PATCH 1 of 1] imm: fix PBE coredump for double freeing memory [#2304]

Hi zoran, Reviewed the patch. Ack. /Neel. On 2017/02/13 06:10 PM, Zoran Milinkovic wrote: > src/imm/common/immpbe_dump.cc| 29 +++-- > src/imm/immpbed/immpbe_daemon.cc | 2 ++ > 2 files changed, 21 insertions(+), 10 deletions(-) > > > A static string variable

Re: [devel] [PATCH 2 of 2] mds: Use the new base class Conf for reading the FQDN [#2267]

Hi Anders Widell, On 2/20/2017 2:25 PM, Anders Widell wrote: > Yes, the HOSTNAME field of the log record should contain the fully > qualified domain name (i.e. the host name followed by the domain > name). See Section 6.2.4 in RFC 5424 where the HOSTNAME field is > described. > > I agree that

Re: [devel] [PATCH 0 of 1] Review Request for imm: Fix problems with removing coordinator role when cluster goes headless [#2296] v2

Hi Hung, Reviewed the patch. Ack. /Neel. On 2017/02/13 09:30 AM, Hung Nguyen wrote: > Summary: imm: Fix problems with removing coordinator role when cluster goes > headless [#2296] > Review request for Trac Ticket(s): 2296 > Peer Reviewer(s): Zoran, Neel > Pull request to: > Affected

Re: [devel] [PATCH 2 of 2] mds: Use the new base class Conf for reading the FQDN [#2267]

Yes, the HOSTNAME field of the log record should contain the fully qualified domain name (i.e. the host name followed by the domain name). See Section 6.2.4 in RFC 5424 where the HOSTNAME field is described. I agree that it could be confusing if the host name and the node name differ, but