Re: [devel] [PATCH 1/1] amfd: make auto repair restriction configurable [#2435]

Hi Nagu I ‘simulated’ a downgrade by loading the new AMF class / object files on a legacy AMF cluster. amfd will ignore the object and allow deletion of it and its class definition. For an upgrade, the object should be added in campInitAction. Thanks Gary On 28/4/17, 8:48 pm, "Nagendra Kumar"

Re: [devel] [PATCH 1/1] amfd: make auto repair restriction configurable [#2435]

Hi Gary, Have you tested downgrade scenarios ? I assume you have tested upgrade scenario. Thanks -Nagu > -Original Message- > From: praveen malviya > Organization: Oracle Corporation > Date: Wednesday, 26 April 2017 at 8:19 pm > To: gary

Re: [devel] [PATCH 1/1] smf: Attribute value handling in longDn applier is incorrect [#2442]

ACK, not tested. On 04/27/2017 03:10 PM, Lennart Lund wrote: > SMF has an IMM applier to track changes of attribute longDnsAllowed in > OpensafImm class. > Fix that the applier does not find the value if the list of attributes to be > handled in the > apply callback contains more than one

[devel] [PATCH 0/1] Review Request for amf: validate env variable format set in comptype and comp objects [#2409] V2

Summary: amf: validate env variable format set in comptype/comp objects [#2409] Review request for Ticket(s): 2409 Peer Reviewer(s): AMF devs Pull request to: AMF maintainers Affected branch(es): develop, release Development branch: ticket-2409 Base revision:

[devel] [PATCH 1/1] amf: validate env variable format set in comptype/comp objects [#2409]

Valid environment variable should have the format 'var=value'. AMF currently does not validate this format during CREATE CCBs for comptype and comp objects (MODIFY allowed for comp after #2255) related to saAmfxxxCmdEnv attribute. Besides, the existing validation in avnd_comp_clc_cmd_execute() is

Re: [devel] [PATCH 1/1] amfnd: Ignore second NCSMDS_DOWN [#2436]

Hi AMF maintainers, While waiting Mahesh checks whether another NCSMDS_DOWN(Vdest) should come 3 mins after headless, can we have a look at this patch? I think we need it to make AMFND safe. Thanks, Minh On 27/04/17 12:26, A V Mahesh wrote: > Hi Minh chau, > > On 4/26/2017 5:43 PM, minh chau

[devel] [PATCH 0/1] Review Request for base: Make pid file safe to read by rename it from temporary created file [#2432]

Summary: base: Make pid file safe to read by rename it from temporary created file [#2432] Review request for Ticket(s): 2432 Peer Reviewer(s): AndersW, HansN, Ramesh Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop, release Development branch:

Re: [devel] [PATCH 1/1] log: fix checkpoint dest_names in open stream request [#2434]

Hi Canh Ack Thanks Lennart > -Original Message- > From: Canh Van Truong [mailto:canh.v.tru...@dektech.com.au] > Sent: den 25 april 2017 15:29 > To: Lennart Lund ; Vu Minh Nguyen > ; mahesh.va...@oracle.com > Cc:

Re: [devel] [PATCH 1/1] log: fix checkpoint dest_names in open stream request [#2434]

Hi Vu, ACK. not tested. -AVM On 4/28/2017 1:27 PM, Vu Minh Nguyen wrote: > Hi Mahesh, > > Regarding your suggestion, I think we should do it in a separated ticket > that is re-organize headers/implementation files. > > How do you think? > > Regards, Vu > >> -Original Message- >> From:

Re: [devel] [PATCH 1/1] log: generate hash only if having destination name set [#2438]

Hi Vu ACK Thanks Lennart > -Original Message- > From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au] > Sent: den 26 april 2017 08:56 > To: Lennart Lund ; mahesh.va...@oracle.com; > Canh Van Truong > Cc:

Re: [devel] [PATCH 1/1] log: fix checkpoint dest_names in open stream request [#2434]

Hi Mahesh, Regarding your suggestion, I think we should do it in a separated ticket that is re-organize headers/implementation files. How do you think? Regards, Vu > -Original Message- > From: A V Mahesh [mailto:mahesh.va...@oracle.com] > Sent: Friday, April 28, 2017 4:56 AM > To:

Re: [devel] [PATCH 1/1] log: fix checkpoint dest_names in open stream request [#2434]

Hi Canh, The function `lgs_ckpt_stream_open` has a check on node status. Only do checkpoint if the current node status is ACTIVE. That check is removed from your patch. To make sure checkpoint should only be done on active node, I suggest adding that check in the beginning of your newly

Re: [devel] [PATCH 1/1] base: Blocking send causes AMF health check time-out [#2278]

Ack. regards, Anders Widell On 04/27/2017 03:55 PM, Hans Nordeback wrote: > --- > src/base/sysf_tmr.c | 20 +--- > 1 file changed, 17 insertions(+), 3 deletions(-) > > diff --git a/src/base/sysf_tmr.c b/src/base/sysf_tmr.c > index d4bd8de12..42679e103 100644 > ---

Re: [devel] [PATCH 1/1] base: Blocking send causes AMF health check time-out [#2278]

Ack with a comment. Please add.. m_NCS_UNLOCK() as below mentioned. + m_NCS_LOCK(_tcb.safe.enter_lock, NCS_LOCK_WRITE); if (clock_gettime(CLOCK_MONOTONIC, _start)) { perror("clock_gettime with MONOTONIC Failed \n"); m_NCS_UNLOCK(_tcb.safe.enter_lock,