Re: [devel] [PATCH 1/1] amfd: Fix compilation error with gcc version > 6.3 [#2577]

2017-09-11 Thread Gary Lee
Hi Hans Ack (review) Thanks Gary On 8/9/17, 10:39 pm, "Hans Nordeback" wrote: --- src/amf/amfd/sg_nway_fsm.cc | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/amf/amfd/sg_nway_fsm.cc

Re: [devel] [PATCH 1/1] amf: Fix amf_demo program compilation error [#2578]

2017-09-11 Thread Gary Lee
Hi Hans Ack (review) Thanks Gary On 8/9/17, 10:53 pm, "Hans Nordeback" wrote: --- tools/cluster_sim_uml/build_uml | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/cluster_sim_uml/build_uml b/tools/cluster_sim_uml/build_uml index

[devel] [PATCH 0/1] Review Request for imm: remove disconnected appliers [#2579]

2017-09-11 Thread Zoran Milinkovic
Summary: imm: remove disconnected appliers [#2579] Review request for Ticket(s): 2579 Peer Reviewer(s): Hung Pull request to: Zoran Affected branch(es): develop Development branch: ticket-2579 Base revision: 10a83558372bbeae8b2d09e0fefd55cbc11dbd5d Personal repository:

[devel] [PATCH 1/1] imm: remove disconnected appliers [#2579]

2017-09-11 Thread Zoran Milinkovic
When an applier is disconnected, it will be removed from the system after time period set in minApplierTimeout attribute in IMM object. If the time is set to 0, it will work as it works today, and it will never be removed from the system. The time set in minApplierTimeout attribute guarantees

Re: [devel] [PATCH 0/1] Review Request for imm: Do not update admo name from the after image when committing modification [#2576]

2017-09-11 Thread Hung Nguyen
Hi Anders, Thanks for the comments. I agree with you about that, that would be safer. I will send new solution to review. BR, Hung Nguyen - DEK Technologies From: Anders Bjornerstedt

[devel] [PATCH 1/1] imm: Do not update admo name from the after image when committing modification [#2576]

2017-09-11 Thread Hung Nguyen
Value of admo name in the after image may not be correct in some cases, but value of admo name in the before image (in sObjectMap) is always up to date. We should keep the admo name value of the before image when committing modification. --- src/imm/immnd/ImmModel.cc | 22 +++---