Re: [devel] [PATCH 1/1] log: fix log server fail to start with old IMM model [#2580]

2017-09-12 Thread Vu Minh Nguyen
Hi Lennart, Thanks for your comments. Below is the SaLogStreamConfig class description - result of `immlist -c SaLogStreamConfig`. If we collect attribute names based on `SA_IMM_ATTR_RUNTIME`, we will miss lot of LOG's interested attribute names. << SaLogStreamConfig - CONFIG >> safLgStrCfg :

Re: [devel] [PATCH 1/1] amfd: choose unlocked instantiable SU for instantiation [#2462]

2017-09-12 Thread minh chau
Hi Ravi, Minor comments in line. Thanks, Minh On 08/09/17 17:03, Ravi Sekhar wrote: --- src/amf/amfd/sgproc.cc | 23 +-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/src/amf/amfd/sgproc.cc b/src/amf/amfd/sgproc.cc index 6ca4261..0dbaa59 100644 ---

[devel] [PATCH 0/1] Review Request for log: fix log server fail to start with old IMM model [#2580] V2

2017-09-12 Thread Vu Minh Nguyen
Summary: log: fix log server fail to start with old IMM model [#2580] Review request for Ticket(s): 2580 Peer Reviewer(s): Lennart, Canh Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop, release Development branch: ticket-2580 Base revision:

[devel] [PATCH 1/1] log: fix log server fail to start with old IMM model [#2580]

2017-09-12 Thread Vu Minh Nguyen
LOG introduced the `saLogRecordDestination` attribute since OpenSAF 5.2 to handle the alternative destinations of log records, ticket [#2258]. During upgrade, if LOG server comes up before IMM model is updated to new one which has saLogRecordDestination in, LOG server will be crashed The solution

Re: [devel] [PATCH 1/1] amfd: harden completed and apply delete callbacks [#2566]

2017-09-12 Thread Gary Lee
Hi I will push this on Friday, with the changes suggested by Hans, if there are no more comments. Thanks Gary On 6/9/17, 2:19 pm, "Gary Lee" wrote: It is possible for an object to be deleted in IMM, before a standby SC finishes initilization. Now, if the

Re: [devel] [PATCH 1/1] log: fix log server fail to start with old IMM model [#2580]

2017-09-12 Thread Lennart Lund
Hi Vu, See attached diff for comments. Note: I found one possible error Thanks Lennart > -Original Message- > From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au] > Sent: den 12 september 2017 15:57 > To: Lennart Lund ; Canh Van Truong >

[devel] [PATCH 1/1] log: fix log server fail to start with old IMM model [#2580]

2017-09-12 Thread Vu Minh Nguyen
LOG introduced the `saLogRecordDestination` attribute since OpenSAF 5.2 to handle the alternative destinations of log records, ticket [#2258]. During upgrade, if LOG server comes up before IMM model is updated to new one which has saLogRecordDestination in, LOG server will be crashed The solution

[devel] [PATCH 0/1] Review Request for log: fix log server fail to start with old IMM model [#2580]

2017-09-12 Thread Vu Minh Nguyen
Summary: log: fix log server fail to start with old IMM model [#2580] Review request for Ticket(s): 2580 Peer Reviewer(s): *** LIST THE TECH REVIEWER(S) / MAINTAINER(S) HERE *** Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop, release Development branch:

Re: [devel] [PATCH 1/1] amf: Fix amf_demo program compilation error [#2578]

2017-09-12 Thread Ravi Sekhar Reddy Konda
Hi Hans, Ack Regards, Ravi - Original Message - From: hans.nordeb...@ericsson.com To: gary@dektech.com.au, ravisekhar.ko...@oracle.com Cc: opensaf-devel@lists.sourceforge.net, hans.nordeb...@ericsson.com Sent: Friday, September 8, 2017 6:23:28 PM GMT +05:30 Chennai, Kolkata, Mumbai,