Re: [devel] [PATCH 1/1] ntf: correct return code is returned [#2039]

2017-10-02 Thread Srinivas Mangipudy
Hi Minh, Please find below my comments inline. Thank you Srinivas -Original Message- From: minh chau [mailto:minh.c...@dektech.com.au] Sent: Thursday, September 28, 2017 6:49 AM To: Srinivas Cc: opensaf-devel@lists.sourceforge.net Subject: Re: [PATCH

[devel] [PATCH 0/1] Review Request for pyosaf: Invalid exception used in ImmObject (object.py) [#1410]

2017-10-02 Thread Hieu Nguyen
Summary: pyosaf: Invalid exception used in ImmObject (object.py) [#1410] Review request for Ticket(s): 1410 Peer Reviewer(s): Hans/Anders Pull request to: Hans Affected branch(es): develop Development branch: ticket-1410 Base revision: bc497981905f39aaa5b63cdf85b7557972650d94 Personal repository:

[devel] [PATCH 1/1] pyosaf: Invalid exception used in ImmObject (object.py) [#1410]

2017-10-02 Thread Hieu Nguyen
--- python/pyosaf/utils/immom/object.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python/pyosaf/utils/immom/object.py b/python/pyosaf/utils/immom/object.py index c2924d3..30cd63c 100644 --- a/python/pyosaf/utils/immom/object.py +++ b/python/pyosaf/utils/immom/object.py

Re: [devel] [PATCH 1/1] log: corrected parsing of command logtest with option -e [#2121]

2017-10-02 Thread Vu Minh Nguyen
Hi, > 1 file changed, 14 insertions(+), 26 deletions(-) > mode change 100644 => 100755 src/log/apitest/logtest.c Any reason of changing the file permission? Regards, Vu > -Original Message- > From: Srinivas [mailto:srinivas.mangip...@oracle.com] > Sent: Thursday, September 21, 2017

Re: [devel] [PATCH 1/1] log: corrected parsing of command logtest with option -e [#2121]

2017-10-02 Thread Lennart Lund
Ack /Lennart > -Original Message- > From: Srinivas [mailto:srinivas.mangip...@oracle.com] > Sent: den 21 september 2017 12:38 > To: Lennart Lund ; Vu Minh Nguyen > > Cc: opensaf-devel@lists.sourceforge.net; Srinivas >

Re: [devel] [PATCH 1/1] clm: Add user data in CLMSV_CLUSTER_JOIN_REQ message [#2590]

2017-10-02 Thread Anders Widell
Ack with comments: 1) Add a final comma to the end of the command-line parameter for the scale-out script. The reason why there should be a final comma is to make sure the script (which may be modified by the user) is backwards-compatible with future enhancements where we add more

Re: [devel] [PATCH 1/1] imm: Don't call exit() in IMM library [#2604]

2017-10-02 Thread Zoran Milinkovic
Hi Hung, Ack from me. Thanks, Zoran -Original Message- From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au] Sent: den 2 oktober 2017 08:47 To: Zoran Milinkovic Cc: opensaf-devel@lists.sourceforge.net; Hung Duc Nguyen

[devel] [PATCH 1/1] imm: Don't call exit() in IMM library [#2604]

2017-10-02 Thread Hung Nguyen
When PBE loses connection with IMMND, we don't call exit() in IMM library. Instead, we mark the handle as exposed and then PBE will exit when it fails to call saImmOmDispatch. --- src/imm/agent/imma_db.cc | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git

[devel] [PATCH 0/1] Review Request for imm: Dont call exit() in IMM library [#2604]

2017-10-02 Thread Hung Nguyen
Summary: imm: Don't call exit() in IMM library [#2604] Review request for Ticket(s): 2604 Peer Reviewer(s): Zoran Pull request to: Affected branch(es): develop, release Development branch: ticket-2604 Base revision: ffbeba61513e28ce862eaa735ed75e8243f881b8 Personal repository: