Re: [devel] [PATCH 1/1] amfd: Add retry mechanism for ClmTrackStart/Stop as job queue [#2631]

Hi Minh, I am fine with the patch, but have couple of queries, please see my comments inline Regards, Ravi -Original Message- From: Minh Chau [mailto:minh.c...@dektech.com.au] Sent: Friday, October 20, 2017 4:06 AM To: hans.nordeb...@ericsson.com; ravisekhar.ko...@oracle.com;

Re: [devel] [PATCH 0/1] Review Request for pyosaf: Create a pylint makefile target for pyosaf V2 [#2636]

Ack with comment: add /python/pylint.html to .gitignore regards, Anders Widell On 10/23/2017 02:40 PM, Hans Nordeback wrote: Summary: pyosaf: Create a pylint makefile target for pyosaf V2 [#2636] Review request for Ticket(s): 2636 Peer Reviewer(s): AndersW, Srinivas, Nguyen Pull request to:

[devel] [PATCH 0/1] Review Request for imm: immxml-merge tool taking long time with huge count of classes, objects [#2663]

Summary: imm: immxml-merge tool taking long time with huge count of classes, objects [#2663] Review request for Ticket(s): 2663 Peer Reviewer(s): zoran.milinko...@ericsson.com Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch:

[devel] [PATCH 1/1] imm: immxml-merge tool taking long time with huge count of classes, objects [#2663]

Instead of writing as string the new changes write the data as objects in to a merged file. --- src/imm/tools/immxml-merge | 54 +++--- 1 file changed, 27 insertions(+), 27 deletions(-) diff --git a/src/imm/tools/immxml-merge b/src/imm/tools/immxml-merge

Re: [devel] [PATCH 1/1] smfd: after cluster reboot, don't re-execute a campaign which has already completed [#2648]

NACK I bumped into a  issue. 1. start a campaign 2. complete campaign (not commited yet) 3. cluster reboot or opensafd restart on all nodes 4. rollback for campaign fails with:     osafsmfd[1288]: ER Failed to rollback campaign, campaign not executing On 10/31/2017 12:46 PM, Lennart

Re: [devel] [PATCH 1/1] smfd: after cluster reboot, don't re-execute a campaign which has already completed [#2648]

Ack Thanks Lennart > -Original Message- > From: Alex Jones [mailto:alex.jo...@genband.com] > Sent: den 25 oktober 2017 20:21 > To: vijay@oracle.com; Lennart Lund ; > Rafael Odzakow > Cc: opensaf-devel@lists.sourceforge.net;

[devel] [PATCH 1/1] tools: Fix pylint and pep8 issues for tools written in Python [#2664]

Fix pylint and pep8 issues for the following Python files: ./tools/devel/dot/trace2dot ./tools/devel/review/patch-tokenize.py ./src/imm/tools/immxml-merge ./src/imm/tools/immxml-validate ./src/imm/tools/baseimm.py --- src/imm/tools/baseimm.py | 376 ---

[devel] [PATCH 0/1] Review Request for tools: Fix pylint and pep8 issues for tools written in Python [#2664]

Summary: tools: Fix pylint and pep8 issues for tools written in Python [#2664] Review request for Ticket(s): 2664 Peer Reviewer(s): Hans Nordeback, Srinivas Mangipudy, Quyen Dao Pull request to: Hans Nordeback Affected branch(es): develop Development branch: ticket-2664 Base revision:

Re: [devel] [PATCH 1/1] clm: wrapper CLM APIs with try_again handle inside [#2634]

Hi Vu, I think it would be good if we can align this with the style of the Pyhton decorators in pyosaf/utils, now there is a lot of redundant code and it should be possible to have e.g. one C++ object for each function where just the function pointer is unique and the code is shared/common.

[devel] [PATCH 0/1] Review Request for fix logtest 4 56 fail because egrep log file fail [#2662]

Summary: log: fix logtest 4 56 fail because egrep log file fail [#2662] Review request for Ticket(s): 2662 Peer Reviewer(s): Lennart, Vu Pull request to: Vu Affected branch(es): develop Development branch: ticket-2662 Base revision: 85f1d74d9c9bced41287d9e9021c13a862cd72b4 Personal repository:

[devel] [PATCH 1/1] log: fix logtest 4 56 fail because egrep log file fail [#2662]

In test case logtest 4 56, it verifies that whether written log file format is reflected correctly. It finds and checks the log file that has been closed (FILENAME_MMDD_HHMMSS_MMDD_HHMMSS.log). But sometimes the log file has not been closed successfully due to timeout reason, this cause