Re: [devel] [PATCH 1/1] base: create generic try-again handling decorator for AIS APIs [#2702]

Hi Vu,  I think it would be good if we can use the policy pattern for the retry, I reworked my previous sample a bit: #include #include #include #include // only to illustrate, the existing SAF C functions with some dummy arguments #include extern "C" int saImmOmInitialize(int i) {  

[devel] [PATCH 0/1] Review Request for ntf: fix ntfd remove client in standby node while not finalize in active node [#2705]

Summary: ntf: fix ntfd remove client in standby node while not finalize in active node [#2705] Review request for Ticket(s): 2705 Peer Reviewer(s): Minh Pull request to: Minh Affected branch(es): develop, release Development branch: ticket-2705 Base revision:

[devel] [PATCH 1/1] ntf: fix ntfd remove client in standby node while not finalize in active node [#2705]

The issue happen because the clients are removed in both active and standby node when getting NCSMDS_DOWN event. In standby node, ntfd get NCSMDS_DOWN event is slower than next initialize request. This cause the ntfd will removed all client from data base including new client of next initialze.

Re: [devel] [PATCH 1/1] base: create generic try-again handling decorator for AIS APIs [#2702]

Thanks Hans and Anders for your good comments. The updated patch is just sent out. Please help to have a look. Thanks a lot! Regards, Vu > -Original Message- > From: Hans Nordebäck [mailto:hans.nordeb...@ericsson.com] > Sent: Thursday, November 30, 2017 1:07 PM > To: Anders Widell

[devel] [PATCH 0/1] Review Request for base: create generic try-again handling decorator for AIS APIs [#2702] V3

Summary: base: create generic try-again handling decorator for AIS APIs [#2702] Review request for Ticket(s): 2702 Peer Reviewer(s): Hans, Anders Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-2702 Base revision:

[devel] [PATCH 1/1] base: create generic try-again handling decorator for AIS APIs [#2702]

Make generic C++ decorator for handling SA_AIS_ERR_TRY_AGAIN return code of AIS APIs. --- src/ais/Makefile.am| 5 +- src/ais/try_again_decorator.h | 111 + src/base/Makefile.am | 4 +-

Re: [devel] [PATCH 1/1] base: create generic try-again handling decorator for AIS APIs [#2702]

agree, constexpr should be fine. /HansN -Original Message- From: Anders Widell Sent: den 30 november 2017 13:05 To: Hans Nordebäck ; Vu Minh Nguyen Cc: opensaf-devel@lists.sourceforge.net Subject: Re: [PATCH 1/1] base: create

Re: [devel] [PATCH 1/1] base: create generic try-again handling decorator for AIS APIs [#2702]

I have two comments: 1) I think this should be put under src/ais (but not src/ais/include) instead of putting it in src/base. 2) Could you think about if it is possible to make the retry time and interval constexpr? regards, Anders Widell On 11/30/2017 01:01 PM, Hans Nordebäck wrote:

Re: [devel] [PATCH 1/1] base: create generic try-again handling decorator for AIS APIs [#2702]

Hi Vu, please see some comments inlined below/Regards HansN On 11/28/2017 02:13 PM, Vu Minh Nguyen wrote: Make generic C++ decorator for handling SA_AIS_ERR_TRY_AGAIN return code of AIS APIs. --- src/base/Makefile.am | 5 +-

Re: [devel] [PATCH 1/1] msgd: fix double delete of node info [#2712]

Hi Alex, Ack, Code review only. Thank you Srinivas -Original Message- From: Alex Jones [mailto:alex.jo...@genband.com] Sent: Thursday, November 30, 2017 1:14 AM To: Srinivas Mangipudy Cc: opensaf-devel@lists.sourceforge.net; Alex Jones