[devel] [PATCH 1/1] pyosaf: refactor IMM utils [#2683]

2017-12-05 Thread Hieu Nguyen
+ improve OI utils use a separate instance OM agent + refactor OM utils with Ccb inheritace OmAgent, rename some classes... --- python/pyosaf/utils/immoi/__init__.py| 531 +++ python/pyosaf/utils/immoi/agent.py | 473 +++

[devel] [PATCH 0/1] Review Request for pyosaf: refactor IMM utils [#2683]

2017-12-05 Thread Hieu Nguyen
Summary: pyosaf: refactor IMM utils [#2683] Review request for Ticket(s): 2683 Peer Reviewer(s): Hans, Anders, Sir Pull request to: Hans or Anders Affected branch(es): develop Development branch: ticket-2683 Base revision: 9ab54933456632260be87c2c763bd36b1ab7e5d2 Personal repository:

Re: [devel] [PATCH 1/1] ntf: fix ntfd remove client in standby node while not finalize in active node [#2705]

2017-12-05 Thread Minh Hon Chau
Hi Canh, I got a build error with 32 bit src/ntf/ntfd/ntfs_com.c: In function ‘sendNtfaDownUpdate’: src/ntf/ntfd/ntfs_com.c:562:2: error: format ‘%ld’ expects argument of type ‘long int’, but argument 6 has type ‘MDS_DEST’ [-Werror=format=] TRACE_ENTER2("mdsDest: %ld", mdsDest); ^ cc1: all

Re: [devel] [PATCH 1/1] osaf: add /sbin/shutdown to sudoers file in 00-README.conf [#2729]

2017-12-05 Thread Hans Nordebäck
Ack, review only/Thanks HansN -Original Message- From: Zoran Milinkovic Sent: den 5 december 2017 15:04 To: Hans Nordebäck Cc: opensaf-devel@lists.sourceforge.net; Zoran Milinkovic Subject: [PATCH 1/1] osaf: add

[devel] [PATCH 1/1] osaf: add /sbin/shutdown to sudoers file in 00-README.conf [#2729]

2017-12-05 Thread Zoran Milinkovic
/sbin/shutdown is added to /etc/sudoers for the configuration steps in 00-README.conf --- 00-README.conf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/00-README.conf b/00-README.conf index 2a7ce96..5de2862 100644 --- a/00-README.conf +++ b/00-README.conf @@ -21,7 +21,7 @@

[devel] [PATCH 0/1] Review Request for osaf: add shutdown to sudoers file in 00-README.conf [#2729]

2017-12-05 Thread Zoran Milinkovic
Summary: osaf: add /sbin/shutdown to sudoers file in 00-README.conf [#2729] Review request for Ticket(s): 2729 Peer Reviewer(s): Vu, Hans Pull request to: Zoran Affected branch(es): develop Development branch: ticket-2729 Base revision: 924aa6e5046621c2c299f22d1943b8f1b0148b4a Personal repository:

[devel] [PATCH 1/1] smf: Fix handling of MDS events in smfnd [#2723]

2017-12-05 Thread Lennart Lund
The global smfd_dest (in cd struct) shall be restored with MDS event NCSMDS_UP and NCSMDS_NEW_ACTIVE (is set to 0 with event NCSMDS_DOWN) --- src/smf/smfnd/smfnd_mds.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/smf/smfnd/smfnd_mds.c b/src/smf/smfnd/smfnd_mds.c

[devel] [PATCH 0/1] Review Request for smf: Fix handling of MDS events in smfnd [#2723]

2017-12-05 Thread Lennart Lund
Summary: smf: Fix handling of MDS events in smfnd [#2723] Review request for Ticket(s): 2723 Peer Reviewer(s): rafael.odza...@ericsson.com Pull request to: Affected branch(es): develop Development branch: ticket-2723 Base revision: d54303925f86813c5c2fa1103f3c8ed841488145 Personal repository:

Re: [devel] [PATCH 1/1] smf: SMF created a CCB to create smfRollbackElement object, but CCB was aborted due to IMM [#2676]

2017-12-05 Thread Rafael Odzakow
Resending my question. Also to be clear, the retry loops are nested, it does not seem there is a reason for it. On mån, 2017-11-27 at 15:36 +0100, Rafael Odzakow wrote: SmfCampaignWrapup::executeCampComplete() is calling SmfImmCcbAction. So looks like a double retry spread out across two

Re: [devel] [PATCH 1/1] smf: SMF created a CCB to create smfRollbackElement object, but CCB was aborted due to IMM [#2676]

2017-12-05 Thread Syam Prasad Talluri
Hi Rafael, As you rightly pointed, we have just published a patch by removing the retry from SmfCampaignWrapup::executeCampComplete and added retires only in SmfImmCcbAction::execute. We have thoroughly tested it. Thanks, Syam. -Original Message- From: Rafael Odzakow

[devel] [PATCH 1/1] smf: SMF created a CCB to create smfRollbackElement object, but CCB was aborted due to IMM [#2676]

2017-12-05 Thread Vijay Roy
Handling ERROR_EXIST in smfRollbackElement creation and handling TRY_AGAIN in immCCBOperations. --- src/smf/smfd/SmfCampaignWrapup.cc | 28 +++- src/smf/smfd/SmfUpgradeAction.cc | 26 +++--- 2 files changed, 26 insertions(+), 28 deletions(-) diff

[devel] [PATCH 0/1] Review Request for smf: SMF created a CCB to create smfRollbackElement object, but CCB was aborted due to IMM [#2676]

2017-12-05 Thread Vijay Roy
Summary: smf: SMF created a CCB to create smfRollbackElement object, but CCB was aborted due to IMM [#2676] Review request for Ticket(s): 2676 Peer Reviewer(s): rafael.odza...@ericsson.com Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development