Re: [devel] [PATCH 0/1] Review Request for log: explicit constructors and use fix arrays of char [#2782]

Hi Vu, Ack with comments. See attached diff Thanks Lennart > -Original Message- > From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au] > Sent: den 8 februari 2018 11:31 > To: Lennart Lund ; Canh Van Truong > > Cc:

[devel] [PATCH 0/1] Review Request for log: explicit constructors and use fix arrays of char [#2782]

Summary: log: explicit constructors and use fix arrays of char [#2782] Review request for Ticket(s): 2782 Peer Reviewer(s): Lennart, Canh Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-2782 Base revision:

[devel] [PATCH 1/1] log: explicit constructors and use fix arrays of char [#2782]

Make ScopeData::LogClientData and ScopeData::LogStreamInfoData constructors explicit, and use fix arrray of chars for callers (mainly for debug) instead of constant pointer to __func__. --- src/log/agent/lga_agent.cc | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-)

Re: [devel] Review Request for doc: update overview PR for split brain prevention with consensus service [#64]

See my comments inline, marked AndersW> regards, Anders Widell On 02/08/2018 10:36 AM, Ravi Sekhar Reddy Konda wrote: Hi Gary, Have query regarding quorum selection when raft servers are external to the OpenSAF Cluster In the document we are saying "The consensus service uses quorum to

Re: [devel] Review Request for doc: update overview PR for split brain prevention with consensus service [#64]

Hi Gary, Have query regarding quorum selection when raft servers are external to the OpenSAF Cluster In the document we are saying "The consensus service uses quorum to prevent state changes in network partitions that don't include more than half of the nodes in the cluster" => This is

Re: [devel] [PATCH 1/1] amf: validate env variable format set in comptype/comp objects [#2409]

Hi Gary, Thank you for your comments. Please see my corresponding answers below, marked with [Nguyen]. Thanks, Nguyen On 2/7/2018 11:30 AM, Gary Lee wrote: Hi Nguyen Some comments below marked with [GL]. Thanks Gary On 6/2/18, 6:35 pm, "Nguyen Luu" wrote: