Re: [devel] [PATCH 1/1] pyosaf: Refactor NTF samples to make use of new pyosaf utils [#2707]

Hi Hans, Please help me review this patch whenever possible for you. It has been on review for months. Thanks, Nguyen On 12/20/2017 3:31 PM, Nguyen Luu wrote: - Refactor the ntfsend and ntfsubscribe python samples to make use of the new pyosaf utils implementation of enhancement ticket

[devel] [PATCH 1/1] amfa: Fix api internal check to avoid fatal mutex unlock [#2548]

Current check for the required setting of the SA_AMF_COMPONENT_NAME env variable in some amf api's (ComponentRegister, QuiescingComplete) would crash the invoking process if that env variable was missed to be set for some reason, as the agent lib tries, during cleanup, to unlock a mutex which it

[devel] [PATCH 0/1] Review Request for amfa: Fix api internal check to avoid fatal mutex unlock [#2548]

Summary: amfa: Fix api internal check to avoid fatal mutex unlock [#2548] Review request for Ticket(s): 2548 Peer Reviewer(s): AMF maintainers Pull request to: Gary Lee, Hans Nordeback Affected branch(es): develop, release Development branch: ticket-2548 Base revision:

Re: [devel] [PATCH 2/2] imm: return correct error code when working on more than 10000 objects [#2359]

Hi Srinivas, Ack from my side. Thanks, Vu > -Original Message- > From: srinivas [mailto:srinivas.mangip...@oracle.com] > Sent: Thursday, March 1, 2018 4:57 PM > To: vu.m.ngu...@dektech.com.au; zoran.milinko...@ericsson.com > Cc: opensaf-devel@lists.sourceforge.net; srinivas >

Re: [devel] [PATCH 0/1] Review Request for log: fix log agent may crash after recovery fails [#2670]

Hi Lennart, Please see my reply comment [Canh1] in the attachment. Thanks Canh -Original Message- From: Lennart Lund [mailto:lennart.l...@ericsson.com] Sent: Monday, March 5, 2018 7:40 PM To: Canh Van Truong ; Vu Minh Nguyen ;

Re: [devel] [PATCH 0/4] Review Request for ntf: handle try again for ntftest [#2766]

Hi Canh, ack from me (code review). Thanks, Minh On 28/02/18 17:45, Canh Van Truong wrote: Summary: ntf: handle try again for ntftest [#2766] Review request for Ticket(s): 2766 Peer Reviewer(s): Minh Pull request to: Minh Affected branch(es): develop, release Development branch: ticket-2766

Re: [devel] [PATCH 1/1] cpnd: Correct duration of cpnd_tmr_start in cpnd_proc_update_remote [#2787]

Hi Hoa, When I run your new test without the change in ckptnd, it passes. Shouldn't it fail? Alex From: Hoa Le Sent: Thursday, March 1, 2018 2:45:32 AM To: alex.jo...@genband.com; ravisekhar.ko...@oracle.com Cc:

Re: [devel] [users] Errors in running OpenSaf 5.3 in a Ubuntu VM

Hi Perhaps you just need to run ldconfig. Gary On 06/03/18 08:19, Feng Xie wrote: Hi, I am new in using OpenSAF. I encountered an error in running the latest OpenSaf software in a Ubuntu Linux VM. I would appreciate if somebody can provide some hint on this issue in specific and some

Re: [devel] [PATCH 0/1] Review Request for log: fix log agent may crash after recovery fails [#2670]

Hi Canh, I have added some new comments. See [Lennart1] in the attached .diff Note that this patch contains all comments so I shall be applied alone, not on top of the other comment patches Thanks Lennart > -Original Message- > From: Canh Van Truong

Re: [devel] [PATCH 1/1] nid: Delete generated node_id file when stopping OpenSAF [#2789]

Ack, review only/Thanks HansN -Original Message- From: Anders Widell Sent: den 27 februari 2018 10:54 To: Hans Nordebäck Cc: opensaf-devel@lists.sourceforge.net; Anders Widell Subject: [PATCH 1/1] nid: Delete generated node_id

Re: [devel] [PATCH 1/1] dtm: change trace config var name to _PATHNAME [#2792]

Hi Vu, I updated OpenSAF_IMMsv_PR.odt and the document is at: https://sourceforge.net/p/opensaf/documentation/ci/default/tree/OpenSAF_IMMSv_PR.odt Can you please review. Thank you Srinivas -Original Message- From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au] Sent: Thursday,

Re: [devel] [PATCH 1/1] amf: do not dereference null pointer [#2791]

Hi Gary, ack review only. (Strange that *o_msg is nullptr when rc is NCSCC_RC_SUCCESS, but in mcm_pvt_normal_svc_sndrsp if e.g. this send times out in mds_mcm_time_wait it seems NCSCC_RC_SUCCESS may be returned? /Regards HansN On 03/01/2018 06:32 AM, Gary Lee wrote: Callers of