Re: [devel] [PATCH 1/1] mds: Correct timing issues in mdstest [#2798]

2018-04-23 Thread Hoa Le
Hi Lennart, Thanks for your comments on the ticket, I will update the description of tet_mds_retrieve_for_change() as your suggestion in the next version of the patch. Just have a concern with the comment about sleep(1) in test case tet_svc_subscr_VDEST_10 (and other). I agree that we

Re: [devel] [PATCH 1/1] amfd: if rootCauseEntity is PLM entity don't engage lock/lock-in [#2835]

2018-04-23 Thread Hans Nordebäck
Hi Alex, Ack, code review and legacy tests run. I added some comments below. /Thanks HansN From: Alex Jones [mailto:ajo...@rbbn.com] Sent: den 23 april 2018 16:05 To: Hans Nordebäck ; Gary Lee ; ravisekhar.ko...@oracle.com Cc:

Re: [devel] [PATCH 1/1] amfd: if rootCauseEntity is PLM entity don't engage lock/lock-in [#2835]

2018-04-23 Thread Alex Jones
My comments inline: Alex On 04/20/2018 04:00 AM, Hans Nordeback wrote: __ NOTICE: This email was received from an EXTERNAL sender __ Hi Alex,

Re: [devel] [PATCH 1/1] imm: sPbeRtMutations is updated even when validation for duplicate values fails [#2422]

2018-04-23 Thread Vu Minh Nguyen
Hi Danh, Ack and tested from me. Thanks. Regards, Vu > -Original Message- > From: Danh Vo > Sent: Thursday, March 15, 2018 5:54 PM > To: ravisekhar.ko...@oracle.com; hans.nordeb...@ericsson.com; > zoran.milinko...@ericsson.com; anders.wid...@ericsson.com; >