Re: [devel] [PATCH 0/1] Review Request for smfd: Remove duplicate DU, AU on SU or comp level in one-step upgrade V2 [#2227]

Hi Nguyen See my comments [Lennart] in the attached diff file. Can be applied on your review repository. Thanks Lennart > -Original Message- > From: Nguyen Luu [mailto:nguyen.tk@dektech.com.au] > Sent: den 8 maj 2018 04:19 > To: Lennart Lund ;

Re: [devel] [PATCH 1/1] imm: inform status to NID before exit during start-up phrase [#2845]

Hi Vu, Ack review only with one comment. If the exit() is called after immnd_ackToNid() the fifo monitoring in nodeinit.cc will be activated. I think you should remove the exit(). /Thanks HansN -Original Message- From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au] Sent: den 3 maj

[devel] [PATCH 1/1] imm: fix PBE terminated when adding data with duplicated values [#2422]

When adding value set which has duplicated values into non-pure runtime attribute (cached or persistent), the first loop (doIt=0) does not validate in the correct way. It tries to detect duplicated values between current values and provided values without updating current values. So the current

[devel] [PATCH 0/1] Review Request for imm: fix PBE terminated when adding data with duplicated values [#2422]

Summary: imm: fix PBE terminated when adding data with duplicated values [#2422] Review request for Ticket(s): 2422 Peer Reviewer(s): Ravi, Anders, Hans, Lennart, Vu Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-2422 Base

Re: [devel] [PATCH 1/1] imm: sPbeRtMutations is updated even when validation for duplicate values fails [#2422]

Hi Zoran, Thank you for your comment. I am going to apply your idea in the new commit. Best regards, /Danh -Original Message- From: Zoran Milinkovic Sent: Tuesday, May 8, 2018 3:47 PM To: Danh Cong Vo ;

Re: [devel] [PATCH 1/1] imm: sPbeRtMutations is updated even when validation for duplicate values fails [#2422]

Hi Danh, The block below can be rewritten to check only once and skip the check in the second loop: The block: +if ((attr->mFlags & SA_IMM_ATTR_NO_DUPLICATES) && +(multiattr->hasMatchingValue(tmpos))) { + LOG_NO( + "ERR_INVALID_PARAM: